Odoo Server (MOVED TO GITHUB)

Code review comment for lp:~openerp-dev/openobject-server/6.0-opw-17683-rgo

  1. 6.0-opw-17683-rgo
  2. Merge into 6.0
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

There is no else case in the two last nested 'if' statements.
- Can 'results' be empty? What should we return in that case?
- What should the method do if not results[0][1] == 'pdf' ?

Otherwise it looks okay.

review: Needs Fixing

« Back to merge proposal