Merge lp:~openerp-dev/openobject-server/6.0-opw-17683-rgo into lp:openobject-server/6.0
Proposed by
Ravi Gohil (OpenERP)
Status: | Superseded |
---|---|
Proposed branch: | lp:~openerp-dev/openobject-server/6.0-opw-17683-rgo |
Merge into: | lp:openobject-server/6.0 |
Diff against target: |
64 lines (+20/-14) 2 files modified
bin/report/render/rml2pdf/trml2pdf.py (+1/-1) bin/report/report_sxw.py (+19/-13) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-server/6.0-opw-17683-rgo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphael Collet (OpenERP) (community) | Needs Fixing | ||
Review via email: mp+77108@code.launchpad.net |
This proposal has been superseded by a proposal from 2011-10-03.
Description of the change
Hello,
There was as issue with pageCount tag in .rml files, pageCount tag returns 0.
This fixes the issue. The solution has been back-ported from Trunk.
Thanks.
To post a comment you must log in.
There is no else case in the two last nested 'if' statements.
- Can 'results' be empty? What should we return in that case?
- What should the method do if not results[0][1] == 'pdf' ?
Otherwise it looks okay.