Merge lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara into lp:openobject-addons
Proposed by
Ashvin Rathod (OpenERP)
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 4994 | ||||
Proposed branch: | lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara | ||||
Merge into: | lp:openobject-addons | ||||
Diff against target: |
82 lines (+8/-32) 1 file modified
account/account_move_line.py (+8/-32) |
||||
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mustufa Rangwala (Open ERP) (community) | Approve | ||
Ashvin Rathod (OpenERP) (community) | Needs Resubmitting | ||
qdp (OpenERP) | Needs Fixing | ||
Review via email: mp+61545@code.launchpad.net |
Description of the change
Hello,
Fix: account_move_line: uninitialized period_id
Thanks,
ara
To post a comment you must log in.
Hello,
Yes we are getting period_id in vals and we should use it.
so defining period_id at begining of the method seems ok but at the time of condition:
journal = journal_ obj.browse( cr, uid, journal_id, context=context)
if journal.allow_date and period_id:
we should use period_id from vals.
thanks,
mra