Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello,

Yes we are getting period_id in vals and we should use it.
so defining period_id at begining of the method seems ok but at the time of condition:

journal = journal_obj.browse(cr, uid, journal_id, context=context)
if journal.allow_date and period_id:

we should use period_id from vals.

thanks,
mra

review: Needs Fixing

« Back to merge proposal