Code review comment for lp:~openerp-dev/openerp-web/trunk-bug-1082009-bth

Revision history for this message
Fabien Meghazi (OpenERP) (fme) wrote :

You cannot globally set the view as readonly for a state that should be computed by record.
item#1 having a date_start readonly trough a @state modifier doesn't mean that it will be the same for item#2.

Besides, the more important issue here is the fact that the addons allows a given user to write a field that should not be writable according to the business logic.

In this particular case, a confirmed leave request should not have a date_start writable by the user.

I will transfer the related bug to the addons team.

review: Disapprove

« Back to merge proposal