Merge lp:~openerp-dev/openerp-web/trunk-bug-1082009-bth into lp:openerp-web

[Bhumi Thakkar (Open ERP)]

Hello,

   Calendar view should not allow drag & drop facility for readonly views.

To generate this issue:
1. In HUman Resources => Leaves => Leave Request
2. Open in Calendar view.

Observed:
A user gets leaves approved (e.g. sick days). Everybody can see this in the calendar (good!). Everybody can move the event around (bad!). This makes the calendar much less usable as a credible tool and source of information.
Expected:
Calendar view should not allow drag & drop facility for readonly views.

Check field has attribute readonly: true then could not drag and drop (move) the record.

Thanks.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Why the conditional? Why not just assign the first field to the second one, maybe converting to boolean inbetween just to be sure?

review: Needs Fixing

[lp:~openerp-dev/openerp-web/trunk-bug-1082009-bth]

3510. By Bhumi Thakkar (Open ERP) on 2012-11-29

[IMP] Remove condition and just assign the value.

[Bhumi Thakkar (Open ERP) (bth-openerp)]

> Why the conditional? Why not just assign the first field to the second one,
> maybe converting to boolean inbetween just to be sure?

Remove the condition and just assign the value.

review: Needs Resubmitting

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello,

I think checking just date_start readonly will not fix this issue, currently this fix will stops the feature of drag and drop in calendar view (Would you please recheck and test it with this fix) because if date_start will have readonly=True but there might be a possibility of state exceptions (readonly=True, states={'draft': [('readonly', False)]}), here you have not considered states exception

To check this create Sale order in sale order's calendar view, date_order is date_start and date_order has state exception for draft state, so in draft state date_order field will be editable and in all other state it will be readonly, so we should allow drag and drop for draft state.

The issue is that we will not have modifiers so that we can straight forward check whether field satisfying readonly or not, for calendar view, to fix this we should also consider state based conditions.

(One suggestion according to me) We may have to transfer the field's modifiers in calendar.js itself(As server's transfer_field_to_modifiers returns modifiers) and then we have to compute the domain based on modifiers to check date_start is readonly or not. With this fix we also have to put state field in calendar view as we web-client considers the fields of view in computing domain.

If you have better idea/suggestion or any other way to fix the state exception then it will be better to use that.

Thanks.

[Fabien Meghazi (OpenERP) (fme)]

You cannot globally set the view as readonly for a state that should be computed by record.
item#1 having a date_start readonly trough a @state modifier doesn't mean that it will be the same for item#2.

Besides, the more important issue here is the fact that the addons allows a given user to write a field that should not be writable according to the business logic.

In this particular case, a confirmed leave request should not have a date_start writable by the user.

I will transfer the related bug to the addons team.

review: Disapprove

Unmerged revisions

3510. By Bhumi Thakkar (Open ERP) on 2012-11-29

[IMP] Remove condition and just assign the value.

3509. By Bhumi Thakkar (Open ERP) on 2012-11-28

[FIX] Calendar view should not allow drag & drop facility for readonly views.--fixes:lp1082009

=== modified file 'addons/web_calendar/static/src/js/calendar.js'
--- addons/web_calendar/static/src/js/calendar.js	2012-11-21 16:04:52 +0000
+++ addons/web_calendar/static/src/js/calendar.js	2012-11-29 05:53:21 +0000
@@ -120,6 +120,7 @@
     init_scheduler: function() {
         var self = this;
         scheduler.clearAll();
+        scheduler.config.readonly = this.fields[this.date_start]['readonly'];
         if (this.fields[this.date_start]['type'] == 'time') {
             scheduler.config.xml_date = "%H:%M:%S";
         } else {