Code review comment for lp:~openerp-dev/openerp-web/6.1-opw-576425-bth

Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello Bhumi,

I have tested the scenario given in comment Juan and found that this fix breaks the feature of Save As and clear, Other logic is OK but the issue is with disabling buttons, as you have disabled buttons in start method of FieldBinary so if you go with existing record which has already binary data then also these buttons comes disable, here I have changed the code which will fix this.

Changed the code and disabled the buttons based on binary field value not based on file selection.

Thanks.

review: Needs Resubmitting

« Back to merge proposal