Merge lp:~openerp-dev/openerp-web/6.1-opw-576425-bth into lp:openerp-web/6.1

[Bhumi Thakkar (Open ERP)]

Hello,

   error when click on Save As button in attachments form when sending email.

1. Setting => Configuration => Email. Open or create any record.
2. Open Attachment tab. Click on Add Button => Create new attachment.
3. Select any file and then click on Save As button.

Observed: Error is coming "ValueError: No content found for field 'datas' on 'ir.attachment:'".
Expected: Download selected file

file content and file name both arguments are passed from js with 'saveas_ajax' method and parsing json data in saveas_ajax method. If attachment is exist in model then download from that if not then download selected file. After click on clear button download selected file if not selected then open attachment is downloaded.

Thanks.

[lp:~openerp-dev/openerp-web/6.1-opw-576425-bth]

2401. By Xavier (Open ERP) on 2012-07-13

[FIX] m2o-in-list-o2m focus issues introduced in o2m-autosave

issue revid: <email address hidden>

2402. By Xavier (Open ERP) on 2012-07-13

[IMP] missing translation marks in form and view editor

2403. By Xavier (Open ERP) on 2012-07-13

[FIX] dynamic addition of options in select in IE8, for export screen

2404. By Xavier (Open ERP) on 2012-07-13

[MERGE] manual reimplementation of progress bar for better cross-platform consistency and usability

html5 progress bar can not show progress in letters, so much less precision

2405. By Xavier (Open ERP) on 2012-07-13

[IMP] automatically close m2o autocomplete list inside dialog if dialog is dragged or resized

avoids autocomplete list being out of sync (positionally) with related m2o dialog

2406. By Xavier (Open ERP) on 2012-07-13

[TRANSLATIONS] new extraction after addition of new translation marks

2407. By Launchpad Translations on behalf of openerp on 2012-07-14

Launchpad automatic translations update.

2408. By Launchpad Translations on behalf of openerp on 2012-07-17

Launchpad automatic translations update.

2409. By Launchpad Translations on behalf of openerp on 2012-07-18

Launchpad automatic translations update.

2410. By Launchpad Translations on behalf of openerp on 2012-07-19

Launchpad automatic translations update.

2411. By Launchpad Translations on behalf of openerp on 2012-07-20

Launchpad automatic translations update.

2412. By Xavier (Open ERP) on 2012-07-20

[FIX] handling of focus/blur in date fields in relation to o2m autosave

2413. By Xavier (Open ERP) on 2012-07-20

[FIX] Ensure static file URLs are actually URLs, not windows file paths

2414. By Launchpad Translations on behalf of openerp on 2012-07-23

Launchpad automatic translations update.

2415. By Launchpad Translations on behalf of openerp on 2012-07-25

Launchpad automatic translations update.

2416. By Launchpad Translations on behalf of openerp on 2012-07-26

Launchpad automatic translations update.

2417. By Launchpad Translations on behalf of openerp on 2012-07-28

Launchpad automatic translations update.

2418. By Launchpad Translations on behalf of openerp on 2012-07-30

Launchpad automatic translations update.

2419. By Launchpad Translations on behalf of openerp on 2012-07-31

Launchpad automatic translations update.

2420. By Launchpad Translations on behalf of openerp on 2012-08-01

Launchpad automatic translations update.

2421. By Launchpad Translations on behalf of openerp on 2012-08-02

Launchpad automatic translations update.

2422. By Xavier (Open ERP) on 2012-08-03

[FIX] OPW 575691: parse server datetime manually

datejs's parser completely fails over itself during CST/EST transition

2423. By Xavier (Open ERP) on 2012-08-03

[FIX] correctly pass context to import_data so e.g. defaults from the action can reach write/update

2424. By Launchpad Translations on behalf of openerp on 2012-08-04

Launchpad automatic translations update.

2425. By Launchpad Translations on behalf of openerp on 2012-08-05

Launchpad automatic translations update.

2426. By Launchpad Translations on behalf of openerp on 2012-08-06

Launchpad automatic translations update.

2427. By Xavier (Open ERP) on 2012-08-10

[FIX] inability to select an autocompletion via mouse in an m2o in an editable o2m list

Problem due to over-eager form autosave.

Pretty straight backport of
revid:<email address hidden>

2428. By Olivier Dony (Odoo) on 2012-08-14

[MERGE] OPW 577592: form view - properly flag m2o fields as dirty when removing the value

2429. By Launchpad Translations on behalf of openerp on 2012-08-28

Launchpad automatic translations update.

2430. By Launchpad Translations on behalf of openerp on 2012-08-30

Launchpad automatic translations update.

2431. By Xavier (Open ERP) on 2012-08-31

[FIX] Correctly add new kanban records (from unfolding column) to dataset so they can be edited in form view

2432. By Xavier (Open ERP) on 2012-08-31

[FIX] make attachment deletion tooltip translatable

attachment_title can't be a method on SidebarAttachment because it doesn't correctly go through qweb context overloads/copies

2433. By Xavier (Open ERP) on 2012-08-31

[IMP] avoid potential error when specifying duplicated fields in read

Can't reproduce on my browser/machine, may be config-specific, but doesn't really hurt either way

2434. By Xavier (Open ERP) on 2012-08-31

[FIX] call update_dom on all form fields on save, even when they are valid (to clear out previously set invalid flag)

2435. By Xavier (Open ERP) on 2012-08-31

[FIX] list-sorting arrow not displayed and incorrectly positioned in Firefox, Opera

2436. By Xavier (Open ERP) on 2012-08-31

[FIX] don't store current context lang in action when creating ir.ui.view.custom for custom dashboards

2437. By Xavier (Open ERP) on 2012-08-31

[IMP] reload calendar event after save failure

2438. By Xavier (Open ERP) on 2012-08-31

[FIX] correctly show import errors from detect_data

wrong class was removed from wrong element

2439. By Xavier (Open ERP) on 2012-08-31

[FIX] MSIE8 errors out when trying to delete a property on the window host object, so set jsonp callback to null instead

2440. By Xavier (Open ERP) on 2012-08-31

[FIX] red background not appearing on save button of dirty form in MSIE

also, fix nonsensical -box-shadow property

2441. By Xavier (Open ERP) on 2012-08-31

[FIX] don't lose request_context argument in One2ManyDataSet#get_context

2442. By Xavier (Open ERP) on 2012-08-31

[FIX] generate noop stubs for all console methods in case of IE8

2443. By Xavier (Open ERP) on 2012-08-31

[FIX] restrict set_default values to the current user's company, courtesy of Guewen Baconnier

2444. By Xavier (Open ERP) on 2012-08-31

[FIX] have translatable url fields work correctly, courtesy of Guewen Baconnier

2445. By Xavier (Open ERP) on 2012-08-31

[FIX] don't display empty (false) fields literally in calendar event info

2446. By Xavier (Open ERP) on 2012-08-31

[IMP] re-export translation templates

2447. By Launchpad Translations on behalf of openerp on 2012-09-01

Launchpad automatic translations update.

2448. By Xavier (Open ERP) on 2012-09-03

[FIX] OPW 578531 Correctly invalidate BufferedDatasetCache when triggering an action @type=action ~/projects/tiny/web/current

otherwise when reloaded the record gets re-fetched from the cache, so
any modification from the action remains invisible until the parent
record itself is reloaded

2449. By Launchpad Translations on behalf of openerp on 2012-09-04

Launchpad automatic translations update.

2450. By Launchpad Translations on behalf of openerp on 2012-09-05

Launchpad automatic translations update.

2451. By Xavier (Open ERP) on 2012-09-06

[FIX] o2m breakage introduced in <email address hidden>

BufferedDataSet#read_ids expect coherent between #cache and
#to_create, patch removed a record from #cache which was in #to_create
leading to not being able to create new records in editable o2ms:

* The record would be inserted in #cache and #to_create
* The listview would reload the record
  - Evicting the record from #cache
  - And re-reading the record
  - Leading to breakage

Don't evict records locally edited from the cache, the server probably
doesn't know about it (at all) or we can assume the server's outdated,
so the local version remains the "correct" one and there's nothing
more recent to fetch.

2452. By Launchpad Translations on behalf of openerp on 2012-09-07

Launchpad automatic translations update.

2453. By Launchpad Translations on behalf of openerp on 2012-09-09

Launchpad automatic translations update.

2454. By Launchpad Translations on behalf of openerp on 2012-09-10

Launchpad automatic translations update.

2455. By Launchpad Translations on behalf of openerp on 2012-09-11

Launchpad automatic translations update.

2456. By Launchpad Translations on behalf of openerp on 2012-09-12

Launchpad automatic translations update.

2457. By Launchpad Translations on behalf of openerp on 2012-09-17

Launchpad automatic translations update.

2458. By Launchpad Translations on behalf of openerp on 2012-09-18

Launchpad automatic translations update.

2459. By Launchpad Translations on behalf of openerp on 2012-09-20

Launchpad automatic translations update.

2460. By Olivier Dony (Odoo) on 2012-09-24

[FIX] OPW 577261, 573269: properly refresh one2many records after clicking on a form button

This patch reverts the previous patch for OPW 573269
that did not properly fix all cases (workflow buttons
for instance). This is a backport of the trunk fix.

previous fix: rev-id: <email address hidden>
trunk fix: r.3104 rev-id: <email address hidden>

[Jiten (OpenERP) (jiten-openerp)]

Hello,

I have tested as your description and found that, Issue is solved when we select any file and than click on button 'Save As'. BUT if we does not select any file for attachment and than click on button 'Save As' then its arise same error which you described.

So, i think still it's need to improve code.

Thanks.

review: Needs Fixing

[Bhumi Thakkar (Open ERP) (bth-openerp)]

Hello,

    Disabled save as button and clear button until file is not selected.

Thanks.

review: Needs Resubmitting

[lp:~openerp-dev/openerp-web/6.1-opw-576425-bth]

2461. By Launchpad Translations on behalf of openerp on 2012-10-02

Launchpad automatic translations update.

2462. By Launchpad Translations on behalf of openerp on 2012-10-04

Launchpad automatic translations update.

2463. By Launchpad Translations on behalf of openerp on 2012-10-06

Launchpad automatic translations update.

2464. By Launchpad Translations on behalf of openerp on 2012-10-15

Launchpad automatic translations update.

2465. By Launchpad Translations on behalf of openerp on 2012-10-16

Launchpad automatic translations update.

2466. By Launchpad Translations on behalf of openerp on 2012-10-17

Launchpad automatic translations update.

2467. By Launchpad Translations on behalf of openerp on 2012-10-20

Launchpad automatic translations update.

2468. By Launchpad Translations on behalf of openerp on 2012-10-21

Launchpad automatic translations update.

2469. By Launchpad Translations on behalf of openerp on 2012-10-22

Launchpad automatic translations update.

2470. By Launchpad Translations on behalf of openerp on 2012-10-23

Launchpad automatic translations update.

2471. By Xavier ALT on 2012-10-23

[MERGE] OPW 579322: form: after field value change, force update of field's error status if field is currently marked as invalid

2472. By Launchpad Translations on behalf of openerp on 2012-10-24

Launchpad automatic translations update.

2473. By Launchpad Translations on behalf of openerp on 2012-10-26

Launchpad automatic translations update.

2474. By Launchpad Translations on behalf of openerp on 2012-10-30

Launchpad automatic translations update.

2475. By Launchpad Translations on behalf of openerp on 2012-10-31

Launchpad automatic translations update.

2476. By Launchpad Translations on behalf of openerp on 2012-11-03

Launchpad automatic translations update.

2477. By Xavier (Open ERP) on 2012-11-04

[FIX] avoid overwriting sensible error message with garbage when reading or decoding the CSV file fails

also improve error message in case of decoding error (turns out UnicodeDecodeError has everything you need to know exactly what blew up, who knew?)

2478. By Launchpad Translations on behalf of openerp on 2012-11-06

Launchpad automatic translations update.

2479. By Launchpad Translations on behalf of openerp on 2012-11-07

Launchpad automatic translations update.

2480. By Launchpad Translations on behalf of openerp on 2012-11-15

Launchpad automatic translations update.

2481. By Launchpad Translations on behalf of openerp on 2012-11-16

Launchpad automatic translations update.

2482. By Launchpad Translations on behalf of openerp on 2012-11-18

Launchpad automatic translations update.

2483. By Launchpad Translations on behalf of openerp on 2012-11-19

Launchpad automatic translations update.

2484. By Launchpad Translations on behalf of openerp on 2012-11-22

Launchpad automatic translations update.

2485. By Launchpad Translations on behalf of openerp on 2012-11-25

Launchpad automatic translations update.

2486. By Launchpad Translations on behalf of openerp on 2012-11-28

Launchpad automatic translations update.

2487. By Launchpad Translations on behalf of openerp on 2012-11-29

Launchpad automatic translations update.

2488. By Xavier ALT on 2012-11-29

[MERGE] OPW 579391: graph view: x-axis should respect order of selection field values

2489. By Launchpad Translations on behalf of openerp on 2012-11-30

Launchpad automatic translations update.

2490. By Xavier ALT on 2012-12-04

[MERGE] OPW 579638: translation box have to save value of current language.

  when changing English translation of a record created in another language
  (i.e. having no distinct ir.translation value) we force saving all other
  languages too, this to avoid loosing creation translation. (btw, this make
  the behaviour consistent with GTK client).

2491. By Xavier ALT on 2012-12-04

[MERGE] OPW 579519: many2one button should not trigger 'blur' if contenual menu is open

  if many2one contexual menu is visible, make sure we won't trigger 'blur' from
  context button otherwise in editable list, row edition will be cancelled

2492. By Launchpad Translations on behalf of openerp on 2012-12-05

Launchpad automatic translations update.

2493. By Launchpad Translations on behalf of openerp on 2012-12-06

Launchpad automatic translations update.

2494. By Launchpad Translations on behalf of openerp on 2012-12-08

Launchpad automatic translations update.

2495. By Launchpad Translations on behalf of openerp on 2012-12-11

Launchpad automatic translations update.

2496. By Launchpad Translations on behalf of openerp on 2012-12-13

Launchpad automatic translations update.

2497. By Launchpad Translations on behalf of openerp on 2012-12-14

Launchpad automatic translations update.

2498. By Launchpad Translations on behalf of openerp on 2012-12-17

Launchpad automatic translations update.

2499. By Launchpad Translations on behalf of openerp on 2012-12-18

Launchpad automatic translations update.

[Juan Alonso (juan-jalogut)]

I've tested the patch and it looks very good, but still having a bug:

    - When you upload a file on a binary field everything works properly, "save as" button is enabled and downloading files works like a dream. The problem comes when you open the form view of any record with binary fields already uploaded, in this case "save as" buttons are always disabled, thus you cannot download the files. So, It's like the "save as" button is only getting enabled when you select a new file, but later, when you open any form view these buttons are disabled even if there files uploaded in them.

Could you check it out?

review: Needs Fixing

[lp:~openerp-dev/openerp-web/6.1-opw-576425-bth]

2500. By Mohammed Shekha(Open ERP) on 2012-12-20

[FIX]Refixed the issue of BinaryWidget buttons, buttons should be disable if there is no value in binary field otherwise it should be enable.

[Mohammed Shekha(Open ERP) (msh-openerp)]

Hello Bhumi,

I have tested the scenario given in comment Juan and found that this fix breaks the feature of Save As and clear, Other logic is OK but the issue is with disabling buttons, as you have disabled buttons in start method of FieldBinary so if you go with existing record which has already binary data then also these buttons comes disable, here I have changed the code which will fix this.

Changed the code and disabled the buttons based on binary field value not based on file selection.

Thanks.

review: Needs Resubmitting

Unmerged revisions

2500. By Mohammed Shekha(Open ERP) on 2012-12-20

[FIX]Refixed the issue of BinaryWidget buttons, buttons should be disable if there is no value in binary field otherwise it should be enable.

=== modified file 'addons/web/controllers/main.py'
--- addons/web/controllers/main.py	2012-11-04 19:25:08 +0000
+++ addons/web/controllers/main.py	2012-12-20 11:42:21 +0000
@@ -1449,6 +1449,8 @@
         jdata = simplejson.loads(data)
         model = jdata['model']
         field = jdata['field']
+        content = jdata.get('filecontent', None)
+        fname = jdata.get('filename', None)
         id = jdata.get('id', None)
         filename_field = jdata.get('filename_field', None)
         context = jdata.get('context', dict())
@@ -1456,20 +1458,28 @@
         context = req.session.eval_context(context)
         Model = req.session.model(model)
         fields = [field]
+
         if filename_field:
             fields.append(filename_field)
         if id:
             res = Model.read([int(id)], fields, context)[0]
         else:
             res = Model.default_get(fields, context)
-        filecontent = base64.b64decode(res.get(field, ''))
+        if content:
+            filecontent = base64.b64decode(content)
+        else:
+            filecontent = base64.b64decode(res.get(field, ''))
+        if fname:
+            filename = fname
+        else:
+            filename = '%s_%s' % (model.replace('.', '_'), id)
+            if filename_field:
+                filename = res.get(filename_field, '') or filename
+
         if not filecontent:
             raise ValueError("No content found for field '%s' on '%s:%s'" %
                 (field, model, id))
         else:
-            filename = '%s_%s' % (model.replace('.', '_'), id)
-            if filename_field:
-                filename = res.get(filename_field, '') or filename
             return req.make_response(filecontent,
                 headers=[('Content-Type', 'application/octet-stream'),
                         ('Content-Disposition', self.content_disposition(filename, req))],

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2012-12-04 11:02:12 +0000
+++ addons/web/static/src/js/view_form.js	2012-12-20 11:42:21 +0000
@@ -3517,6 +3517,8 @@
                 id: (this.view.datarecord.id || ''),
                 field: this.name,
                 filename_field: (this.node.attrs.filename || ''),
+                filecontent: this.filecontent || '',
+                filename: this.filename || '',
                 context: this.view.dataset.get_context()
             })},
             complete: $.unblockUI,
@@ -3544,6 +3546,8 @@
     template: 'FieldBinaryFile',
     update_dom: function() {
         this._super.apply(this, arguments);
+        var disabled = this.value ? false : true;
+        this.$element.find('button.oe-binary-file-save, .oe-binary-file-clear').prop('disabled', disabled);
         this.$element.find('.oe-binary-file-set, .oe-binary-file-clear').toggle(!this.readonly);
         this.$element.find('input[type=text]').prop('readonly', this.readonly);
     },
@@ -3559,6 +3563,8 @@
     },
     on_file_uploaded_and_valid: function(size, name, content_type, file_base64) {
         this.value = file_base64;
+        this.filecontent = file_base64;
+        this.filename = name;
         this.binary_value = true;
         var show_value = name + " (" + this.human_filesize(size) + ")";
         this.$element.find('input').eq(0).val(show_value);