Code review comment for lp:~openerp-community/openobject-addons/meanmicio_base_vat6

Revision history for this message
qdp (OpenERP) (qdp) wrote :

Hello Luis,

i checked this branch and i have a doubt on the utility of splitting the vat number in two parts: i don't see the added value of such a thing. Also i'm not sure we want the avoid verification feature in core module. For this, maybe an extra module would do the trick.

For the argentinian vat validation algorithm, i'd be glad to add it but could you please provide an example of a valid argentinian vat number in the _ref_vat dictionary? This could be usefull for tests but it is also used to display an accurate message when the encoded vat number is not correct.

review: Needs Information

« Back to merge proposal