Merge lp:~openerp-community/openobject-addons/meanmicio_base_vat6 into lp:openobject-addons
Proposed by
Luis Falcon - Thymbra
Status: | Rejected |
---|---|
Rejected by: | Fabien (Open ERP) |
Proposed branch: | lp:~openerp-community/openobject-addons/meanmicio_base_vat6 |
Merge into: | lp:openobject-addons |
Diff against target: |
131 lines (+71/-9) 2 files modified
base_vat/base_vat.py (+66/-6) base_vat/base_vat_view.xml (+5/-3) |
To merge this branch: | bzr merge lp:~openerp-community/openobject-addons/meanmicio_base_vat6 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
qdp (OpenERP) | Needs Information | ||
Review via email: mp+41852@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 3958. By lfm <lfm@beastie>
-
Add the following functionality
- Add Argentinian VAT number verification algorithm
- The VAT is calculated depending on the country.
- No need to insert the two letter code in the VAT number, since it's
not part of it anyways. Now the function will be calculated from the
country code taken from the VAT country name
- Added a verification flag, so you can avoid the verification if you want.
- Change the name of the file "base_vat_data.xml" to "base_vat_view.xml"
Hello Luis,
i checked this branch and i have a doubt on the utility of splitting the vat number in two parts: i don't see the added value of such a thing. Also i'm not sure we want the avoid verification feature in core module. For this, maybe an extra module would do the trick.
For the argentinian vat validation algorithm, i'd be glad to add it but could you please provide an example of a valid argentinian vat number in the _ref_vat dictionary? This could be usefull for tests but it is also used to display an accurate message when the encoded vat number is not correct.