Code review comment for lp:~om26er/unity/test_alt_arrowkeys

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi Omer,

42 + self.keyboard.type('echo \"')

I don't think you need the \ here. Python doesn't need it (you can use double quotes inside a single quoted string just fine), and I'm pretty sure the keyboard emulator doesn't need it either...

52 + self.keyboard.type('\" > /tmp/ap_test_alt_keys')

.. same here

Otherwise this test looks good.

review: Needs Fixing

« Back to merge proposal