Merge lp:~om26er/unity/test_alt_arrowkeys into lp:unity

[Omer Akram]

Tests that Alt+ArrowKey events are correctly passed to the active window when not interacting with Unity.

Tests that Alt+ArrowKey events are correctly passed to the active window when not interacting with Unity.

since we can't read text from terminal, we are writing it to a text file and reading from there if it matches the expected.

thx Thomi

[Thomi Richards (thomir)]

Hi Omer,

42 + self.keyboard.type('echo \"')

I don't think you need the \ here. Python doesn't need it (you can use double quotes inside a single quoted string just fine), and I'm pretty sure the keyboard emulator doesn't need it either...

52 + self.keyboard.type('\" > /tmp/ap_test_alt_keys')

.. same here

Otherwise this test looks good.

review: Needs Fixing

[Brandon Schaefer (brandontschaefer)]

Looks good to me. Fixed what Thomi wanted fixed :)

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1094/console reported an error when processing this lp:~om26er/unity/test_alt_arrowkeys branch.
Not merging it.

[Omer Akram (om26er)]

re-approved looks like autolanding is working again.

[lp:~om26er/unity/test_alt_arrowkeys]

2602. By Omer Akram on 2012-08-21

merge

2603. By Omer Akram on 2012-08-21

merge

=== modified file 'manual-tests/Hud.txt'
--- manual-tests/Hud.txt	2012-08-18 11:05:32 +0000
+++ manual-tests/Hud.txt	2012-08-21 21:29:18 +0000
@@ -33,21 +33,6 @@
   After pressing escape in step three, the text "test" should be removed from the hud search
   After step four, the hud should dismiss itself and not be present.
 
-Alt+Arrow keys not passed to application
-----------------------------------------
-Tests that Alt+ArrowKey events are correctly passed to the active window
-when Unity is not responding to them.
-
-Note: Should be automated
-
-Setup:
-#. Open gnome-terminal
-
-Actions:
-#. While holding Alt, tap arrow keys: Up, Down, Right, Left
-
-Expected Result:
-  The terminal should show the keycodes were received as text "ABCD".
 
 Alt+Enter Crash
 ---------------

=== modified file 'tests/autopilot/unity/tests/test_hud.py'
--- tests/autopilot/unity/tests/test_hud.py	2012-08-21 12:33:40 +0000
+++ tests/autopilot/unity/tests/test_hud.py	2012-08-21 21:29:18 +0000
@@ -278,6 +278,31 @@
         
         self.assertThat(self.hud.visible, Eventually(Equals(False)))
 
+    def test_alt_arrow_keys_not_eaten(self):
+        """Tests that Alt+ArrowKey events are correctly passed to the
+        active window when Unity is not responding to them."""
+        
+        self.start_app_window("Terminal")
+        
+        #There's no easy way to read text from terminal, writing input
+        #to a text file and then reading from there works.
+        self.keyboard.type('echo "')
+        
+        #Terminal is receiving input with Alt+Arrowkeys
+        self.keyboard.press("Alt")
+        self.keyboard.press_and_release("Up")
+        self.keyboard.press_and_release("Down")
+        self.keyboard.press_and_release("Right")
+        self.keyboard.press_and_release("Left")
+        self.keyboard.release("Alt")
+        
+        self.keyboard.type('" > /tmp/ap_test_alt_keys')
+        self.addCleanup(remove, '/tmp/ap_test_alt_keys')
+        self.keyboard.press_and_release("Enter")
+        
+        file_contents = open('/tmp/ap_test_alt_keys', 'r').read().strip()
+        
+        self.assertThat(file_contents, Equals('ABCD'))
 
 class HudLauncherInteractionsTests(HudTestsBase):