Merge lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3 into lp:~ubuntu-desktop/totem/ubuntu

Proposed by Omer Akram
Status: Merged
Merged at revision: 92
Proposed branch: lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3
Merge into: lp:~ubuntu-desktop/totem/ubuntu
Diff against target: 111 lines (+91/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/add_show_tooltip_uri_property.patch (+83/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+45140@code.launchpad.net

Description of the change

it turns out there were two commits needed to fix bug 696171 so now backported the second commit too.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-01-04 05:58:45 +0000
+++ debian/changelog 2011-01-04 16:41:24 +0000
@@ -1,3 +1,10 @@
1totem (2.32.0-0ubuntu5) natty; urgency=low
2
3 * debian/patches/add_show_tooltip_uri_property.patch:
4 - Really don't show youtube URLs in tooltips. (LP: #696171)
5
6 -- Omer Akram <om26er@ubuntu.com> Tue, 04 Jan 2011 21:32:04 +0500
7
1totem (2.32.0-0ubuntu4) natty; urgency=low8totem (2.32.0-0ubuntu4) natty; urgency=low
29
3 * debian/patches/dont_display_URIs_in_youtube_tooltips.patch:10 * debian/patches/dont_display_URIs_in_youtube_tooltips.patch:
411
=== added file 'debian/patches/add_show_tooltip_uri_property.patch'
--- debian/patches/add_show_tooltip_uri_property.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/add_show_tooltip_uri_property.patch 2011-01-04 16:41:24 +0000
@@ -0,0 +1,83 @@
1From: Philip Withnall <philip@tecnocode.co.uk>
2Subject: Add a TotemVideoList::show-tooltip-uri property.
3Origin: http://git.gnome.org/browse/totem/commit/?id=19857f506a3ff83b14ce461072ce4edadd612557
4Bug: https://bugs.gnome.org/629548
5Bug-Ubuntu: https://launchpad.net/bugs/696171
6
7--- a/src/totem-video-list.c
8+++ b/src/totem-video-list.c
9@@ -58,6 +58,7 @@ struct _TotemVideoListPrivate {
10 GtkBuilder *xml;
11 GtkActionGroup *action_group;
12 GtkUIManager *ui_manager;
13+ gboolean show_tooltip_uri;
14 };
15
16 #define TOTEM_VIDEO_LIST_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE ((obj), TOTEM_TYPE_VIDEO_LIST, TotemVideoListPrivate))
17@@ -65,7 +66,8 @@ struct _TotemVideoListPrivate {
18 enum {
19 PROP_TOOLTIP_COLUMN = 1,
20 PROP_MRL_COLUMN,
21- PROP_TOTEM
22+ PROP_TOTEM,
23+ PROP_SHOW_TOOLTIP_URI
24 };
25
26 enum {
27@@ -156,6 +158,18 @@ totem_video_list_class_init (TotemVideoListClass *klass)
28 TOTEM_TYPE_OBJECT, G_PARAM_READWRITE));
29
30 /**
31+ * TotemVideoList:show-tooltip-uri:
32+ *
33+ * If this is %TRUE, the URI of each video will be displayed in the tooltip for that video (or a message saying "No video URI" will be
34+ * displayed if the URI is unset); otherwise, the tooltip will only display the video name.
35+ *
36+ * Since: 2.90.6
37+ **/
38+ g_object_class_install_property (object_class, PROP_SHOW_TOOLTIP_URI,
39+ g_param_spec_boolean ("show-tooltip-uri", NULL, NULL,
40+ TRUE, G_PARAM_READWRITE));
41+
42+ /**
43 * TotemVideoList::starting-video:
44 * @video_list: the #TotemVideoList which received the signal
45 * @tree_path: the #GtkTreePath of the video row about to be played
46@@ -184,6 +198,7 @@ totem_video_list_init (TotemVideoList *self)
47 self->priv->totem = NULL;
48 self->priv->tooltip_column = -1;
49 self->priv->mrl_column = -1;
50+ self->priv->show_tooltip_uri = TRUE;
51
52 /* Get the interface */
53 self->priv->xml = totem_interface_load ("video-list.ui", TRUE, NULL, self);
54@@ -246,6 +261,10 @@ totem_video_list_set_property (GObject *object, guint property_id, const GValue
55 priv->totem = (Totem*) g_value_dup_object (value);
56 g_object_notify (object, "totem");
57 break;
58+ case PROP_SHOW_TOOLTIP_URI:
59+ priv->show_tooltip_uri = g_value_get_boolean (value);
60+ g_object_notify (object, "show-tooltip-uri");
61+ break;
62 default:
63 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
64 }
65@@ -267,6 +286,9 @@ totem_video_list_get_property (GObject *object, guint property_id, GValue *value
66 case PROP_TOTEM:
67 g_value_set_object (value, G_OBJECT (priv->totem));
68 break;
69+ case PROP_SHOW_TOOLTIP_URI:
70+ g_value_set_boolean (value, priv->show_tooltip_uri);
71+ break;
72 default:
73 G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
74 }
75@@ -292,7 +314,7 @@ query_tooltip_cb (GtkWidget *widget, gint x, gint y, gboolean keyboard_mode, Gtk
76 &model, &path, &iter))
77 return FALSE;
78
79- if (self->priv->mrl_column == -1) {
80+ if (self->priv->mrl_column == -1 || self->priv->show_tooltip_uri == FALSE) {
81 gtk_tree_model_get (model, &iter, self->priv->tooltip_column, &tooltip_text, -1);
82 gtk_tooltip_set_text (tooltip, tooltip_text);
83 g_free (tooltip_text);
084
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-01-04 05:58:45 +0000
+++ debian/patches/series 2011-01-04 16:41:24 +0000
@@ -1,3 +1,4 @@
1add_show_tooltip_uri_property.patch
1dont_display_URIs_in_youtube_tooltips.patch2dont_display_URIs_in_youtube_tooltips.patch
201_fake_keypresses.patch301_fake_keypresses.patch
302_lpi.patch402_lpi.patch

Subscribers

People subscribed via source and target branches

to all changes: