dialer-app

Code review comment for lp:~om26er/dialer-app/fix_failing_test_due_to_change_in_messaging

  1. fix_failing_test_due_to_change_in_messaging
  2. Merge into trunk
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and indeed fixes the problem.

review: Approve

« Back to merge proposal