Merge lp:~om26er/dialer-app/fix_failing_test_due_to_change_in_messaging into lp:dialer-app

[Omer Akram]

fix failing test due to change in messaging-app

a change in messaging-app was causing a test failure, adapt to that change

Are there any related MPs required for this MP to build/function as expected? Please list.

No.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

Yes.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

Ran test suite multiple times

Did you successfully run all tests found in your component's Test Plan on device or emulator?

test change, not needed.

If you changed the UI, was the change specified/approved by design?

No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

No change.

[lp:~om26er/dialer-app/fix_failing_test_due_to_change_in_messaging]

104. By Omer Akram on 2014-02-21

also enable the skipped test, now that the telephony-service have fixed the bug

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:104
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/198/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-amd64-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/105
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-armhf-ci/105/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-trusty-i386-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3401
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3055
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3403
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3403/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3057
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3057/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5452
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4190

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/198/rebuild

review: Approve (continuous-integration)

[Gustavo Pichorim Boiko (boiko)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and indeed fixes the problem.

review: Approve

=== modified file 'tests/autopilot/dialer_app/tests/test_logs.py'
--- tests/autopilot/dialer_app/tests/test_logs.py	2014-02-12 17:42:47 +0000
+++ tests/autopilot/dialer_app/tests/test_logs.py	2014-02-21 14:54:38 +0000
@@ -23,7 +23,6 @@
 import os
 import subprocess
 import time
-import unittest
 
 
 @skipIf(model() == 'Desktop',
@@ -77,9 +76,8 @@
 
         self.assertThat(msg_app_view.visible, Eventually(Equals(True)))
         self.assertThat(msgs_pane.visible, Eventually(Equals(True)))
-        self.assertThat(msgs_pane.number, Eventually(Equals("800")))
+        self.assertThat(msgs_pane.title, Eventually(Equals("800")))
 
-    @unittest.skip('Test is failing, due to OSD bug, will re-enable soon')
     def test_add_new_contact_from_log(self):
         """Ensure tapping on 'add new contact' item of a call log opens
         the address-book app to allow adding new contact.