Code review comment for lp:~ogayot/whoopsie/whoopsie

> This looks great and I'm happy to upload it, but I have one question which
> appears in the diff.

Thanks for the feedback, I appreciate it!

Although whoopsie is not single-threaded strictly speaking, both `process_existing_files` and `network_changed` are callbacks managed by a single event-loop. Therefore, they shouldn't have the opportunity to execute in parallel.

I wanted to confirm that my understanding was correct so I ran a quick test where whoopsie sleeps for 5 seconds between each crash report it tries to process (there are 3 crash reports). I brought the network down while whoopsie was slowly reading the crash directory and it did not detect the network change until it finishes processing the files, so it should be good :)

[22:08:30] Not a paid data plan: /org/freedesktop/NetworkManager/ActiveConnection/15
[22:08:30] Found usable connection: /org/freedesktop/NetworkManager/ActiveConnection/15
[22:08:35] Now moving on to file _usr_bin_devnull-http.0.crash [ online_state is 1 ]
$ nmcli networking off
[22:08:40] Now moving on to file _usr_bin_debdiff-apply.1000.crash [ online_state is 1 ]
[22:08:45] Now moving on to file _usr_lib_chromium-browser_chromium-browser.1000.crash [ online_state is 1 ]
[22:08:45] offline

Thanks,
Olivier