Code review comment for lp:~oem-qa/checkbox-editor/784583

Revision history for this message
Javier Collado (javier.collado) wrote :

@Sylvain

Thanks for this merge proposal. I think that the assumption that every remote job will generate children job names that start with the same prefix is a safe one (at least for checkbox-oem).

There is one issue with the code. The text that is displayed in the whitelist view is escaped using re.escape so any string that ends with '.*' is saved as '\.\*' which is not what you're trying to do.

I'll think about a way to fix this while keeping the whitelist view as friendly as possible (probably regular expression patterns shouldn't be displayed there) before you come back from vacation so this is just a reminder for myself.

review: Needs Fixing

« Back to merge proposal