Code review comment for lp:~nttdata/nova/850602

Revision history for this message
Jason Kölker (jason-koelker) wrote :

Functionality looks good. Just a few fixes in the tests:

15 + #network_info = _fake_network_info(self.stubs, 1)
Instead of leaving the other network_info lines comented out, they should be deleted.

56 + open('/tmp/aaa', 'w+').write(str(info))
Do you mean to leave this file around?

Other than that, looks good.

review: Needs Fixing

« Back to merge proposal