Merge lp:~nttdata/nova/850602 into lp:~hudson-openstack/nova/trunk
Proposed by
Kei Masumoto
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Brian Waldon | ||||
Proposed branch: | lp:~nttdata/nova/850602 | ||||
Merge into: | lp:~hudson-openstack/nova/trunk | ||||
Diff against target: |
145 lines (+47/-12) 2 files modified
nova/tests/test_libvirt.py (+17/-9) nova/virt/libvirt/connection.py (+30/-3) |
||||
To merge this branch: | bzr merge lp:~nttdata/nova/850602 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Kölker (community) | Approve | ||
Brian Waldon (community) | Approve | ||
Review via email: mp+75480@code.launchpad.net |
Description of the change
block migration needs to copy backing_file.
This branch enables existing nova handling backing_file.
Changes has been done to 2 methods in nova.virt.
- pre_block_migration
- get_instance_
Unit-test is also changed following this changes.
To post a comment you must log in.
Unmerged revisions
- 1575. By Kei Masumoto
-
delete unnecessary os.remove(disk) in pre_block_
migration. block_migration fails if disk is removed. - 1574. By Kei Masumoto
-
using instance[
'local_ gb'] on creating backing file - 1573. By Kei Masumoto
-
pep8 error and unnecessary debug statement fixed
- 1572. By Kei Masumoto
-
fix bugs
Functionality looks good. Just a few fixes in the tests:
15 + #network_info = _fake_network_ info(self. stubs, 1)
Instead of leaving the other network_info lines comented out, they should be deleted.
56 + open('/tmp/aaa', 'w+').write( str(info) )
Do you mean to leave this file around?
Other than that, looks good.