GTG

Merge lp:~nimit-svnit/gtg/bug-1037051 into lp:~gtg/gtg/old-trunk

Proposed by Nimit Shah
Status: Merged
Merged at revision: 1230
Proposed branch: lp:~nimit-svnit/gtg/bug-1037051
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 23 lines (+2/-0)
2 files modified
CHANGELOG (+1/-0)
GTG/core/task.py (+1/-0)
To merge this branch: bzr merge lp:~nimit-svnit/gtg/bug-1037051
Reviewer Review Type Date Requested Status
Bertrand Rousseau (community) code, run Approve
Review via email: mp+119733@code.launchpad.net

Description of the change

Fix for bug-1037051 (Due date is not set for a new subtask)

To post a comment you must log in.
Revision history for this message
Izidor Matušov (izidor) wrote :

Could you try to solve bug #1036695 and bug #1036955 as well. A similar fix should solve those bugs as well. It would be better to have just one merge request instead of 3 of them :)

Revision history for this message
Nimit Shah (nimit-svnit) wrote :

      okay sure!
Nimit Shah,
B Tech 4th year,
Computer Engineering Department,
SVNIT Surat
www.dude-says.blogspot.com

On Wed, Aug 15, 2012 at 10:39 PM, Izidor Matušov
<email address hidden>wrote:

> Could you try to solve bug #1036695 and bug #1036955 as well. A similar
> fix should solve those bugs as well. It would be better to have just one
> merge request instead of 3 of them :)
> --
> https://code.launchpad.net/~nimit-svnit/gtg/bug-1037051/+merge/119733
> You are the owner of lp:~nimit-svnit/gtg/bug-1037051.
>

Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Hi!
   I tried to solve bug #1036695 but the solution that I could think of would add a big function (possibly unnecessarily) to the code. Hence, I suggest that someone else tries to solve it. Same goes for bug #1036955

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Ok!

review: Approve (code, run)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGELOG'
2--- CHANGELOG 2012-08-14 07:08:45 +0000
3+++ CHANGELOG 2012-08-15 15:27:24 +0000
4@@ -48,6 +48,7 @@
5 * Fix for bug #1027844: Fuzzy date shouldn't become start date
6 * Save backups into backup/ folder, creates backups of tags.xml closes #993920
7 * Search filter is deleted on empty search if tag_pane is closed, by Stefan Handschuh, closes #996236
8+ * Fix for bug-1037051 (Due date is not set for a new subtask), by Nimit Shah
9
10 2012-02-13 Getting Things GNOME! 0.2.9
11 * Big refractorization of code, now using liblarch
12
13=== modified file 'GTG/core/task.py'
14--- GTG/core/task.py 2012-08-12 23:52:39 +0000
15+++ GTG/core/task.py 2012-08-15 15:27:24 +0000
16@@ -429,6 +429,7 @@
17 child = self.req.get_task(tid)
18 if self.is_loaded() and child and child.can_be_deleted:
19 child.set_start_date(self.get_start_date())
20+ child.set_due_date(self.get_due_date())
21 for t in self.get_tags():
22 child.add_tag(t.get_name())
23 self.sync()

Subscribers

People subscribed via source and target branches

to status/vote changes: