Merge lp:~nik90/ubuntu-calendar-app/tweak-event-color into lp:ubuntu-calendar-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Mihir Soni
Approved revision: 464
Merged at revision: 458
Proposed branch: lp:~nik90/ubuntu-calendar-app/tweak-event-color
Merge into: lp:ubuntu-calendar-app
Diff against target: 104 lines (+25/-32)
1 file modified
EventBubble.qml (+25/-32)
To merge this branch: bzr merge lp:~nik90/ubuntu-calendar-app/tweak-event-color
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+235137@code.launchpad.net

Commit message

Set the event background color to that of its calendar to make it more clear to the user. Also distinguished past events from future events.

Description of the change

This MP implements the following,
- Sets the event background color to that of its calendar to make it more clear to the user
- Distinguish past events from future events.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Hi,
Thanks for MR and it looks great, couple of observation :-

1. this might look cumbersome when there are overlapping events in past because of opacity [1].
2. As kunal pointed out, wouldn't opacity will cause performance issues..? [2]

[1]: http://i.imgur.com/nEIXY3y.png
[2]: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1369025

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Hi,
> Thanks for MR and it looks great, couple of observation :-
>
> 1. this might look cumbersome when there are overlapping events in past
> because of opacity [1].
> 2. As kunal pointed out, wouldn't opacity will cause performance issues..? [2]
>
>
> [1]: http://i.imgur.com/nEIXY3y.png
> [2]: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1369025

Good Point! I addressed them both by removing the opacity change and instead reducing the darkness of the background and striking out the event details of past events.

https://imgur.com/T0SBwVP

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

An even better screenshot -> https://imgur.com/zlXeX9l

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

lgtm!
Thanks Nekhelesh

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'EventBubble.qml'
--- EventBubble.qml 2014-09-08 10:21:19 +0000
+++ EventBubble.qml 2014-09-19 07:44:22 +0000
@@ -15,7 +15,8 @@
15 * You should have received a copy of the GNU General Public License15 * You should have received a copy of the GNU General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17 */17 */
18import QtQuick 2.018
19import QtQuick 2.3
19import Ubuntu.Components 1.120import Ubuntu.Components 1.1
2021
21Item{22Item{
@@ -40,8 +41,6 @@
40 UbuntuShape{41 UbuntuShape{
41 id: bg42 id: bg
42 anchors.fill: parent43 anchors.fill: parent
43 color: "white"
44 gradientColor: "#F5F5F5"
45 }44 }
4645
47 function resize() {46 function resize() {
@@ -126,10 +125,10 @@
126 timeLabel.text = event.displayLabel;125 timeLabel.text = event.displayLabel;
127 }126 }
128127
129 if(model) {128 if(model) {
130 var collection = model.collection( event.collectionId );129 var collection = model.collection( event.collectionId );
131 calendarIndicator.color = collection.color130 bg.color = collection.color
132 }131 }
133132
134 layoutBubbleDetails();133 layoutBubbleDetails();
135 }134 }
@@ -161,47 +160,41 @@
161 width: parent.width160 width: parent.width
162 height: detailsColumn.height161 height: detailsColumn.height
163162
164 Column{163 Column {
165 id: detailsColumn164 id: detailsColumn
166165
167 anchors {166 anchors {
168 top: parent.top; left: parent.left; right: parent.right; margins: units.gu(1)167 top: parent.top
168 left: parent.left
169 right: parent.right
170 margins: units.gu(1)
169 }171 }
170172
171 Row{173 Label {
174 id: timeLabel
175 objectName: "timeLabel"
176 color: "White"
177 fontSize:"small"
178 font.bold: true
172 width: parent.width179 width: parent.width
180 }
173181
174 Label{182 Label {
175 id: timeLabel
176 objectName: "timeLabel"
177 fontSize:"small";
178 color:"gray"
179 width: parent.width - calendarIndicator.width
180 }
181 Rectangle{
182 id: calendarIndicator
183 width: units.gu(1)
184 radius: width/2
185 height: width
186 color: "#715772"
187 }
188 }
189 Label{
190 id: titleLabel183 id: titleLabel
191 objectName: "titleLabel"184 objectName: "titleLabel"
185 color: "White"
192 fontSize: "small"186 fontSize: "small"
193 color: "black"187 width: parent.width
194 wrapMode: Text.WrapAtWordBoundaryOrAnywhere188 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
195 width: parent.width
196 }189 }
197190
198 Label{191 Label {
199 id: descriptionLabel192 id: descriptionLabel
200 fontSize: "small"193 color: "White"
201 color:"gray"194 fontSize: "x-small"
202 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
203 width: parent.width195 width: parent.width
204 visible: type == wideType196 visible: type == wideType
197 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
205 }198 }
206 }199 }
207 }200 }

Subscribers

People subscribed via source and target branches

to status/vote changes: