Ubuntu Calendar App

Code review comment for lp:~nik90/ubuntu-calendar-app/tweak-event-color

  1. tweak-event-color
  2. Merge into trunk
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Hi,
> Thanks for MR and it looks great, couple of observation :-
>
> 1. this might look cumbersome when there are overlapping events in past
> because of opacity [1].
> 2. As kunal pointed out, wouldn't opacity will cause performance issues..? [2]
>
>
> [1]: http://i.imgur.com/nEIXY3y.png
> [2]: https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1369025

Good Point! I addressed them both by removing the opacity change and instead reducing the darkness of the background and striking out the event details of past events.

https://imgur.com/T0SBwVP

« Back to merge proposal