Code review comment for lp:~nik90/checkbox/clean-qml-code

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hi

I've merged your changes in locally. Due to the way we work I cannot just bzr merge it directly as I want to preserve the logical flow of patches in the target branch.

Thank you for your time and for improving checkbox :-)

I have only one question:

92 - WelcomePage {
93 - id: welcomePage
94 - visible: false
95 + Component.onCompleted: {
96 + push(Qt.resolvedUrl("components/WelcomePage.qml"))
97 }
98 - Component.onCompleted: push(welcomePage)

Why is that better? I realize it's going to push a new component each time, right? (and only once we actually click on the start testing button)

« Back to merge proposal