Merge lp:~nik90/checkbox/clean-qml-code into lp:~zyga/checkbox/touch-app
Proposed by
Nekhelesh Ramananthan
Status: | Merged |
---|---|
Merge reported by: | Zygmunt Krynicki |
Merged at revision: | not available |
Proposed branch: | lp:~nik90/checkbox/clean-qml-code |
Merge into: | lp:~zyga/checkbox/touch-app |
Diff against target: |
111 lines (+33/-32) 3 files modified
checkbox-touch/components/WelcomePage.qml (+28/-27) checkbox-touch/main.qml (+4/-4) checkbox-touch/manifest.json (+1/-1) |
To merge this branch: | bzr merge lp:~nik90/checkbox/clean-qml-code |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki | Pending | ||
Review via email: mp+230991@code.launchpad.net |
Commit message
Made some small improvements to the QML Code.
Description of the change
Made some small improvements to the QML Code.
To post a comment you must log in.
Hi
I've merged your changes in locally. Due to the way we work I cannot just bzr merge it directly as I want to preserve the logical flow of patches in the target branch.
Thank you for your time and for improving checkbox :-)
I have only one question:
92 - WelcomePage { onCompleted: { resolvedUrl( "components/ WelcomePage. qml")) onCompleted: push(welcomePage)
93 - id: welcomePage
94 - visible: false
95 + Component.
96 + push(Qt.
97 }
98 - Component.
Why is that better? I realize it's going to push a new component each time, right? (and only once we actually click on the start testing button)