Merge lp:~niemeyer/pyjuju/go-charm-bits into lp:pyjuju/go
Proposed by
Gustavo Niemeyer
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | William Reade | ||||||||
Approved revision: | 13 | ||||||||
Merged at revision: | 12 | ||||||||
Proposed branch: | lp:~niemeyer/pyjuju/go-charm-bits | ||||||||
Merge into: | lp:pyjuju/go | ||||||||
Diff against target: |
326 lines (+80/-132) 7 files modified
charm/Makefile (+0/-1) charm/bundle.go (+9/-0) charm/dir.go (+49/-49) charm/dir_test.go (+19/-2) charm/rel_test.go (+1/-2) charm/testrepo/dummy/hooks/install (+2/-0) charm/walk.go (+0/-78) |
||||||||
To merge this branch: | bzr merge lp:~niemeyer/pyjuju/go-charm-bits | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Roger Peppe (community) | Approve | ||
William Reade (community) | Approve | ||
Review via email: mp+76910@code.launchpad.net |
Description of the change
Improvements and fixes in charm directory packing
- Ignore hidden files as the Python version.
- Use the new filepath.Walk interface.
- Bundle dirs as well, so that empty dirs are included.
- Pack unix file mode into the charm bundle.
The last change requires this Go CL to be merged,
so the branch can't be merged before it goes in:
To post a comment you must log in.
The upstream CL went in already, so one will just need a tip branch to
test this for the moment.