Code review comment for lp:~niemeyer/pyjuju/go-charm-bits

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

[1]

That's done. Thanks.

[2]

As we talked online, that's not the case.

[3]

It's not well documented to be honest, but it's easy to go from
more restrictive to more liberal than otherwise. In general depending
on . files at runtime is a bad idea, though, so let's way for someone
to complain so that we can see a real use case.

[4]

It was, but this work was were filepath.Rel was born, so it wasn't
around by the time this branch was pushed. I'll remove the internal
copy now.

Thanks for the review.

« Back to merge proposal