Merge lp:~niemeyer/gnuflag/fix-package-names into lp:~gophers/gnuflag/trunk

Proposed by Gustavo Niemeyer
Status: Needs review
Proposed branch: lp:~niemeyer/gnuflag/fix-package-names
Merge into: lp:~gophers/gnuflag/trunk
Diff against target: 31 lines (+3/-2)
3 files modified
.lbox (+1/-0)
export_test.go (+1/-1)
flag_test.go (+1/-1)
To merge this branch: bzr merge lp:~niemeyer/gnuflag/fix-package-names
Reviewer Review Type Date Requested Status
The Go Language Gophers Pending
Review via email: mp+93522@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Reviewers: mp+93522_code.launchpad.net,

Message:
Please take a look.

Description:

https://code.launchpad.net/~niemeyer/gnuflag/fix-package-names/+merge/93522

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5671079/

Affected files:
   A .lbox
   M export_test.go
   M flag_test.go

Index: .lbox
=== <email address hidden> >
<email address hidden>
=== added file '.lbox'
--- .lbox 1970-01-01 00:00:00 +0000
+++ .lbox 2012-02-17 04:00:34 +0000
@@ -0,0 +1,1 @@
+propose -cr -for lp:gnuflag

Index: export_test.go
=== <email address hidden> >
<email address hidden>
=== modified file 'export_test.go'
--- export_test.go 2012-01-31 17:24:32 +0000
+++ export_test.go 2012-02-17 03:59:55 +0000
@@ -2,7 +2,7 @@
  // Use of this source code is governed by a BSD-style
  // license that can be found in the LICENSE file.

-package flag
+package gnuflag

  import (
   "os"

Index: flag_test.go
=== <email address hidden> >
<email address hidden>
=== modified file 'flag_test.go'
--- flag_test.go 2012-01-31 17:24:32 +0000
+++ flag_test.go 2012-02-17 03:59:55 +0000
@@ -2,7 +2,7 @@
  // Use of this source code is governed by a BSD-style
  // license that can be found in the LICENSE file.

-package flag_test
+package gnuflag_test

  import (
   "bytes"

Revision history for this message
Roger Peppe (rogpeppe) wrote :

i'm still waiting for a reply to https://codereview.appspot.com/5607048/
which changes the package identifier too.

On 17 February 2012 04:16, Gustavo Niemeyer <email address hidden> wrote:
> Reviewers: mp+93522_code.launchpad.net,
>
> Message:
> Please take a look.
>
> Description:
>
>
> https://code.launchpad.net/~niemeyer/gnuflag/fix-package-names/+merge/93522
>
> (do not edit description out of merge proposal)
>
>
> Please review this at https://codereview.appspot.com/5671079/
>
> Affected files:
>   A .lbox
>   M export_test.go
>   M flag_test.go
>
>
> Index: .lbox
> === <email address hidden> >
> <email address hidden>
> === added file '.lbox'
> --- .lbox       1970-01-01 00:00:00 +0000
> +++ .lbox       2012-02-17 04:00:34 +0000
> @@ -0,0 +1,1 @@
> +propose -cr -for lp:gnuflag
>
>
> Index: export_test.go
> === <email address hidden> >
> <email address hidden>
> === modified file 'export_test.go'
> --- export_test.go      2012-01-31 17:24:32 +0000
> +++ export_test.go      2012-02-17 03:59:55 +0000
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -package flag
> +package gnuflag
>
>  import (
>        "os"
>
>
> Index: flag_test.go
> === <email address hidden> >
> <email address hidden>
> === modified file 'flag_test.go'
> --- flag_test.go        2012-01-31 17:24:32 +0000
> +++ flag_test.go        2012-02-17 03:59:55 +0000
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -package flag_test
> +package gnuflag_test
>
>  import (
>        "bytes"
>
>
>
>
>
> --
> https://code.launchpad.net/~niemeyer/gnuflag/fix-package-names/+merge/93522
> Your team The Go Language Gophers is requested to review the proposed merge of lp:~niemeyer/gnuflag/fix-package-names into lp:gnuflag.

Unmerged revisions

12. By Gustavo Niemeyer

Add .lbox

11. By Gustavo Niemeyer

Fix package names.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file '.lbox'
--- .lbox 1970-01-01 00:00:00 +0000
+++ .lbox 2012-02-17 04:04:17 +0000
@@ -0,0 +1,1 @@
1propose -cr -for lp:gnuflag
02
=== modified file 'export_test.go'
--- export_test.go 2012-01-31 17:24:32 +0000
+++ export_test.go 2012-02-17 04:04:17 +0000
@@ -2,7 +2,7 @@
2// Use of this source code is governed by a BSD-style2// Use of this source code is governed by a BSD-style
3// license that can be found in the LICENSE file.3// license that can be found in the LICENSE file.
44
5package flag5package gnuflag
66
7import (7import (
8 "os"8 "os"
99
=== modified file 'flag_test.go'
--- flag_test.go 2012-01-31 17:24:32 +0000
+++ flag_test.go 2012-02-17 04:04:17 +0000
@@ -2,7 +2,7 @@
2// Use of this source code is governed by a BSD-style2// Use of this source code is governed by a BSD-style
3// license that can be found in the LICENSE file.3// license that can be found in the LICENSE file.
44
5package flag_test5package gnuflag_test
66
7import (7import (
8 "bytes"8 "bytes"

Subscribers

People subscribed via source and target branches