Code review comment for lp:~niemeyer/gnuflag/fix-package-names

Revision history for this message
Roger Peppe (rogpeppe) wrote :

i'm still waiting for a reply to https://codereview.appspot.com/5607048/
which changes the package identifier too.

On 17 February 2012 04:16, Gustavo Niemeyer <email address hidden> wrote:
> Reviewers: mp+93522_code.launchpad.net,
>
> Message:
> Please take a look.
>
> Description:
>
>
> https://code.launchpad.net/~niemeyer/gnuflag/fix-package-names/+merge/93522
>
> (do not edit description out of merge proposal)
>
>
> Please review this at https://codereview.appspot.com/5671079/
>
> Affected files:
>   A .lbox
>   M export_test.go
>   M flag_test.go
>
>
> Index: .lbox
> === <email address hidden> >
> <email address hidden>
> === added file '.lbox'
> --- .lbox       1970-01-01 00:00:00 +0000
> +++ .lbox       2012-02-17 04:00:34 +0000
> @@ -0,0 +1,1 @@
> +propose -cr -for lp:gnuflag
>
>
> Index: export_test.go
> === <email address hidden> >
> <email address hidden>
> === modified file 'export_test.go'
> --- export_test.go      2012-01-31 17:24:32 +0000
> +++ export_test.go      2012-02-17 03:59:55 +0000
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -package flag
> +package gnuflag
>
>  import (
>        "os"
>
>
> Index: flag_test.go
> === <email address hidden> >
> <email address hidden>
> === modified file 'flag_test.go'
> --- flag_test.go        2012-01-31 17:24:32 +0000
> +++ flag_test.go        2012-02-17 03:59:55 +0000
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -package flag_test
> +package gnuflag_test
>
>  import (
>        "bytes"
>
>
>
>
>
> --
> https://code.launchpad.net/~niemeyer/gnuflag/fix-package-names/+merge/93522
> Your team The Go Language Gophers is requested to review the proposed merge of lp:~niemeyer/gnuflag/fix-package-names into lp:gnuflag.

« Back to merge proposal