Code review comment for lp:~nick-dedekind/unity8/qmltest-renderer-bumping

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Great! It does make the tests run faster!

But I don't see the need to bring back all that code just to display something moving on the screen. Why don't we use what Ubuntu.Components already provides? Like this:

"""
=== modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
--- tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-01 21:26:55 +0000
+++ tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-03 16:33:42 +0000
@@ -23,11 +23,12 @@ TestCase {
     id: testCase
     TestUtil {id:util}

- WaitingDots {
+ ActivityIndicator {
         visible: testCase.running
         anchors.centerIn: parent
         Component.onCompleted: parent = testCase.parent
         z: 100
+ running: visible
     }

     // Fake implementation to be provided to items under test
"""

review: Needs Fixing

« Back to merge proposal