Merge lp:~nick-dedekind/unity8/qmltest-renderer-bumping into lp:unity8

[Nick Dedekind]

Force rendering so we don't get stuck in "waitForRendering" loop in tests.

Force rendering so we don't get stuck in "waitForRendering" loop in tests.
Wipes about 5 minutes off qmltest time.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 * Did you perform an exploratory manual test run of your code change and any related functionality?
 * Did you make sure that your branch does not contain spurious tags?
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 * If you changed the UI, has there been a design review?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1315
http://jenkins.qa.ubuntu.com/job/unity8-ci/4483/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5466
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1468
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1577
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1577
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5168
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6718
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6718/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14109

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4483/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

Great! It does make the tests run faster!

But I don't see the need to bring back all that code just to display something moving on the screen. Why don't we use what Ubuntu.Components already provides? Like this:

"""
=== modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
--- tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-01 21:26:55 +0000
+++ tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-03 16:33:42 +0000
@@ -23,11 +23,12 @@ TestCase {
     id: testCase
     TestUtil {id:util}

- WaitingDots {
+ ActivityIndicator {
         visible: testCase.running
         anchors.centerIn: parent
         Component.onCompleted: parent = testCase.parent
         z: 100
+ running: visible
     }

     // Fake implementation to be provided to items under test
"""

review: Needs Fixing

[lp:~nick-dedekind/unity8/qmltest-renderer-bumping]

1316. By Nick Dedekind on 2014-10-06

use existing controls

[Nick Dedekind (nick-dedekind)]

> Great! It does make the tests run faster!
>
> But I don't see the need to bring back all that code just to display something
> moving on the screen. Why don't we use what Ubuntu.Components already
> provides? Like this:
>
> """
> === modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
> --- tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-01 21:26:55
> +0000
> +++ tests/utils/modules/Unity/Test/UnityTestCase.qml 2014-10-03 16:33:42
> +0000
> @@ -23,11 +23,12 @@ TestCase {
> id: testCase
> TestUtil {id:util}
>
> - WaitingDots {
> + ActivityIndicator {
> visible: testCase.running
> anchors.centerIn: parent
> Component.onCompleted: parent = testCase.parent
> z: 100
> + running: visible
> }
>
> // Fake implementation to be provided to items under test
> """

Fixed

[Daniel d'Andrada (dandrader)]

Looking good.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1316
http://jenkins.qa.ubuntu.com/job/unity8-ci/4497/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5521
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1482
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1591
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1591
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5222
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6773
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6773/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14183

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4497/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1316
http://jenkins.qa.ubuntu.com/job/unity8-ci/4575/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5739
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1561
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1671
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1669
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5394
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6991
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6991/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14399

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4575/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
--- tests/utils/modules/Unity/Test/UnityTestCase.qml	2014-08-08 11:23:57 +0000
+++ tests/utils/modules/Unity/Test/UnityTestCase.qml	2014-10-06 10:31:51 +0000
@@ -20,8 +20,17 @@
 import Unity.Test 0.1 as UT
 
 TestCase {
+    id: testCase
     TestUtil {id:util}
 
+    ActivityIndicator {
+        visible: testCase.running
+        anchors.centerIn: parent
+        Component.onCompleted: parent = testCase.parent
+        z: 100
+        running: visible
+    }
+
     // Fake implementation to be provided to items under test
     property var fakeDateTime: new function() {
         this.currentTimeMs = 0