Unity

Code review comment for lp:~nick-dedekind/unity/lp1062107.preview-pre-caching

  1. lp1062107.preview-pre-caching
  2. Merge into trunk
Revision history for this message
Andrea Azzarone (azzar1) wrote :

tests/test_previews_precacher.cpp

I don't like the way you're testing PreviewPreCacher because you're testing a mock of it (MockPreviewPreCacher).

Also PreviewPreCacher should inherit from sigc::trackable.

Reply

« Back to merge proposal