Merge ~newell-jensen/maas:lp1683794-1524120 into maas:master
- Git
- lp:~newell-jensen/maas
- lp1683794-1524120
- Merge into master
Proposed by
Newell Jensen
Status: | Merged |
---|---|
Approved by: | Newell Jensen |
Approved revision: | 4ea3fd65855c16e42156fc51685a272ddd517583 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~newell-jensen/maas:lp1683794-1524120 |
Merge into: | maas:master |
Diff against target: |
804 lines (+82/-82) 18 files modified
src/maasserver/static/partials/boot-images.html (+3/-3) src/maasserver/static/partials/dashboard.html (+1/-1) src/maasserver/static/partials/domain-details.html (+3/-3) src/maasserver/static/partials/domains-list.html (+1/-1) src/maasserver/static/partials/fabric-details.html (+4/-4) src/maasserver/static/partials/ipranges.html (+3/-3) src/maasserver/static/partials/networks-list.html (+4/-4) src/maasserver/static/partials/node-details.html (+26/-26) src/maasserver/static/partials/nodes-list.html (+7/-7) src/maasserver/static/partials/pod-details.html (+2/-2) src/maasserver/static/partials/pods-list.html (+2/-2) src/maasserver/static/partials/settings.html (+6/-6) src/maasserver/static/partials/space-details.html (+4/-4) src/maasserver/static/partials/ssh-keys.html (+1/-1) src/maasserver/static/partials/subnet-details.html (+7/-7) src/maasserver/static/partials/vlan-details.html (+3/-3) src/maasserver/static/partials/zone-details.html (+4/-4) src/maasserver/static/partials/zones-list.html (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Donato (community) | Approve | ||
MAAS Lander | Needs Fixing | ||
Review via email: mp+334628@code.launchpad.net |
Description of the change
By adding type="button" to the button element in the html, it makes it so you cannot cancel by hitting the <enter> key. This good hint was taken from:
To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote : | # |
LGTM +1
minimal comments inline
review:
Approve
- 4ea3fd6... by Newell Jensen
-
Review fixes.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | diff --git a/src/maasserver/static/partials/boot-images.html b/src/maasserver/static/partials/boot-images.html | |||
2 | index 5506775..a88f5fe 100644 | |||
3 | --- a/src/maasserver/static/partials/boot-images.html | |||
4 | +++ b/src/maasserver/static/partials/boot-images.html | |||
5 | @@ -161,7 +161,7 @@ | |||
6 | 161 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this image?</p> | 161 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this image?</p> |
7 | 162 | </div> | 162 | </div> |
8 | 163 | <div class="table__data u-float--right"> | 163 | <div class="table__data u-float--right"> |
10 | 164 | <button class="button--base button--inline" data-ng-click="deleteImage()">Cancel</button> | 164 | <button class="button--base button--inline" type="button" data-ng-click="deleteImage()">Cancel</button> |
11 | 165 | <button class="button--destructive button--inline" data-ng-click="confirmDeleteImage()">Remove</button> | 165 | <button class="button--destructive button--inline" data-ng-click="confirmDeleteImage()">Remove</button> |
12 | 166 | </div> | 166 | </div> |
13 | 167 | </div> | 167 | </div> |
14 | @@ -324,7 +324,7 @@ | |||
15 | 324 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this image?</p> | 324 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this image?</p> |
16 | 325 | </div> | 325 | </div> |
17 | 326 | <div class="table__data u-float--right"> | 326 | <div class="table__data u-float--right"> |
19 | 327 | <a class="button--base button--inline" data-ng-click="cancelRemove()">Cancel</a> | 327 | <button class="button--base button--inline" type="button" data-ng-click="cancelRemove()">Cancel</a> |
20 | 328 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(image)">Remove</button> | 328 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(image)">Remove</button> |
21 | 329 | </div> | 329 | </div> |
22 | 330 | </div> | 330 | </div> |
23 | @@ -384,7 +384,7 @@ | |||
24 | 384 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this image?</p> | 384 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this image?</p> |
25 | 385 | </div> | 385 | </div> |
26 | 386 | <div class="table__data u-float--right"> | 386 | <div class="table__data u-float--right"> |
28 | 387 | <a class="button--base button--inline" data-ng-click="cancelRemove()">Cancel</a> | 387 | <button class="button--base button--inline" type="button" data-ng-click="cancelRemove()">Cancel</a> |
29 | 388 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(image)">Remove</button> | 388 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(image)">Remove</button> |
30 | 389 | </div> | 389 | </div> |
31 | 390 | </div> | 390 | </div> |
32 | diff --git a/src/maasserver/static/partials/dashboard.html b/src/maasserver/static/partials/dashboard.html | |||
33 | index a34ce18..4b1876a 100644 | |||
34 | --- a/src/maasserver/static/partials/dashboard.html | |||
35 | +++ b/src/maasserver/static/partials/dashboard.html | |||
36 | @@ -166,7 +166,7 @@ | |||
37 | 166 | <maas-obj-errors></maas-obj-errors> | 166 | <maas-obj-errors></maas-obj-errors> |
38 | 167 | </div> | 167 | </div> |
39 | 168 | <div class="table__data u-float--right"> | 168 | <div class="table__data u-float--right"> |
41 | 169 | <button class="button--base button--inline" data-ng-click="toggleSelected(selectedDevice)">Cancel</button> | 169 | <button class="button--base button--inline" type="button" data-ng-click="toggleSelected(selectedDevice)">Cancel</button> |
42 | 170 | <button class="button--secondary button--inline" | 170 | <button class="button--secondary button--inline" |
43 | 171 | data-ng-click="convertTo.goTo = true" | 171 | data-ng-click="convertTo.goTo = true" |
44 | 172 | data-ng-if="!convertTo.$maasForm.getValue('parent')" | 172 | data-ng-if="!convertTo.$maasForm.getValue('parent')" |
45 | diff --git a/src/maasserver/static/partials/domain-details.html b/src/maasserver/static/partials/domain-details.html | |||
46 | index 70c9938..3fde9eb 100644 | |||
47 | --- a/src/maasserver/static/partials/domain-details.html | |||
48 | +++ b/src/maasserver/static/partials/domain-details.html | |||
49 | @@ -19,7 +19,7 @@ | |||
50 | 19 | Domain cannot be deleted because it has resource records. Remove all resource records from the domain to allow deletion. | 19 | Domain cannot be deleted because it has resource records. Remove all resource records from the domain to allow deletion. |
51 | 20 | </p> | 20 | </p> |
52 | 21 | <div class="page-header__controls"> | 21 | <div class="page-header__controls"> |
54 | 22 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 22 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
55 | 23 | </div> | 23 | </div> |
56 | 24 | </div> | 24 | </div> |
57 | 25 | <div class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> | 25 | <div class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> |
58 | @@ -27,7 +27,7 @@ | |||
59 | 27 | Are you sure you want to delete this domain? | 27 | Are you sure you want to delete this domain? |
60 | 28 | </p> | 28 | </p> |
61 | 29 | <div class="page-header__controls"> | 29 | <div class="page-header__controls"> |
63 | 30 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 30 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
64 | 31 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete domain</button> | 31 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete domain</button> |
65 | 32 | </div> | 32 | </div> |
66 | 33 | </div> | 33 | </div> |
67 | @@ -36,7 +36,7 @@ | |||
68 | 36 | {$ error $} | 36 | {$ error $} |
69 | 37 | </p> | 37 | </p> |
70 | 38 | <div class="page-header__controls"> | 38 | <div class="page-header__controls"> |
72 | 39 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 39 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
73 | 40 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> | 40 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> |
74 | 41 | </div> | 41 | </div> |
75 | 42 | </div> | 42 | </div> |
76 | diff --git a/src/maasserver/static/partials/domains-list.html b/src/maasserver/static/partials/domains-list.html | |||
77 | index 4c6181a..7724157 100644 | |||
78 | --- a/src/maasserver/static/partials/domains-list.html | |||
79 | +++ b/src/maasserver/static/partials/domains-list.html | |||
80 | @@ -29,7 +29,7 @@ | |||
81 | 29 | </div> | 29 | </div> |
82 | 30 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> | 30 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> |
83 | 31 | <div class="page-header__controls"> | 31 | <div class="page-header__controls"> |
85 | 32 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 32 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
86 | 33 | <button class="button--secondary button--inline" | 33 | <button class="button--secondary button--inline" |
87 | 34 | data-ng-class="{ disabled: domainHasError() }" | 34 | data-ng-class="{ disabled: domainHasError() }" |
88 | 35 | data-ng-click="save(true)">Save and add another</button> | 35 | data-ng-click="save(true)">Save and add another</button> |
89 | diff --git a/src/maasserver/static/partials/fabric-details.html b/src/maasserver/static/partials/fabric-details.html | |||
90 | index b71229b..66bf6e5 100644 | |||
91 | --- a/src/maasserver/static/partials/fabric-details.html | |||
92 | +++ b/src/maasserver/static/partials/fabric-details.html | |||
93 | @@ -20,7 +20,7 @@ | |||
94 | 20 | Fabric cannot be deleted because it is the default fabric. | 20 | Fabric cannot be deleted because it is the default fabric. |
95 | 21 | </p> | 21 | </p> |
96 | 22 | <div class="page-header__controls"> | 22 | <div class="page-header__controls"> |
98 | 23 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 23 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
99 | 24 | </div> | 24 | </div> |
100 | 25 | </section> | 25 | </section> |
101 | 26 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> | 26 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> |
102 | @@ -28,14 +28,14 @@ | |||
103 | 28 | Are you sure you want to delete this fabric? | 28 | Are you sure you want to delete this fabric? |
104 | 29 | </p> | 29 | </p> |
105 | 30 | <div class="page-header__controls"> | 30 | <div class="page-header__controls"> |
107 | 31 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 31 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
108 | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete fabric</button> | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete fabric</button> |
109 | 33 | </div> | 33 | </div> |
110 | 34 | </section> | 34 | </section> |
111 | 35 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && error"> | 35 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && error"> |
112 | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> |
113 | 37 | <div class="page-header__controls"> | 37 | <div class="page-header__controls"> |
115 | 38 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 38 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
116 | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> |
117 | 40 | </div> | 40 | </div> |
118 | 41 | </section> | 41 | </section> |
119 | @@ -83,7 +83,7 @@ | |||
120 | 83 | </dl> | 83 | </dl> |
121 | 84 | </fieldset> | 84 | </fieldset> |
122 | 85 | <div class="twelve-col u-align--right"> | 85 | <div class="twelve-col u-align--right"> |
124 | 86 | <button class="button--base button--inline" | 86 | <button class="button--base button--inline" type="button" |
125 | 87 | data-ng-click="exitEditSummary()">Cancel</button> | 87 | data-ng-click="exitEditSummary()">Cancel</button> |
126 | 88 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> | 88 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> |
127 | 89 | </div> | 89 | </div> |
128 | diff --git a/src/maasserver/static/partials/ipranges.html b/src/maasserver/static/partials/ipranges.html | |||
129 | index 8f73e60..3cdd4d5 100755 | |||
130 | --- a/src/maasserver/static/partials/ipranges.html | |||
131 | +++ b/src/maasserver/static/partials/ipranges.html | |||
132 | @@ -34,7 +34,7 @@ | |||
133 | 34 | <p><span class="icon icon--warning u-margin--right-small"></span>Ensure all in-use IP addresses are registered in MAAS before releasing this range to avoid potential collisions. Are you sure you want to remove this IP range?</p> | 34 | <p><span class="icon icon--warning u-margin--right-small"></span>Ensure all in-use IP addresses are registered in MAAS before releasing this range to avoid potential collisions. Are you sure you want to remove this IP range?</p> |
134 | 35 | </div> | 35 | </div> |
135 | 36 | <div class="table__data u-float--right"> | 36 | <div class="table__data u-float--right"> |
137 | 37 | <button class="button--base button--inline" data-ng-click="ipRangeCancelDelete()">Cancel</button> | 37 | <button class="button--base button--inline" type="button" data-ng-click="ipRangeCancelDelete()">Cancel</button> |
138 | 38 | <button class="button--destructive button--inline" data-ng-click="ipRangeConfirmDelete()">Remove</button> | 38 | <button class="button--destructive button--inline" data-ng-click="ipRangeConfirmDelete()">Remove</button> |
139 | 39 | </div> | 39 | </div> |
140 | 40 | </div> | 40 | </div> |
141 | @@ -70,7 +70,7 @@ | |||
142 | 70 | <maas-obj-errors></maas-obj-errors> | 70 | <maas-obj-errors></maas-obj-errors> |
143 | 71 | </div> | 71 | </div> |
144 | 72 | <div class="table__data u-float--right"> | 72 | <div class="table__data u-float--right"> |
146 | 73 | <button class="button--base button--inline" data-ng-click="ipRangeToggleEditMode(iprange)">Cancel</button> | 73 | <button class="button--base button--inline" type="button" data-ng-click="ipRangeToggleEditMode(iprange)">Cancel</button> |
147 | 74 | <button class="button--positive button--inline" maas-obj-save>Save</button> | 74 | <button class="button--positive button--inline" maas-obj-save>Save</button> |
148 | 75 | </div> | 75 | </div> |
149 | 76 | </div> | 76 | </div> |
150 | @@ -112,7 +112,7 @@ | |||
151 | 112 | <maas-obj-errors></maas-obj-errors> | 112 | <maas-obj-errors></maas-obj-errors> |
152 | 113 | </div> | 113 | </div> |
153 | 114 | <div class="table__data u-float--right"> | 114 | <div class="table__data u-float--right"> |
155 | 115 | <button class="button--base button--inline" data-ng-click="cancelAddRange()">Cancel</button> | 115 | <button class="button--base button--inline" type="button" data-ng-click="cancelAddRange()">Cancel</button> |
156 | 116 | <button class="button--positive button--inline" maas-obj-save>Reserve</button> | 116 | <button class="button--positive button--inline" maas-obj-save>Reserve</button> |
157 | 117 | </div> | 117 | </div> |
158 | 118 | </div> | 118 | </div> |
159 | diff --git a/src/maasserver/static/partials/networks-list.html b/src/maasserver/static/partials/networks-list.html | |||
160 | index a68283f..49dfe80 100644 | |||
161 | --- a/src/maasserver/static/partials/networks-list.html | |||
162 | +++ b/src/maasserver/static/partials/networks-list.html | |||
163 | @@ -23,7 +23,7 @@ | |||
164 | 23 | <maas-obj-errors></maas-obj-errors> | 23 | <maas-obj-errors></maas-obj-errors> |
165 | 24 | </fieldset> | 24 | </fieldset> |
166 | 25 | <div class="page-header__controls"> | 25 | <div class="page-header__controls"> |
168 | 26 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 26 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
169 | 27 | <button class="button--positive button--inline" maas-obj-save>Add fabric</button> | 27 | <button class="button--positive button--inline" maas-obj-save>Add fabric</button> |
170 | 28 | </div> | 28 | </div> |
171 | 29 | </maas-obj-form> | 29 | </maas-obj-form> |
172 | @@ -49,7 +49,7 @@ | |||
173 | 49 | <maas-obj-errors></maas-obj-errors> | 49 | <maas-obj-errors></maas-obj-errors> |
174 | 50 | </fieldset> | 50 | </fieldset> |
175 | 51 | <div class="page-header__controls"> | 51 | <div class="page-header__controls"> |
177 | 52 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 52 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
178 | 53 | <button class="button--positive button--inline" maas-obj-save>Add VLAN</button> | 53 | <button class="button--positive button--inline" maas-obj-save>Add VLAN</button> |
179 | 54 | </div> | 54 | </div> |
180 | 55 | </maas-obj-form> | 55 | </maas-obj-form> |
181 | @@ -64,7 +64,7 @@ | |||
182 | 64 | <maas-obj-errors></maas-obj-errors> | 64 | <maas-obj-errors></maas-obj-errors> |
183 | 65 | </fieldset> | 65 | </fieldset> |
184 | 66 | <div class="page-header__controls"> | 66 | <div class="page-header__controls"> |
186 | 67 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 67 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
187 | 68 | <button class="button--positive button--inline" maas-obj-save>Add space</button> | 68 | <button class="button--positive button--inline" maas-obj-save>Add space</button> |
188 | 69 | </div> | 69 | </div> |
189 | 70 | </maas-obj-form> | 70 | </maas-obj-form> |
190 | @@ -101,7 +101,7 @@ | |||
191 | 101 | <section class="page-header__section twelve-col u-margin--bottom-none"> | 101 | <section class="page-header__section twelve-col u-margin--bottom-none"> |
192 | 102 | <maas-obj-errors class="page-header__message page-header__message--error"></maas-obj-errors> | 102 | <maas-obj-errors class="page-header__message page-header__message--error"></maas-obj-errors> |
193 | 103 | <div class="page-header__controls"> | 103 | <div class="page-header__controls"> |
195 | 104 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 104 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
196 | 105 | <button class="button--positive button--inline" maas-obj-save>Add subnet</button> | 105 | <button class="button--positive button--inline" maas-obj-save>Add subnet</button> |
197 | 106 | </div> | 106 | </div> |
198 | 107 | </section> | 107 | </section> |
199 | diff --git a/src/maasserver/static/partials/node-details.html b/src/maasserver/static/partials/node-details.html | |||
200 | index 3741be9..7bfc38a 100755 | |||
201 | --- a/src/maasserver/static/partials/node-details.html | |||
202 | +++ b/src/maasserver/static/partials/node-details.html | |||
203 | @@ -23,7 +23,7 @@ | |||
204 | 23 | data-ng-options="domain as domain.name for domain in header.domain.options"> | 23 | data-ng-options="domain as domain.name for domain in header.domain.options"> |
205 | 24 | </select> | 24 | </select> |
206 | 25 | </h1> | 25 | </h1> |
208 | 26 | <button class="button--base button--inline u-margin--bottom-small ng-hide" | 26 | <button class="button--base button--inline u-margin--bottom-small ng-hide" type="button" |
209 | 27 | data-ng-show="header.editing || header.editing_domain" | 27 | data-ng-show="header.editing || header.editing_domain" |
210 | 28 | data-ng-click="cancelEditHeader()">Cancel</button> | 28 | data-ng-click="cancelEditHeader()">Cancel</button> |
211 | 29 | <button class="button--positive button--inline u-margin--bottom-small ng-hide" | 29 | <button class="button--positive button--inline u-margin--bottom-small ng-hide" |
212 | @@ -86,7 +86,7 @@ | |||
213 | 86 | </div> | 86 | </div> |
214 | 87 | </fieldset> | 87 | </fieldset> |
215 | 88 | <div class="page-header__controls" data-ng-if="action.option.name !== 'commission' && action.option.name !== 'test'"> | 88 | <div class="page-header__controls" data-ng-if="action.option.name !== 'commission' && action.option.name !== 'test'"> |
217 | 89 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 89 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
218 | 90 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo('nodes')" data-ng-hide="hasActionsFailed('nodes')"> | 90 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo('nodes')" data-ng-hide="hasActionsFailed('nodes')"> |
219 | 91 | <span data-ng-if="action.option.name === 'acquire'">Acquire {$ type_name $}</span> | 91 | <span data-ng-if="action.option.name === 'acquire'">Acquire {$ type_name $}</span> |
220 | 92 | <span data-ng-if="action.option.name === 'deploy'">Deploy {$ type_name $}</span> | 92 | <span data-ng-if="action.option.name === 'deploy'">Deploy {$ type_name $}</span> |
221 | @@ -131,7 +131,7 @@ | |||
222 | 131 | <div class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError() || isDeployError() || isSSHKeyError() || hasActionPowerError(action.option.name)" data-ng-if="action.option.name === 'commission' || action.option.name === 'test'"> | 131 | <div class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError() || isDeployError() || isSSHKeyError() || hasActionPowerError(action.option.name)" data-ng-if="action.option.name === 'commission' || action.option.name === 'test'"> |
223 | 132 | <form class="form form--inline"> | 132 | <form class="form form--inline"> |
224 | 133 | <div class="page-header__controls"> | 133 | <div class="page-header__controls"> |
226 | 134 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 134 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
227 | 135 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo('nodes')" data-ng-hide="hasActionsFailed('nodes')"> | 135 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo('nodes')" data-ng-hide="hasActionsFailed('nodes')"> |
228 | 136 | <span data-ng-if="action.option.name === 'commission'">Commission {$ type_name $}</span> | 136 | <span data-ng-if="action.option.name === 'commission'">Commission {$ type_name $}</span> |
229 | 137 | <span data-ng-if="action.option.name === 'test'">Test {$ type_name $}</span> | 137 | <span data-ng-if="action.option.name === 'test'">Test {$ type_name $}</span> |
230 | @@ -146,7 +146,7 @@ | |||
231 | 146 | Node failed to be {$ action.option.sentence $}, because of the following error: {$ action.error $} | 146 | Node failed to be {$ action.option.sentence $}, because of the following error: {$ action.error $} |
232 | 147 | </p> | 147 | </p> |
233 | 148 | <div class="page-header__controls"> | 148 | <div class="page-header__controls"> |
235 | 149 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 149 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
236 | 150 | <button class="button--secondary button--inline" data-ng-click="actionGo()">Retry</button> | 150 | <button class="button--secondary button--inline" data-ng-click="actionGo()">Retry</button> |
237 | 151 | </div> | 151 | </div> |
238 | 152 | </div> | 152 | </div> |
239 | @@ -157,7 +157,7 @@ | |||
240 | 157 | Node cannot be {$ action.option.sentence $}, because the required boot images have not been imported. To import boot images, visit the <a href="images/">images page</a>. | 157 | Node cannot be {$ action.option.sentence $}, because the required boot images have not been imported. To import boot images, visit the <a href="images/">images page</a>. |
241 | 158 | </p> | 158 | </p> |
242 | 159 | <div class="page-header__controls"> | 159 | <div class="page-header__controls"> |
244 | 160 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 160 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
245 | 161 | </div> | 161 | </div> |
246 | 162 | </div> | 162 | </div> |
247 | 163 | 163 | ||
248 | @@ -168,7 +168,7 @@ | |||
249 | 168 | {$ getPowerErrors() $} on the rack controller. | 168 | {$ getPowerErrors() $} on the rack controller. |
250 | 169 | </p> | 169 | </p> |
251 | 170 | <div class="page-header__controls"> | 170 | <div class="page-header__controls"> |
253 | 171 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 171 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
254 | 172 | </div> | 172 | </div> |
255 | 173 | </div> | 173 | </div> |
256 | 174 | 174 | ||
257 | @@ -177,7 +177,7 @@ | |||
258 | 177 | Node cannot be {$ action.option.sentence $}, because an SSH key has not been added to your account. To add an SSH key, visit <a href="account/prefs/">your account page</a>. | 177 | Node cannot be {$ action.option.sentence $}, because an SSH key has not been added to your account. To add an SSH key, visit <a href="account/prefs/">your account page</a>. |
259 | 178 | </p> | 178 | </p> |
260 | 179 | <div class="page-header__controls"> | 179 | <div class="page-header__controls"> |
262 | 180 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 180 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
263 | 181 | </div> | 181 | </div> |
264 | 182 | </div> | 182 | </div> |
265 | 183 | </div> | 183 | </div> |
266 | @@ -443,7 +443,7 @@ | |||
267 | 443 | </div> | 443 | </div> |
268 | 444 | </fieldset> | 444 | </fieldset> |
269 | 445 | <div class="twelve-col u-align--right" data-ng-if="summary.editing"> | 445 | <div class="twelve-col u-align--right" data-ng-if="summary.editing"> |
271 | 446 | <button class="button--base button--inline" | 446 | <button class="button--base button--inline" type="button" |
272 | 447 | data-ng-click="cancelEditSummary()">Cancel</button> | 447 | data-ng-click="cancelEditSummary()">Cancel</button> |
273 | 448 | <button class="button--positive button--inline" | 448 | <button class="button--positive button--inline" |
274 | 449 | data-ng-class="{ secondary: invalidArchitecture() }" | 449 | data-ng-class="{ secondary: invalidArchitecture() }" |
275 | @@ -508,7 +508,7 @@ | |||
276 | 508 | data-ng-model="power"> | 508 | data-ng-model="power"> |
277 | 509 | </fieldset> | 509 | </fieldset> |
278 | 510 | <div class="twelve-col u-align--right ng-hide" data-ng-show="power.editing"> | 510 | <div class="twelve-col u-align--right ng-hide" data-ng-show="power.editing"> |
280 | 511 | <button class="button--base button--inline" | 511 | <button class="button--base button--inline" type="button" |
281 | 512 | data-ng-click="cancelEditPower()">Cancel</button> | 512 | data-ng-click="cancelEditPower()">Cancel</button> |
282 | 513 | <button class="button--positive button--inline" | 513 | <button class="button--positive button--inline" |
283 | 514 | data-ng-class="{ secondary: invalidPowerType() }" | 514 | data-ng-class="{ secondary: invalidPowerType() }" |
284 | @@ -970,7 +970,7 @@ | |||
285 | 970 | <maas-obj-errors></maas-obj-errors> | 970 | <maas-obj-errors></maas-obj-errors> |
286 | 971 | </div> | 971 | </div> |
287 | 972 | <div class="table__data u-float--right"> | 972 | <div class="table__data u-float--right"> |
289 | 973 | <button class="button--base button--inline" | 973 | <button class="button--base button--inline" type="button" |
290 | 974 | data-ng-click="editCancel()">Cancel</button> | 974 | data-ng-click="editCancel()">Cancel</button> |
291 | 975 | <button class="button--positive button--inline" | 975 | <button class="button--positive button--inline" |
292 | 976 | data-ng-disabled="(!isDevice && isInterfaceNameInvalid(editInterface)) || isIPAddressInvalid(editInterface) || isMACAddressInvalid(editInterface.mac_address, true)" | 976 | data-ng-disabled="(!isDevice && isInterfaceNameInvalid(editInterface)) || isIPAddressInvalid(editInterface) || isMACAddressInvalid(editInterface.mac_address, true)" |
293 | @@ -984,7 +984,7 @@ | |||
294 | 984 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(interface) $}?</p> | 984 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(interface) $}?</p> |
295 | 985 | </div> | 985 | </div> |
296 | 986 | <div class="table__data u-float--right"> | 986 | <div class="table__data u-float--right"> |
298 | 987 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 987 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
299 | 988 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(interface)">Remove</button> | 988 | <button class="button--destructive button--inline" data-ng-click="confirmRemove(interface)">Remove</button> |
300 | 989 | </div> | 989 | </div> |
301 | 990 | </div> | 990 | </div> |
302 | @@ -998,7 +998,7 @@ | |||
303 | 998 | data-ng-show="canAddAnotherVLAN(interface)">Add <span data-ng-show="newInterface.type === 'vlan'">another </span>VLAN</button> | 998 | data-ng-show="canAddAnotherVLAN(interface)">Add <span data-ng-show="newInterface.type === 'vlan'">another </span>VLAN</button> |
304 | 999 | </div> | 999 | </div> |
305 | 1000 | <div class="table__data u-float--right"> | 1000 | <div class="table__data u-float--right"> |
307 | 1001 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 1001 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
308 | 1002 | <button class="button--positive button--inline" data-ng-click="addInterface()">Add</button> | 1002 | <button class="button--positive button--inline" data-ng-click="addInterface()">Add</button> |
309 | 1003 | </div> | 1003 | </div> |
310 | 1004 | </div> | 1004 | </div> |
311 | @@ -1098,7 +1098,7 @@ | |||
312 | 1098 | </div> | 1098 | </div> |
313 | 1099 | <div class="table__row is-active"> | 1099 | <div class="table__row is-active"> |
314 | 1100 | <div class="table__data u-float--right"> | 1100 | <div class="table__data u-float--right"> |
316 | 1101 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 1101 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
317 | 1102 | <button class="button--positive button--inline" | 1102 | <button class="button--positive button--inline" |
318 | 1103 | data-ng-click="addBond()" | 1103 | data-ng-click="addBond()" |
319 | 1104 | data-ng-disabled="cannotAddBond()">Save</button> | 1104 | data-ng-disabled="cannotAddBond()">Save</button> |
320 | @@ -1182,7 +1182,7 @@ | |||
321 | 1182 | </div> | 1182 | </div> |
322 | 1183 | <div class="table__row is-active"> | 1183 | <div class="table__row is-active"> |
323 | 1184 | <div class="table__data u-float--right"> | 1184 | <div class="table__data u-float--right"> |
325 | 1185 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 1185 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
326 | 1186 | <button class="button--positive button--inline" | 1186 | <button class="button--positive button--inline" |
327 | 1187 | data-ng-click="addBridge()" | 1187 | data-ng-click="addBridge()" |
328 | 1188 | data-ng-disabled="cannotAddBridge()">Save</button> | 1188 | data-ng-disabled="cannotAddBridge()">Save</button> |
329 | @@ -1334,7 +1334,7 @@ | |||
330 | 1334 | <span class="icon icon--error u-margin--right-small"></span>{$ newInterface.errorMsg $} | 1334 | <span class="icon icon--error u-margin--right-small"></span>{$ newInterface.errorMsg $} |
331 | 1335 | </div> | 1335 | </div> |
332 | 1336 | <div class="table__data u-float--right"> | 1336 | <div class="table__data u-float--right"> |
334 | 1337 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 1337 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
335 | 1338 | <button class="button--positive button--inline" | 1338 | <button class="button--positive button--inline" |
336 | 1339 | data-ng-click="addPhysicalInterface()" | 1339 | data-ng-click="addPhysicalInterface()" |
337 | 1340 | data-ng-disabled="cannotAddPhysicalInterface()">Save</button> | 1340 | data-ng-disabled="cannotAddPhysicalInterface()">Save</button> |
338 | @@ -1438,7 +1438,7 @@ | |||
339 | 1438 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to unmount this filesystem?</p> | 1438 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to unmount this filesystem?</p> |
340 | 1439 | </div> | 1439 | </div> |
341 | 1440 | <div class="table__data u-float--right"> | 1440 | <div class="table__data u-float--right"> |
343 | 1441 | <button class="button--base button--inline" data-ng-click="filesystemCancel()">Cancel</button> | 1441 | <button class="button--base button--inline" type="button" data-ng-click="filesystemCancel()">Cancel</button> |
344 | 1442 | <button class="button--secondary button--inline" data-ng-click="filesystemConfirmUnmount(filesystem)">Unmount</button> | 1442 | <button class="button--secondary button--inline" data-ng-click="filesystemConfirmUnmount(filesystem)">Unmount</button> |
345 | 1443 | </div> | 1443 | </div> |
346 | 1444 | </div> | 1444 | </div> |
347 | @@ -1447,7 +1447,7 @@ | |||
348 | 1447 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(filesystem) $}?</p> | 1447 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(filesystem) $}?</p> |
349 | 1448 | </div> | 1448 | </div> |
350 | 1449 | <div class="table__data u-float--right"> | 1449 | <div class="table__data u-float--right"> |
352 | 1450 | <button class="button--base button--inline" data-ng-click="filesystemCancel(filesystem)">Cancel</button> | 1450 | <button class="button--base button--inline" type="button" data-ng-click="filesystemCancel(filesystem)">Cancel</button> |
353 | 1451 | <button class="button--destructive button--inline" data-ng-click="filesystemConfirmDelete(filesystem)">Remove</button> | 1451 | <button class="button--destructive button--inline" data-ng-click="filesystemConfirmDelete(filesystem)">Remove</button> |
354 | 1452 | </div> | 1452 | </div> |
355 | 1453 | </div> | 1453 | </div> |
356 | @@ -1497,7 +1497,7 @@ | |||
357 | 1497 | </div> | 1497 | </div> |
358 | 1498 | <div class="table__row is-active"> | 1498 | <div class="table__row is-active"> |
359 | 1499 | <div class="table__data u-float--right"> | 1499 | <div class="table__data u-float--right"> |
361 | 1500 | <button class="button--base button--inline" | 1500 | <button class="button--base button--inline" type="button" |
362 | 1501 | data-ng-click="cancel()">Cancel</button> | 1501 | data-ng-click="cancel()">Cancel</button> |
363 | 1502 | <button class="button--secondary button--inline ng-binding" | 1502 | <button class="button--secondary button--inline ng-binding" |
364 | 1503 | data-ng-disabled="!canMount()" | 1503 | data-ng-disabled="!canMount()" |
365 | @@ -1567,7 +1567,7 @@ | |||
366 | 1567 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to delete this cache set?</p> | 1567 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to delete this cache set?</p> |
367 | 1568 | </div> | 1568 | </div> |
368 | 1569 | <div class="table__data u-float--right"> | 1569 | <div class="table__data u-float--right"> |
370 | 1570 | <button class="button--base button--inline" data-ng-click="cacheSetCancel()">Cancel</button> | 1570 | <button class="button--base button--inline" type="button" data-ng-click="cacheSetCancel()">Cancel</button> |
371 | 1571 | <button class="button--destructive button--inline" data-ng-click="cacheSetConfirmDelete(cacheset)">Remove</button> | 1571 | <button class="button--destructive button--inline" data-ng-click="cacheSetConfirmDelete(cacheset)">Remove</button> |
372 | 1572 | </div> | 1572 | </div> |
373 | 1573 | </div> | 1573 | </div> |
374 | @@ -1943,7 +1943,7 @@ | |||
375 | 1943 | data-ng-class="{ 'is-active': availableMode !== null && activeMode !== 'multi' }"> | 1943 | data-ng-class="{ 'is-active': availableMode !== null && activeMode !== 'multi' }"> |
376 | 1944 | <div data-ng-if="availableMode === 'edit'"> | 1944 | <div data-ng-if="availableMode === 'edit'"> |
377 | 1945 | <div class="table__data u-float--right"> | 1945 | <div class="table__data u-float--right"> |
379 | 1946 | <button class="button--base button--inline" data-ng-click="availableCancel(item)">Cancel</button> | 1946 | <button class="button--base button--inline" type="button" data-ng-click="availableCancel(item)">Cancel</button> |
380 | 1947 | <button class="button--positive button--inline" | 1947 | <button class="button--positive button--inline" |
381 | 1948 | data-ng-disabled="isMountPointInvalid(item.$options.mountPoint) || isNameInvalid(item)" | 1948 | data-ng-disabled="isMountPointInvalid(item.$options.mountPoint) || isNameInvalid(item)" |
382 | 1949 | data-ng-click="availableConfirmEdit(item)">Save</button> | 1949 | data-ng-click="availableConfirmEdit(item)">Save</button> |
383 | @@ -1954,13 +1954,13 @@ | |||
384 | 1954 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(item) $}?</p> | 1954 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this {$ getRemoveTypeText(item) $}?</p> |
385 | 1955 | </div> | 1955 | </div> |
386 | 1956 | <div class="table__data u-float--right"> | 1956 | <div class="table__data u-float--right"> |
388 | 1957 | <button class="button--base button--inline" data-ng-click="availableCancel(item)">Cancel</button> | 1957 | <button class="button--base button--inline" type="button" data-ng-click="availableCancel(item)">Cancel</button> |
389 | 1958 | <button class="button--destructive button--inline" data-ng-click="availableConfirmDelete(item)">Remove</button> | 1958 | <button class="button--destructive button--inline" data-ng-click="availableConfirmDelete(item)">Remove</button> |
390 | 1959 | </div> | 1959 | </div> |
391 | 1960 | </div> | 1960 | </div> |
392 | 1961 | <div data-ng-if="availableMode === 'partition'"> | 1961 | <div data-ng-if="availableMode === 'partition'"> |
393 | 1962 | <div class="table__data u-float--right"> | 1962 | <div class="table__data u-float--right"> |
395 | 1963 | <button class="button--base button--inline" data-ng-click="availableCancel(item)">Cancel</button> | 1963 | <button class="button--base button--inline" type="button" data-ng-click="availableCancel(item)">Cancel</button> |
396 | 1964 | <button class="button--positive button--inline" | 1964 | <button class="button--positive button--inline" |
397 | 1965 | data-ng-disabled="isAddPartitionSizeInvalid(item) || isMountPointInvalid(item.$options.mountPoint)" | 1965 | data-ng-disabled="isAddPartitionSizeInvalid(item) || isMountPointInvalid(item.$options.mountPoint)" |
398 | 1966 | data-ng-click="availableConfirmPartition(item)">Add partition</button> | 1966 | data-ng-click="availableConfirmPartition(item)">Add partition</button> |
399 | @@ -1968,7 +1968,7 @@ | |||
400 | 1968 | </div> | 1968 | </div> |
401 | 1969 | <div data-ng-if="availableMode === 'logical-volume'"> | 1969 | <div data-ng-if="availableMode === 'logical-volume'"> |
402 | 1970 | <div class="table__data u-float--right"> | 1970 | <div class="table__data u-float--right"> |
404 | 1971 | <button class="button--base button--inline" data-ng-click="availableCancel(item)">Cancel</button> | 1971 | <button class="button--base button--inline" type="button" data-ng-click="availableCancel(item)">Cancel</button> |
405 | 1972 | <button class="button--positive button--inline" | 1972 | <button class="button--positive button--inline" |
406 | 1973 | data-ng-disabled="isLogicalVolumeNameInvalid(item) || isAddLogicalVolumeSizeInvalid(item) || isMountPointInvalid(item.$options.mountPoint)" | 1973 | data-ng-disabled="isLogicalVolumeNameInvalid(item) || isAddLogicalVolumeSizeInvalid(item) || isMountPointInvalid(item.$options.mountPoint)" |
407 | 1974 | data-ng-click="availableConfirmLogicalVolume(item)">Add logical volume</button> | 1974 | data-ng-click="availableConfirmLogicalVolume(item)">Add logical volume</button> |
408 | @@ -2080,7 +2080,7 @@ | |||
409 | 2080 | </div> | 2080 | </div> |
410 | 2081 | <div class="table__row is-active"> | 2081 | <div class="table__row is-active"> |
411 | 2082 | <div class="table__data u-float--right"> | 2082 | <div class="table__data u-float--right"> |
413 | 2083 | <button class="button--base button--inline" | 2083 | <button class="button--base button--inline" type="button" |
414 | 2084 | data-ng-click="availableCancel()">Cancel</button> | 2084 | data-ng-click="availableCancel()">Cancel</button> |
415 | 2085 | <button class="button--positive button--inline" | 2085 | <button class="button--positive button--inline" |
416 | 2086 | data-ng-disabled="!createBcacheCanSave()" | 2086 | data-ng-disabled="!createBcacheCanSave()" |
417 | @@ -2197,7 +2197,7 @@ | |||
418 | 2197 | </div> | 2197 | </div> |
419 | 2198 | <div class="table__row is-active"> | 2198 | <div class="table__row is-active"> |
420 | 2199 | <div class="table__data u-float--right"> | 2199 | <div class="table__data u-float--right"> |
422 | 2200 | <button class="button--base button--inline" | 2200 | <button class="button--base button--inline" type="button" |
423 | 2201 | data-ng-click="availableCancel()">Cancel</button> | 2201 | data-ng-click="availableCancel()">Cancel</button> |
424 | 2202 | <button class="button--positive button--inline" | 2202 | <button class="button--positive button--inline" |
425 | 2203 | data-ng-disabled="!createRAIDCanSave()" | 2203 | data-ng-disabled="!createRAIDCanSave()" |
426 | @@ -2259,7 +2259,7 @@ | |||
427 | 2259 | </div> | 2259 | </div> |
428 | 2260 | <div class="table__row is-active"> | 2260 | <div class="table__row is-active"> |
429 | 2261 | <div class="table__data u-float--right"> | 2261 | <div class="table__data u-float--right"> |
431 | 2262 | <button class="button--base button--inline" | 2262 | <button class="button--base button--inline" type="button" |
432 | 2263 | data-ng-click="availableCancel()">Cancel</button> | 2263 | data-ng-click="availableCancel()">Cancel</button> |
433 | 2264 | <button class="button--positive button--inline" | 2264 | <button class="button--positive button--inline" |
434 | 2265 | data-ng-disabled="!createVolumeGroupCanSave()" | 2265 | data-ng-disabled="!createVolumeGroupCanSave()" |
435 | diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html | |||
436 | index a817cf3..004d153 100644 | |||
437 | --- a/src/maasserver/static/partials/nodes-list.html | |||
438 | +++ b/src/maasserver/static/partials/nodes-list.html | |||
439 | @@ -121,7 +121,7 @@ | |||
440 | 121 | </fieldset> | 121 | </fieldset> |
441 | 122 | </form> | 122 | </form> |
442 | 123 | <div class="page-header__controls" data-ng-if="tabs[tab].actionOption.name !== 'commission' && tabs[tab].actionOption.name !== 'test'"> | 123 | <div class="page-header__controls" data-ng-if="tabs[tab].actionOption.name !== 'commission' && tabs[tab].actionOption.name !== 'test'"> |
444 | 124 | <button class="button--base button--inline" data-ng-click="actionCancel(tab)">Cancel</button> | 124 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel(tab)">Cancel</button> |
445 | 125 | <button class="button--inline" data-ng-class="tabs[tab].actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo(tab)" data-ng-hide="hasActionsFailed(tab)"> | 125 | <button class="button--inline" data-ng-class="tabs[tab].actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo(tab)" data-ng-hide="hasActionsFailed(tab)"> |
446 | 126 | <span data-ng-if="tabs[tab].actionOption.name === 'acquire'">Acquire {$ tabs[tab].selectedItems.length $} | 126 | <span data-ng-if="tabs[tab].actionOption.name === 'acquire'">Acquire {$ tabs[tab].selectedItems.length $} |
447 | 127 | <span data-ng-pluralize count="tabs[tab].selectedItems.length" when="{'one': 'machine', 'other': 'machines'}"></span> | 127 | <span data-ng-pluralize count="tabs[tab].selectedItems.length" when="{'one': 'machine', 'other': 'machines'}"></span> |
448 | @@ -194,7 +194,7 @@ | |||
449 | 194 | </section> | 194 | </section> |
450 | 195 | <section class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError(tab) || hasActionsInProgress(tab)" data-ng-if="tabs[tab].actionOption.name === 'commission' || tabs[tab].actionOption.name === 'test'"> | 195 | <section class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError(tab) || hasActionsInProgress(tab)" data-ng-if="tabs[tab].actionOption.name === 'commission' || tabs[tab].actionOption.name === 'test'"> |
451 | 196 | <div class="page-header__controls"> | 196 | <div class="page-header__controls"> |
453 | 197 | <button class="button--base button--inline" data-ng-click="actionCancel(tab)">Cancel</button> | 197 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel(tab)">Cancel</button> |
454 | 198 | <button class="button--inline" data-ng-class="tabs[tab].actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo(tab)" data-ng-hide="hasActionsFailed(tab)"> | 198 | <button class="button--inline" data-ng-class="tabs[tab].actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo(tab)" data-ng-hide="hasActionsFailed(tab)"> |
455 | 199 | <span data-ng-if="tabs[tab].actionOption.name === 'commission'">Commission {$ tabs[tab].selectedItems.length $} | 199 | <span data-ng-if="tabs[tab].actionOption.name === 'commission'">Commission {$ tabs[tab].selectedItems.length $} |
456 | 200 | <span data-ng-pluralize count="tabs[tab].selectedItems.length" when="{'one': 'machine', 'other': 'machines'}"></span> | 200 | <span data-ng-pluralize count="tabs[tab].selectedItems.length" when="{'one': 'machine', 'other': 'machines'}"></span> |
457 | @@ -347,7 +347,7 @@ | |||
458 | 347 | <section class="page-header__section twelve-col u-margin--bottom-none" data-ng-show="showMachine()"> | 347 | <section class="page-header__section twelve-col u-margin--bottom-none" data-ng-show="showMachine()"> |
459 | 348 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> | 348 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> |
460 | 349 | <div class="page-header__controls"> | 349 | <div class="page-header__controls"> |
462 | 350 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 350 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
463 | 351 | <button class="button--secondary button--inline" | 351 | <button class="button--secondary button--inline" |
464 | 352 | data-ng-disabled="machineHasError()" | 352 | data-ng-disabled="machineHasError()" |
465 | 353 | data-ng-click="saveMachine(true)">Save and add another</button> | 353 | data-ng-click="saveMachine(true)">Save and add another</button> |
466 | @@ -361,7 +361,7 @@ | |||
467 | 361 | <section class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="showChassis()"> | 361 | <section class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="showChassis()"> |
468 | 362 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> | 362 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> |
469 | 363 | <div class="page-header__controls"> | 363 | <div class="page-header__controls"> |
471 | 364 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 364 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
472 | 365 | <button class="button--secondary button--inline" | 365 | <button class="button--secondary button--inline" |
473 | 366 | data-ng-disabled="chassisHasErrors()" | 366 | data-ng-disabled="chassisHasErrors()" |
474 | 367 | data-ng-click="saveChassis(true)">Save and add another</button> | 367 | data-ng-click="saveChassis(true)">Save and add another</button> |
475 | @@ -521,7 +521,7 @@ | |||
476 | 521 | <form class="form form--inline"> | 521 | <form class="form form--inline"> |
477 | 522 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> | 522 | <p class="page-header__message page-header__message--error ng-hide" data-ng-show="error">{$ error $}</p> |
478 | 523 | <div class="page-header__controls"> | 523 | <div class="page-header__controls"> |
480 | 524 | <button class="button--base button--inline" data-ng-click="cancel()">Cancel</button> | 524 | <button class="button--base button--inline" type="button" data-ng-click="cancel()">Cancel</button> |
481 | 525 | <button class="button--secondary button--inline" | 525 | <button class="button--secondary button--inline" |
482 | 526 | data-ng-class="{ disabled: deviceHasError() }" | 526 | data-ng-class="{ disabled: deviceHasError() }" |
483 | 527 | data-ng-click="save(true)">Save and add another</button> | 527 | data-ng-click="save(true)">Save and add another</button> |
484 | @@ -560,7 +560,7 @@ | |||
485 | 560 | </fieldset> | 560 | </fieldset> |
486 | 561 | </form> | 561 | </form> |
487 | 562 | <div class="page-header__controls" data-ng-if="tabs.controllers.actionOption.name !== 'test'"> | 562 | <div class="page-header__controls" data-ng-if="tabs.controllers.actionOption.name !== 'test'"> |
489 | 563 | <button class="button--base button--inline" data-ng-click="actionCancel('controllers')">Cancel</button> | 563 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel('controllers')">Cancel</button> |
490 | 564 | <button class="button--positive button--inline" data-ng-click="actionGo('controllers')"> | 564 | <button class="button--positive button--inline" data-ng-click="actionGo('controllers')"> |
491 | 565 | <span data-ng-if="tabs.controllers.actionOption.name === 'set-zone'">Set zone for {$ tabs.controllers.selectedItems.length $} | 565 | <span data-ng-if="tabs.controllers.actionOption.name === 'set-zone'">Set zone for {$ tabs.controllers.selectedItems.length $} |
492 | 566 | <span data-ng-pluralize count="tabs.controllers.selectedItems.length" when="{'one': 'controller', 'other': 'controllers'}"></span> | 566 | <span data-ng-pluralize count="tabs.controllers.selectedItems.length" when="{'one': 'controller', 'other': 'controllers'}"></span> |
493 | @@ -592,7 +592,7 @@ | |||
494 | 592 | </div> | 592 | </div> |
495 | 593 | <div class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError('controllers') || hasActionsInProgress('controllers')" data-ng-if="tabs.controllers.actionOption.name === 'test'"> | 593 | <div class="page-header__section twelve-col u-margin--bottom-none" data-ng-hide="isActionError('controllers') || hasActionsInProgress('controllers')" data-ng-if="tabs.controllers.actionOption.name === 'test'"> |
496 | 594 | <div class="page-header__controls"> | 594 | <div class="page-header__controls"> |
498 | 595 | <button class="button--base button--inline" data-ng-click="actionCancel('controllers')">Cancel</button> | 595 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel('controllers')">Cancel</button> |
499 | 596 | <button class="button--positive button--inline" data-ng-click="actionGo('controllers')"> | 596 | <button class="button--positive button--inline" data-ng-click="actionGo('controllers')"> |
500 | 597 | <span>Test {$ tabs.controllers.selectedItems.length $} | 597 | <span>Test {$ tabs.controllers.selectedItems.length $} |
501 | 598 | <span data-ng-pluralize count="tabs.controllers.selectedItems.length" when="{'one': 'controller', 'other': 'controllers'}"></span> | 598 | <span data-ng-pluralize count="tabs.controllers.selectedItems.length" when="{'one': 'controller', 'other': 'controllers'}"></span> |
502 | diff --git a/src/maasserver/static/partials/pod-details.html b/src/maasserver/static/partials/pod-details.html | |||
503 | index 52c7695..9db98e8 100644 | |||
504 | --- a/src/maasserver/static/partials/pod-details.html | |||
505 | +++ b/src/maasserver/static/partials/pod-details.html | |||
506 | @@ -91,7 +91,7 @@ | |||
507 | 91 | <p class="page-header__message page-header__message--error" maas-obj-hide-saving><maas-obj-errors></maas-obj-errors></p> | 91 | <p class="page-header__message page-header__message--error" maas-obj-hide-saving><maas-obj-errors></maas-obj-errors></p> |
508 | 92 | <p class="page-header__message" maas-obj-show-saving><maas-obj-saving>Composing machine</maas-obj-saving></p> | 92 | <p class="page-header__message" maas-obj-show-saving><maas-obj-saving>Composing machine</maas-obj-saving></p> |
509 | 93 | <div class="page-header__controls" maas-obj-hide-saving> | 93 | <div class="page-header__controls" maas-obj-hide-saving> |
511 | 94 | <button class="button--base button--inline" data-ng-click="cancelCompose()">Cancel</button> | 94 | <button class="button--base button--inline" type="button" data-ng-click="cancelCompose()">Cancel</button> |
512 | 95 | <button class="button--positive button--inline" maas-obj-save>Compose machine</button> | 95 | <button class="button--positive button--inline" maas-obj-save>Compose machine</button> |
513 | 96 | </div> | 96 | </div> |
514 | 97 | </section> | 97 | </section> |
515 | @@ -110,7 +110,7 @@ | |||
516 | 110 | Performing {$ action.option.sentence $} failed: {$ action.error $} | 110 | Performing {$ action.option.sentence $} failed: {$ action.error $} |
517 | 111 | </p> | 111 | </p> |
518 | 112 | <div class="page-header__controls"> | 112 | <div class="page-header__controls"> |
520 | 113 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 113 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
521 | 114 | <button class="button--inline" data-ng-class="actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo()" data-ng-if="!action.error"> | 114 | <button class="button--inline" data-ng-class="actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo()" data-ng-if="!action.error"> |
522 | 115 | <span data-ng-if="action.option.name === 'refresh'">Refresh pod</span> | 115 | <span data-ng-if="action.option.name === 'refresh'">Refresh pod</span> |
523 | 116 | <span data-ng-if="action.option.name === 'delete'">Delete pod</span> | 116 | <span data-ng-if="action.option.name === 'delete'">Delete pod</span> |
524 | diff --git a/src/maasserver/static/partials/pods-list.html b/src/maasserver/static/partials/pods-list.html | |||
525 | index cd0fb69..2a0fac3 100644 | |||
526 | --- a/src/maasserver/static/partials/pods-list.html | |||
527 | +++ b/src/maasserver/static/partials/pods-list.html | |||
528 | @@ -27,7 +27,7 @@ | |||
529 | 27 | see listing for specific error for each pod. | 27 | see listing for specific error for each pod. |
530 | 28 | </p> | 28 | </p> |
531 | 29 | <div class="page-header__controls"> | 29 | <div class="page-header__controls"> |
533 | 30 | <button class="button--base button--inline" data-ng-click="actionCancel()">Cancel</button> | 30 | <button class="button--base button--inline" type="button" data-ng-click="actionCancel()">Cancel</button> |
534 | 31 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo()" data-ng-if="!hasActionsFailed()"> | 31 | <button class="button--inline" data-ng-class="action.option.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="actionGo()" data-ng-if="!hasActionsFailed()"> |
535 | 32 | <span data-ng-if="action.option.name === 'refresh'">Refresh {$ selectedItems.length $} | 32 | <span data-ng-if="action.option.name === 'refresh'">Refresh {$ selectedItems.length $} |
536 | 33 | <span data-ng-pluralize count="selectedItems.length" when="{'one': 'pod', 'other': 'pods'}"></span> | 33 | <span data-ng-pluralize count="selectedItems.length" when="{'one': 'pod', 'other': 'pods'}"></span> |
537 | @@ -63,7 +63,7 @@ | |||
538 | 63 | <p class="page-header__message page-header__message--error" maas-obj-hide-saving><maas-obj-errors></maas-obj-errors></p> | 63 | <p class="page-header__message page-header__message--error" maas-obj-hide-saving><maas-obj-errors></maas-obj-errors></p> |
539 | 64 | <p class="page-header__message" maas-obj-show-saving><maas-obj-saving>Trying to connect and discover pod</maas-obj-saving></p> | 64 | <p class="page-header__message" maas-obj-show-saving><maas-obj-saving>Trying to connect and discover pod</maas-obj-saving></p> |
540 | 65 | <div class="page-header__controls" maas-obj-hide-saving> | 65 | <div class="page-header__controls" maas-obj-hide-saving> |
542 | 66 | <button class="button--base button--inline" data-ng-click="cancelAddPod()">Cancel</button> | 66 | <button class="button--base button--inline" type="button" data-ng-click="cancelAddPod()">Cancel</button> |
543 | 67 | <button class="button--positive button--inline" maas-obj-save>Save pod</button> | 67 | <button class="button--positive button--inline" maas-obj-save>Save pod</button> |
544 | 68 | </div> | 68 | </div> |
545 | 69 | </section> | 69 | </section> |
546 | diff --git a/src/maasserver/static/partials/settings.html b/src/maasserver/static/partials/settings.html | |||
547 | index b6bff07..3ebfab4 100644 | |||
548 | --- a/src/maasserver/static/partials/settings.html | |||
549 | +++ b/src/maasserver/static/partials/settings.html | |||
550 | @@ -142,7 +142,7 @@ | |||
551 | 142 | <maas-obj-errors></maas-obj-errors> | 142 | <maas-obj-errors></maas-obj-errors> |
552 | 143 | </div> | 143 | </div> |
553 | 144 | <div class="table__data u-float--right"> | 144 | <div class="table__data u-float--right"> |
555 | 145 | <button class="button--base button--inline" | 145 | <button class="button--base button--inline" type="button" |
556 | 146 | data-ng-click="snippetExitEdit(snippet)">Cancel</button> | 146 | data-ng-click="snippetExitEdit(snippet)">Cancel</button> |
557 | 147 | <button class="button--positive button--inline" maas-obj-save>Save snippet</button> | 147 | <button class="button--positive button--inline" maas-obj-save>Save snippet</button> |
558 | 148 | </div> | 148 | </div> |
559 | @@ -159,7 +159,7 @@ | |||
560 | 159 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this snippet?</p> | 159 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this snippet?</p> |
561 | 160 | </div> | 160 | </div> |
562 | 161 | <div class="table__data u-float--right"> | 161 | <div class="table__data u-float--right"> |
564 | 162 | <button class="button--base button--inline" data-ng-click="snippetExitRemove(snippet)">Cancel</button> | 162 | <button class="button--base button--inline" type="button" data-ng-click="snippetExitRemove(snippet)">Cancel</button> |
565 | 163 | <button class="button--destructive button--inline" data-ng-click="snippetConfirmRemove(snippet)">Remove</button> | 163 | <button class="button--destructive button--inline" data-ng-click="snippetConfirmRemove(snippet)">Remove</button> |
566 | 164 | </div> | 164 | </div> |
567 | 165 | </div> | 165 | </div> |
568 | @@ -258,7 +258,7 @@ | |||
569 | 258 | <maas-obj-errors></maas-obj-errors> | 258 | <maas-obj-errors></maas-obj-errors> |
570 | 259 | </div> | 259 | </div> |
571 | 260 | <div class="table__data u-float--right"> | 260 | <div class="table__data u-float--right"> |
573 | 261 | <button class="button--base button--inline" | 261 | <button class="button--base button--inline" type="button" |
574 | 262 | data-ng-click="snippetAddCancel()">Cancel</button> | 262 | data-ng-click="snippetAddCancel()">Cancel</button> |
575 | 263 | <button class="button--positive button--inline" maas-obj-save>Save snippet</button> | 263 | <button class="button--positive button--inline" maas-obj-save>Save snippet</button> |
576 | 264 | </div> | 264 | </div> |
577 | @@ -491,7 +491,7 @@ | |||
578 | 491 | <maas-obj-errors></maas-obj-errors> | 491 | <maas-obj-errors></maas-obj-errors> |
579 | 492 | </div> | 492 | </div> |
580 | 493 | <div class="table__data u-float--right"> | 493 | <div class="table__data u-float--right"> |
582 | 494 | <button class="button--base button--inline" | 494 | <button class="button--base button--inline" type="button" |
583 | 495 | data-ng-click="repositoryExitEdit()">Cancel</button> | 495 | data-ng-click="repositoryExitEdit()">Cancel</button> |
584 | 496 | <button class="button--positive button--inline" maas-obj-save>Save repository</button> | 496 | <button class="button--positive button--inline" maas-obj-save>Save repository</button> |
585 | 497 | </div> | 497 | </div> |
586 | @@ -509,7 +509,7 @@ | |||
587 | 509 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this repository?</p> | 509 | <p><span class="icon icon--warning u-margin--right-small"></span> Are you sure you want to remove this repository?</p> |
588 | 510 | </div> | 510 | </div> |
589 | 511 | <div class="table__data u-float--right"> | 511 | <div class="table__data u-float--right"> |
591 | 512 | <button class="button--base button--inline" data-ng-click="repositoryExitRemove()">Cancel</button> | 512 | <button class="button--base button--inline" type="button" data-ng-click="repositoryExitRemove()">Cancel</button> |
592 | 513 | <button class="button--destructive button--inline" data-ng-click="repositoryConfirmRemove()">Remove</button> | 513 | <button class="button--destructive button--inline" data-ng-click="repositoryConfirmRemove()">Remove</button> |
593 | 514 | </div> | 514 | </div> |
594 | 515 | </div> | 515 | </div> |
595 | @@ -571,7 +571,7 @@ | |||
596 | 571 | <maas-obj-errors></maas-obj-errors> | 571 | <maas-obj-errors></maas-obj-errors> |
597 | 572 | </div> | 572 | </div> |
598 | 573 | <div class="table__data u-float--right"> | 573 | <div class="table__data u-float--right"> |
600 | 574 | <button class="button--base button--inline" | 574 | <button class="button--base button--inline" type="button" |
601 | 575 | data-ng-click="repositoryAddCancel()">Cancel</button> | 575 | data-ng-click="repositoryAddCancel()">Cancel</button> |
602 | 576 | <button class="button--positive button--inline" maas-obj-save>Add repository</button> | 576 | <button class="button--positive button--inline" maas-obj-save>Add repository</button> |
603 | 577 | </div> | 577 | </div> |
604 | diff --git a/src/maasserver/static/partials/space-details.html b/src/maasserver/static/partials/space-details.html | |||
605 | index 856dd01..a98aa4b 100644 | |||
606 | --- a/src/maasserver/static/partials/space-details.html | |||
607 | +++ b/src/maasserver/static/partials/space-details.html | |||
608 | @@ -20,7 +20,7 @@ | |||
609 | 20 | Space cannot be deleted because it has subnets attached. Remove all subnets from the space to allow deletion. | 20 | Space cannot be deleted because it has subnets attached. Remove all subnets from the space to allow deletion. |
610 | 21 | </p> | 21 | </p> |
611 | 22 | <div class="page-header__controls"> | 22 | <div class="page-header__controls"> |
613 | 23 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 23 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
614 | 24 | </div> | 24 | </div> |
615 | 25 | </div> | 25 | </div> |
616 | 26 | <div class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="canBeDeleted() && !error"> | 26 | <div class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="canBeDeleted() && !error"> |
617 | @@ -28,14 +28,14 @@ | |||
618 | 28 | Are you sure you want to delete this space? | 28 | Are you sure you want to delete this space? |
619 | 29 | </p> | 29 | </p> |
620 | 30 | <div class="page-header__controls"> | 30 | <div class="page-header__controls"> |
622 | 31 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 31 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
623 | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete space</button> | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete space</button> |
624 | 33 | </div> | 33 | </div> |
625 | 34 | </div> | 34 | </div> |
626 | 35 | <div class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="canBeDeleted() && error"> | 35 | <div class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="canBeDeleted() && error"> |
627 | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> |
628 | 37 | <div class="page-header__controls"> | 37 | <div class="page-header__controls"> |
630 | 38 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 38 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
631 | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> |
632 | 40 | </div> | 40 | </div> |
633 | 41 | </div> | 41 | </div> |
634 | @@ -64,7 +64,7 @@ | |||
635 | 64 | label-width="two" input-width="three" blur-on-enter="true"></maas-obj-field> | 64 | label-width="two" input-width="three" blur-on-enter="true"></maas-obj-field> |
636 | 65 | </fieldset> | 65 | </fieldset> |
637 | 66 | <div class="twelve-col u-align--right"> | 66 | <div class="twelve-col u-align--right"> |
639 | 67 | <button class="button--base button--inline" | 67 | <button class="button--base button--inline" type="button" |
640 | 68 | data-ng-click="exitEditSummary()">Cancel</button> | 68 | data-ng-click="exitEditSummary()">Cancel</button> |
641 | 69 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> | 69 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> |
642 | 70 | </div> | 70 | </div> |
643 | diff --git a/src/maasserver/static/partials/ssh-keys.html b/src/maasserver/static/partials/ssh-keys.html | |||
644 | index 771a1cd..e5e12a1 100644 | |||
645 | --- a/src/maasserver/static/partials/ssh-keys.html | |||
646 | +++ b/src/maasserver/static/partials/ssh-keys.html | |||
647 | @@ -45,7 +45,7 @@ | |||
648 | 45 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this key?</p> | 45 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this key?</p> |
649 | 46 | </div> | 46 | </div> |
650 | 47 | <div class="table__data u-float--right"> | 47 | <div class="table__data u-float--right"> |
652 | 48 | <button class="button--base button--inline" data-ng-click="close()">Cancel</button> | 48 | <button class="button--base button--inline" type="button" data-ng-click="close()">Cancel</button> |
653 | 49 | <button class="button--destructive button--inline" data-ng-click="confirmDelete(group)">Remove</button> | 49 | <button class="button--destructive button--inline" data-ng-click="confirmDelete(group)">Remove</button> |
654 | 50 | </div> | 50 | </div> |
655 | 51 | </div> | 51 | </div> |
656 | diff --git a/src/maasserver/static/partials/subnet-details.html b/src/maasserver/static/partials/subnet-details.html | |||
657 | index 75eaae0..772b9be 100755 | |||
658 | --- a/src/maasserver/static/partials/subnet-details.html | |||
659 | +++ b/src/maasserver/static/partials/subnet-details.html | |||
660 | @@ -23,7 +23,7 @@ | |||
661 | 23 | You will start mapping your subnet. Go to the <a href="#/dashboard">dashboard</a> to see the discovered items. | 23 | You will start mapping your subnet. Go to the <a href="#/dashboard">dashboard</a> to see the discovered items. |
662 | 24 | </p> | 24 | </p> |
663 | 25 | <div class="page-header__controls"> | 25 | <div class="page-header__controls"> |
665 | 26 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 26 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
666 | 27 | <button class="button--positive button--inline" data-ng-click="actionGo()">Map subnet</button> | 27 | <button class="button--positive button--inline" data-ng-click="actionGo()">Map subnet</button> |
667 | 28 | </div> | 28 | </div> |
668 | 29 | </section> | 29 | </section> |
669 | @@ -32,14 +32,14 @@ | |||
670 | 32 | Are you sure you want to delete this subnet and release all IP addresses assigned within its range? | 32 | Are you sure you want to delete this subnet and release all IP addresses assigned within its range? |
671 | 33 | </p> | 33 | </p> |
672 | 34 | <div class="page-header__controls"> | 34 | <div class="page-header__controls"> |
674 | 35 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 35 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
675 | 36 | <button class="button--destructive button--inline" data-ng-click="actionGo()">Delete subnet</button> | 36 | <button class="button--destructive button--inline" data-ng-click="actionGo()">Delete subnet</button> |
676 | 37 | </div> | 37 | </div> |
677 | 38 | </section> | 38 | </section> |
678 | 39 | <section class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="actionError"> | 39 | <section class="page-header__section twelve-col u-margin--bottom-none ng-hide" data-ng-show="actionError"> |
679 | 40 | <p class="page-header__message page-header__message--error">{$ actionError $}</p> | 40 | <p class="page-header__message page-header__message--error">{$ actionError $}</p> |
680 | 41 | <div class="page-header__controls"> | 41 | <div class="page-header__controls"> |
682 | 42 | <button class="button--base button--inline" data-ng-click="cancelAction()">Cancel</button> | 42 | <button class="button--base button--inline" type="button" data-ng-click="cancelAction()">Cancel</button> |
683 | 43 | <button class="button--secondary button--inline" data-ng-click="actionRetry()">Retry</button> | 43 | <button class="button--secondary button--inline" data-ng-click="actionRetry()">Retry</button> |
684 | 44 | </div> | 44 | </div> |
685 | 45 | </section> | 45 | </section> |
686 | @@ -161,7 +161,7 @@ | |||
687 | 161 | <maas-obj-errors></maas-obj-errors> | 161 | <maas-obj-errors></maas-obj-errors> |
688 | 162 | </div> | 162 | </div> |
689 | 163 | <div class="six-col last-col u-align--right"> | 163 | <div class="six-col last-col u-align--right"> |
691 | 164 | <button class="button--base button--inline" | 164 | <button class="button--base button--inline" type="button" |
692 | 165 | data-ng-click="exitEditSummary()">Cancel</button> | 165 | data-ng-click="exitEditSummary()">Cancel</button> |
693 | 166 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> | 166 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> |
694 | 167 | </div> | 167 | </div> |
695 | @@ -218,7 +218,7 @@ | |||
696 | 218 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this static route?</p> | 218 | <p><span class="icon icon--warning u-margin--right-small"></span>Are you sure you want to remove this static route?</p> |
697 | 219 | </div> | 219 | </div> |
698 | 220 | <div class="table__data u-float--right"> | 220 | <div class="table__data u-float--right"> |
700 | 221 | <button class="button--base button--inline" data-ng-click="staticRouteCancelDelete()">Cancel</button> | 221 | <button class="button--base button--inline" type="button" data-ng-click="staticRouteCancelDelete()">Cancel</button> |
701 | 222 | <button class="button--destructive button--inline" data-ng-click="staticRouteConfirmDelete()">Remove</button> | 222 | <button class="button--destructive button--inline" data-ng-click="staticRouteConfirmDelete()">Remove</button> |
702 | 223 | </div> | 223 | </div> |
703 | 224 | </div> | 224 | </div> |
704 | @@ -250,7 +250,7 @@ | |||
705 | 250 | <maas-obj-errors></maas-obj-errors> | 250 | <maas-obj-errors></maas-obj-errors> |
706 | 251 | </div> | 251 | </div> |
707 | 252 | <div class="table__data u-float--right"> | 252 | <div class="table__data u-float--right"> |
709 | 253 | <button class="button--base button--inline" data-ng-click="staticRouteToggleEditMode(staticRoute)">Cancel</button> | 253 | <button class="button--base button--inline" type="button" data-ng-click="staticRouteToggleEditMode(staticRoute)">Cancel</button> |
710 | 254 | <button class="button--positive button--inline" maas-obj-save>Save static route</button> | 254 | <button class="button--positive button--inline" maas-obj-save>Save static route</button> |
711 | 255 | </div> | 255 | </div> |
712 | 256 | </div> | 256 | </div> |
713 | @@ -297,7 +297,7 @@ | |||
714 | 297 | <maas-obj-errors></maas-obj-errors> | 297 | <maas-obj-errors></maas-obj-errors> |
715 | 298 | </div> | 298 | </div> |
716 | 299 | <div class="table__data u-float--right"> | 299 | <div class="table__data u-float--right"> |
718 | 300 | <button class="button--base button--inline" data-ng-click="cancelAddStaticRoute()">Cancel</button> | 300 | <button class="button--base button--inline" type="button" data-ng-click="cancelAddStaticRoute()">Cancel</button> |
719 | 301 | <button class="button--positive button--inline" maas-obj-save>Save static route</button> | 301 | <button class="button--positive button--inline" maas-obj-save>Save static route</button> |
720 | 302 | </div> | 302 | </div> |
721 | 303 | </div> | 303 | </div> |
722 | diff --git a/src/maasserver/static/partials/vlan-details.html b/src/maasserver/static/partials/vlan-details.html | |||
723 | index a526ed9..1c70452 100644 | |||
724 | --- a/src/maasserver/static/partials/vlan-details.html | |||
725 | +++ b/src/maasserver/static/partials/vlan-details.html | |||
726 | @@ -203,7 +203,7 @@ | |||
727 | 203 | Are you sure you want to delete this VLAN? | 203 | Are you sure you want to delete this VLAN? |
728 | 204 | </p> | 204 | </p> |
729 | 205 | <div class="page-header__controls"> | 205 | <div class="page-header__controls"> |
731 | 206 | <button class="button--base button--inline" data-ng-click="vlanDetails.actionCancel()">Cancel</button> | 206 | <button class="button--base button--inline" type="button" data-ng-click="vlanDetails.actionCancel()">Cancel</button> |
732 | 207 | <button class="button--inline" data-ng-class="vlanDetails.actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="vlanDetails.actionGo()" data-ng-disabled="!vlanDetails.canPerformAction()">{$ vlanDetails.actionOption.title $}</button> | 207 | <button class="button--inline" data-ng-class="vlanDetails.actionOption.name === 'delete' ? 'button--destructive' : 'button--positive'" data-ng-click="vlanDetails.actionGo()" data-ng-disabled="!vlanDetails.canPerformAction()">{$ vlanDetails.actionOption.title $}</button> |
733 | 208 | </div> | 208 | </div> |
734 | 209 | </section> | 209 | </section> |
735 | @@ -211,7 +211,7 @@ | |||
736 | 211 | data-ng-if="vlanDetails.isActionError()"> | 211 | data-ng-if="vlanDetails.isActionError()"> |
737 | 212 | <p class="page-header__message page-header__message--error">{$ vlanDetails.actionError $}</p> | 212 | <p class="page-header__message page-header__message--error">{$ vlanDetails.actionError $}</p> |
738 | 213 | <div class="page-header__controls"> | 213 | <div class="page-header__controls"> |
740 | 214 | <button class="button--base button--inline u-margin--right" data-ng-click="vlanDetails.actionCancel()">Cancel</button> | 214 | <button class="button--base button--inline u-margin--right" type="button" data-ng-click="vlanDetails.actionCancel()">Cancel</button> |
741 | 215 | <button class="button--secondary button--inline" data-ng-click="vlanDetails.actionRetry()">Retry</button> | 215 | <button class="button--secondary button--inline" data-ng-click="vlanDetails.actionRetry()">Retry</button> |
742 | 216 | </div> | 216 | </div> |
743 | 217 | </section> | 217 | </section> |
744 | @@ -285,7 +285,7 @@ | |||
745 | 285 | </dl> | 285 | </dl> |
746 | 286 | </div> | 286 | </div> |
747 | 287 | <div class="twelve-col u-align--right"> | 287 | <div class="twelve-col u-align--right"> |
749 | 288 | <button class="button--base button--inline" | 288 | <button class="button--base button--inline" type="button" |
750 | 289 | data-ng-click="vlanDetails.exitEditSummary()">Cancel</button> | 289 | data-ng-click="vlanDetails.exitEditSummary()">Cancel</button> |
751 | 290 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> | 290 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> |
752 | 291 | </div> | 291 | </div> |
753 | diff --git a/src/maasserver/static/partials/zone-details.html b/src/maasserver/static/partials/zone-details.html | |||
754 | index dec2f3b..c4e97d0 100644 | |||
755 | --- a/src/maasserver/static/partials/zone-details.html | |||
756 | +++ b/src/maasserver/static/partials/zone-details.html | |||
757 | @@ -20,7 +20,7 @@ | |||
758 | 20 | Zone cannot be deleted because it is the default zone. | 20 | Zone cannot be deleted because it is the default zone. |
759 | 21 | </p> | 21 | </p> |
760 | 22 | <div class="page-header__controls"> | 22 | <div class="page-header__controls"> |
762 | 23 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 23 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
763 | 24 | </div> | 24 | </div> |
764 | 25 | </section> | 25 | </section> |
765 | 26 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> | 26 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && !error"> |
766 | @@ -28,14 +28,14 @@ | |||
767 | 28 | Are you sure you want to delete this zone? | 28 | Are you sure you want to delete this zone? |
768 | 29 | </p> | 29 | </p> |
769 | 30 | <div class="page-header__controls"> | 30 | <div class="page-header__controls"> |
771 | 31 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 31 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
772 | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete zone</button> | 32 | <button class="button--destructive button--inline" data-ng-click="deleteConfirmButton()">Delete zone</button> |
773 | 33 | </div> | 33 | </div> |
774 | 34 | </section> | 34 | </section> |
775 | 35 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && error"> | 35 | <section class="page-header__section ng-hide" data-ng-show="canBeDeleted() && error"> |
776 | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> | 36 | <p class="page-header__message page-header__message--error">{$ error $}</p> |
777 | 37 | <div class="page-header__controls"> | 37 | <div class="page-header__controls"> |
779 | 38 | <button class="button--base button--inline" data-ng-click="cancelDeleteButton()">Cancel</button> | 38 | <button class="button--base button--inline" type="button" data-ng-click="cancelDeleteButton()">Cancel</button> |
780 | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> | 39 | <button class="button--secondary button--inline" data-ng-click="deleteConfirmButton()">Retry</button> |
781 | 40 | </div> | 40 | </div> |
782 | 41 | </section> | 41 | </section> |
783 | @@ -73,7 +73,7 @@ | |||
784 | 73 | </dl> | 73 | </dl> |
785 | 74 | </fieldset> | 74 | </fieldset> |
786 | 75 | <div class="twelve-col u-align--right"> | 75 | <div class="twelve-col u-align--right"> |
788 | 76 | <button class="button--base button--inline" | 76 | <button class="button--base button--inline" type="button" |
789 | 77 | data-ng-click="exitEditSummary()">Cancel</button> | 77 | data-ng-click="exitEditSummary()">Cancel</button> |
790 | 78 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> | 78 | <button class="button--positive button--inline" maas-obj-save>Save summary</button> |
791 | 79 | </div> | 79 | </div> |
792 | diff --git a/src/maasserver/static/partials/zones-list.html b/src/maasserver/static/partials/zones-list.html | |||
793 | index 81edc3f..5aa8ea3 100755 | |||
794 | --- a/src/maasserver/static/partials/zones-list.html | |||
795 | +++ b/src/maasserver/static/partials/zones-list.html | |||
796 | @@ -21,7 +21,7 @@ | |||
797 | 21 | placeholder="Name (required)"></maas-obj-field> | 21 | placeholder="Name (required)"></maas-obj-field> |
798 | 22 | </fieldset> | 22 | </fieldset> |
799 | 23 | <div class="page-header__controls"> | 23 | <div class="page-header__controls"> |
801 | 24 | <button class="button--base button--inline" data-ng-click="closeZone()">Cancel</button> | 24 | <button class="button--base button--inline" type="button" data-ng-click="closeZone()">Cancel</button> |
802 | 25 | <button class="button--positive button--inline" maas-obj-save>Add zone</button> | 25 | <button class="button--positive button--inline" maas-obj-save>Add zone</button> |
803 | 26 | </div> | 26 | </div> |
804 | 27 | </maas-obj-form> | 27 | </maas-obj-form> |
UNIT TESTS
-b lp1683794-1524120 lp:~newell-jensen/maas into -b master lp:~maas-committers/maas
STATUS: FAILED maas-ci- jenkins. internal: 8080/job/ maas/job/ branch- tester/ 862/console fdf8bbcde465e04 bba96bea61
LOG: http://
COMMIT: 8f61cecc8ea1a62