Code review comment for ~newell-jensen/maas:lp1702751
Revision history for this message
| Newell Jensen (newell-jensen) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> This seems to be a work around to the issue. Why would this be needed in
> auth.py ? This is not an authentication issue.
A nonce has to do with authentication.
>
> That said, it seems to me we should allow adding a machine even with incorrect
> power parameters.
This is a partial workaround because nonce's have to do with authentication but the fact that this pops up very rarely with these IPMI BMCs is where the workaround comes into play. We have a nonce cleanup method that runs daily in the region event loop so finding out why it is trying to use the same nonce is the real issue here it seems although that may be a rabbit hole into oauth territory.
The machine is still created, it just fails to commission and goes back to the NEW state.