Merge ~newell-jensen/maas:lp1702751 into maas:master

[Newell Jensen]

[Andres Rodriguez (andreserl)]

This seems to be a work around to the issue. Why would this be needed in auth.py ? This is not an authentication issue.

That said, it seems to me we should allow adding a machine even with incorrect power parameters.

review: Needs Information

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1702751 lp:~newell-jensen/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: a869c7116cae886a2a3f625451ef9169988081b3

review: Approve

[Newell Jensen (newell-jensen)]

> This seems to be a work around to the issue. Why would this be needed in
> auth.py ? This is not an authentication issue.

A nonce has to do with authentication.

>
> That said, it seems to me we should allow adding a machine even with incorrect
> power parameters.

This is a partial workaround because nonce's have to do with authentication but the fact that this pops up very rarely with these IPMI BMCs is where the workaround comes into play. We have a nonce cleanup method that runs daily in the region event loop so finding out why it is trying to use the same nonce is the real issue here it seems although that may be a rabbit hole into oauth territory.

The machine is still created, it just fails to commission and goes back to the NEW state.

Unmerged commits

a869c71... by Newell Jensen on 2017-11-29

LP: #1702751 -- Change nonce error that is being surfaced to the api when a bmc cannot be reached.

diff --git a/src/maasserver/api/auth.py b/src/maasserver/api/auth.py
index a14ba60..3bb5c1d 100644
--- a/src/maasserver/api/auth.py
+++ b/src/maasserver/api/auth.py
@@ -26,6 +26,10 @@ class OAuthUnauthorized(Unauthorized):
         # user-friendly error message.
         if error.message == "Invalid consumer.":
             self.error.message = "Authorization Error: Invalid API key."
+        # XXX newell 2017-11-29 bug=1702751: Change the error message to
+        # something that we know causes this issue.
+        elif "Nonce already used" in error.message:
+            self.error.message = "BMC can't be reached."
         else:
             self.error.message = "Authorization Error: %r" % error.message
 
diff --git a/src/maasserver/api/tests/test_auth.py b/src/maasserver/api/tests/test_auth.py
index febcb25..cb43cd2 100644
--- a/src/maasserver/api/tests/test_auth.py
+++ b/src/maasserver/api/tests/test_auth.py
@@ -30,3 +30,12 @@ class TestOAuthUnauthorized(MAASTestCase):
         self.assertThat(
             str(maas_exception),
             Contains("Authorization Error: Invalid API key."))
+
+    # XXX newell 2017-11-29 bug=1702751: Change the error message to
+    # something that we know causes this issue.
+    def test_exception_unicode_includes_bmc_cannot_be_reached_message(self):
+        original_exception = oauth.OAuthError('Nonce already used')
+        maas_exception = OAuthUnauthorized(original_exception)
+        self.assertThat(
+            str(maas_exception),
+            Contains("BMC can't be reached."))