Juju Charms Collection
mysql package

Merge lp:~negronjl/charms/precise/mysql/mysql-file-permissions into lp:charms/mysql

  1. Precise Pangolin (12.04)
  2. mysql-file-permissions
  3. Merge into trunk
Proposed by Juan L. Negron
Status: Merged
Merged at revision: 123
Proposed branch: lp:~negronjl/charms/precise/mysql/mysql-file-permissions
Merge into: lp:charms/mysql
Diff against target: 11 lines (+1/-0)
1 file modified
hooks/shared_db_relations.py (+1/-0)
To merge this branch: bzr merge lp:~negronjl/charms/precise/mysql/mysql-file-permissions
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Ante Karamatić (community) Needs Information
Review via email: mp+208293@code.launchpad.net

Description of the change

Fix for lp:1177143

To post a comment you must log in.
Revision history for this message
Ante Karamatić (ivoks) wrote :

Please fix indentation (you used tabs while rest of the file uses spaces).

review: Needs Fixing
Revision history for this message
Juan L. Negron (negronjl) wrote :

Stupid editor!! I'll Fix right now.

Thanks,

Juan

On Wed, Feb 26, 2014 at 12:56 AM, Ante Karamatić <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Please fix indentation (you used tabs while rest of the file uses spaces).
> --
>
> https://code.launchpad.net/~negronjl/charms/precise/mysql/mysql-file-permissions/+merge/208293
> You are the owner of
> lp:~negronjl/charms/precise/mysql/mysql-file-permissions.
>

Revision history for this message
Juan L. Negron (negronjl) wrote :

Fixed .. Please review

Thanks,

Juan

On Wed, Feb 26, 2014 at 7:50 AM, Juan Negron <email address hidden>wrote:

> Stupid editor!! I'll Fix right now.
>
> Thanks,
>
> Juan
>
>
> On Wed, Feb 26, 2014 at 12:56 AM, Ante Karamatić <
> <email address hidden>> wrote:
>
>> Review: Needs Fixing
>>
>> Please fix indentation (you used tabs while rest of the file uses spaces).
>> --
>>
>> https://code.launchpad.net/~negronjl/charms/precise/mysql/mysql-file-permissions/+merge/208293
>> You are the owner of
>> lp:~negronjl/charms/precise/mysql/mysql-file-permissions.
>>
>
>

Revision history for this message
Juan L. Negron (negronjl) wrote :

Fixed it. Please review.

Revision history for this message
Ante Karamatić (ivoks) wrote :

You didn't push the change :)

review: Needs Information
lp:~negronjl/charms/precise/mysql/mysql-file-permissions updated
115. By Juan L. Negron

Fixed indentation

Revision history for this message
Juan L. Negron (negronjl) wrote :

Well .. this is annoying :)

Revision 115 should have it .... I swear this time :)

Thanks,

Juan

On Wed, Feb 26, 2014 at 11:59 AM, Ante Karamatić <
<email address hidden>> wrote:

> Review: Needs Information
>
> You didn't push the change :)
> --
>
> https://code.launchpad.net/~negronjl/charms/precise/mysql/mysql-file-permissions/+merge/208293
> You are the owner of
> lp:~negronjl/charms/precise/mysql/mysql-file-permissions.
>

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM, +1

review: Approve
Revision history for this message
Yaguang Tang (heut2008) wrote :

can anyone help approve to merge the patch?

Revision history for this message
Mark Russell (marrusl) wrote :

Can this merge be approved now? Thanks,
Mark

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/shared_db_relations.py'
2--- hooks/shared_db_relations.py 2013-07-10 16:32:52 +0000
3+++ hooks/shared_db_relations.py 2014-02-26 21:14:40 +0000
4@@ -53,6 +53,7 @@
5 password = pwgen()
6 with open(passwd_file, 'w') as pfile:
7 pfile.write(password)
8+ os.chmod(pfile.name, 0600)
9 else:
10 with open(passwd_file) as pfile:
11 password = pfile.read().strip()

Subscribers

People subscribed via source and target branches