Code review comment for lp:~nataliabidart/ubuntu/natty/magicicada/magicicada-0.3.0

Revision history for this message
Stefano Rivera (stefanor) wrote :

Hi looks ok, but a couple of small things pile up:
* changelog is a bit weirdly formatted (text indented to the same level as the bullets.
* You can use this syntax: (LP: #587020, #643195)
* I'd prefer something a little more concrete than "updated dependency list".
  It looks like: sorted depends, dropped depends-indep, depend on python-ubuntu-one-client (>= foo), depend on python-xdg
* No mention of the standards version update (these are traditionally changelogged as "Bumped Standards-Version to X.Y.Z (no changes needed)"
* No mention of the maintainer change in the changelog. Should the maintainer not be Ubuntu Developers <email address hidden>?
* No mention of the description change.
* Copyright:
  - I assume the copyright years need a bump.
  - DEP5 has evolved quite a bit, at some point this file should be updated to match the current standards.
  - The short GPL licence grant should be included before the "full text" notice.
* At some point, you should consider migrating to dh_python2, AFAIK doko is quite keen for Ubuntu-specific packages to migrate during natty.

review: Needs Fixing

« Back to merge proposal