Enhance code quality
Bug #587020 reported by
Facundo Batista
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| magicicada gui |
Fix Released
|
Medium
|
Facundo Batista | ||
Bug Description
We should run pylint with tests, to control code quality.
I propose a simple "test" executable that runs pylint and trial
Related branches
lp:~facundo/magicicada-gui/code-quality
- Natalia Bidart: Approve
-
Diff: 882 lines (+384/-225)10 files modifiedmagicicada/__init__.py (+11/-7)
magicicada/cmd_pof.py (+0/-190)
magicicada/dbusiface.py (+3/-0)
magicicada/helpers.py (+8/-6)
magicicada/syncdaemon.py (+1/-2)
magicicada/tests/test_dbusiface.py (+7/-0)
magicicada/tests/test_magicicada.py (+24/-13)
magicicada/tests/test_syncdaemon.py (+10/-7)
pylintrc (+319/-0)
test (+1/-0)
lp:~nataliabidart/magicicada-gui/use-initial-on-gui
- Facundo Batista: Approve
-
Diff: 1043 lines (+222/-218)8 files modifiedmagicicada/__init__.py (+17/-18)
magicicada/logger.py (+5/-0)
magicicada/syncdaemon.py (+4/-0)
magicicada/tests/test_dbusiface.py (+29/-29)
magicicada/tests/test_magicicada.py (+29/-38)
magicicada/tests/test_syncdaemon.py (+13/-6)
pylintrc (+116/-124)
test (+9/-3)
lp:~facundo/magicicada-gui/multiple-queue-changes
- Natalia Bidart: Approve
-
Diff: 320 lines (+227/-17)4 files modifiedmagicicada/helpers.py (+5/-5)
magicicada/logger.py (+2/-3)
magicicada/syncdaemon.py (+37/-8)
magicicada/tests/test_syncdaemon.py (+183/-1)
| Changed in magicicada: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| milestone: | none → alpha1 |
| milestone: | alpha1 → alpha2 |
| Changed in magicicada: | |
| assignee: | nobody → Facundo Batista (facundo) |
| status: | Confirmed → In Progress |
Revision history for this message
| Facundo Batista (facundo) wrote | #1 |
| Changed in magicicada: | |
| status: | In Progress → Fix Released |
| Changed in magicicada: | |
| status: | Fix Released → In Progress |
| Changed in magicicada: | |
| status: | In Progress → Fix Committed |
| Changed in magicicada: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Proposed a branch to start analyzing code with Pylint.
This bug will be closed when it doesn't find anything in the codebase.