Code review comment for ~nacc/git-ubuntu:use-dpkg-mergechangelogs

Revision history for this message
Robie Basak (racb) wrote :

Looks good!

I'm not keen on the clobbering of the work tree, but I think we need to fix that separately.

> gitubuntu/git_repository: cat-file produces extra blank lines

I think the commit summary should be written in the sense of what is being changed, rather than the problem being fixed. Though the problem being fixed is fine to explain the commit description.

So how about: "GitUbuntuRepository: suppress extra cat-file blank lines"

review: Approve

« Back to merge proposal