logging.info() writes to the terminal by default, so do not use it in
such a common place. Library code shouln't write to the terminal except
by request of the caller.
Adapated from code from Robie Basak, to keep CLI-compatibility with
the prior code, which emitted the tempdir used, if any.
Now we're back where we started. Tests pass for versions calculations
that we had working. The test for the SRU "same version in multiple
series" versioning exception fails as expected, and we're in a position
to be able to implement it.
This is much simpler than the really obtuse fully qualified name. I know
I usually don't like doing this, but in this case (frequent use, obtuse
otherwise) I think it's worth it. We only use one type of Version object
in this module so this should cause minimal confusion.
I'm not sure what the logic of the check was before, but it didn't work
(false negatives), so I've rewritten it. All I do is run
update-maintainer and check that it changes nothing. Since
update-maintainer is idempotent, this should always work as far as I can
see.
I'm still dubious about the clobbering of the working tree when
generating the tree object that corresponds to an update-maintainer run,
but this is not a regression and can be fixed in a future commit.
