Merge lp:~mwhudson/lava-dispatcher/bug-900990 into lp:lava-dispatcher
Proposed by
Michael Hudson-Doyle
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 173 | ||||
Proposed branch: | lp:~mwhudson/lava-dispatcher/bug-900990 | ||||
Merge into: | lp:lava-dispatcher | ||||
Diff against target: |
75 lines (+20/-18) 1 file modified
lava_dispatcher/client/master.py (+20/-18) |
||||
To merge this branch: | bzr merge lp:~mwhudson/lava-dispatcher/bug-900990 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Larson (community) | Approve | ||
Review via email: mp+84701@code.launchpad.net |
Description of the change
This branch moves the wget | tar type of deployment into a helper function, and makes sure that we fail if this command fails (which was not previously the case for android deployments).
To post a comment you must log in.
8 +def _deploy_ tarball_ to_board( session, tarball_url, dest, timeout=-1): url.endswith( '.gz') or tarball_ url.endswith( '.tgz') : url.endswith( '.bz2') : char),
9 + decompression_char = ''
10 + if tarball_
11 + decompression_char = 'z'
12 + elif tarball_
13 + decompression_char = 'j'
14 + rc = session.run(
15 + 'wget -qO- %s |tar --numeric-owner -C %s -x%sf -' % (
16 + tarball_url, dest, decompression_
17 + timeout=3600)
I would imagine you intended to use the specified timeout passed in.
Otherwise, +1