Code review comment for lp:~mwhudson/lava-dispatcher/bug-900990

Revision history for this message
Paul Larson (pwlars) wrote :

8 +def _deploy_tarball_to_board(session, tarball_url, dest, timeout=-1):
9 + decompression_char = ''
10 + if tarball_url.endswith('.gz') or tarball_url.endswith('.tgz'):
11 + decompression_char = 'z'
12 + elif tarball_url.endswith('.bz2'):
13 + decompression_char = 'j'
14 + rc = session.run(
15 + 'wget -qO- %s |tar --numeric-owner -C %s -x%sf -' % (
16 + tarball_url, dest, decompression_char),
17 + timeout=3600)
I would imagine you intended to use the specified timeout passed in.

Otherwise, +1

review: Approve

« Back to merge proposal