~mwhudson/curtin:mdadm-check-container

Branch merges

Propose for merging

Merged into curtin:master

Server Team CI bot: Approve (continuous-integration) on 2021-05-10

curtin developers: Pending requested 2021-05-07

Diff: 643 lines (+299/-108)

5 files modified

curtin/block/mdadm.py (+42/-63)
curtin/block/schemas.py (+5/-1)
curtin/commands/block_meta.py (+27/-11)
tests/unittests/test_block_mdadm.py (+198/-26)
tests/unittests/test_commands_block_meta.py (+27/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

12f5d09... by Michael Hudson-Doyle on 2021-05-10

log failures a bit more clearly as per review

8604c3e... by Michael Hudson-Doyle on 2021-05-07

do not check the array state for a container

maybe we should assert that it is "inactive" which is what it seems to be?

b527f76... by Michael Hudson-Doyle on 2021-05-07

realpath MD_CONTAINER before comparing it to passed container

f85b0cf... by Michael Hudson-Doyle on 2021-05-07

fix verifying a raid0 array (which has no degraded or sync_action attributes)

ad4b25a... by Michael Hudson-Doyle on 2021-05-07

block_meta: make preserve: true on a raid in a container work

Pass any supplied container name to raid_verify and on to md_check and
check it against the existing device.

Also tidy up a few other things in the raid verification code path: make
checking functions consistently raise ValueError on failure rather than
returning True / False and have the verification of raid level actually
check the level of the existing array.

d49d35b... by Dan Bungert on 2021-04-15

Use /proc/filesystems to decide passno

The 'nodev' is intended to indicate
"whether the file system is mounted on a block device"
https://red.ht/3toGT5b

Use this info to set nodev items to passno 0, and default to 1 for
non-nodev or if the filesystem isn't present there.
Except that /proc/filesystems doesn't list 'swap' or 'none', so special
case those to passno 0.

LP: #1717584, LP: #1785354

1ff27dd... by Michael Hudson-Doyle on 2021-04-15

block_meta: fix wiping of existing dasd partition

The partition verification code does not need the part_path variable in
this case but the partition wiping code does.

87aa64b... by Michael Hudson-Doyle on 2021-04-13

block_meta: pass --yes to lvcreate alongside --wipesignatures=y

Otherwise it will not actually wipe the signatures it finds.

LP: #1923487

4339a49... by Michael Hudson-Doyle on 2021-03-25

remove 'strict' arguments to block.wipe_volume and block.quick_zero

It was only passed by clear_holders._wipe_superblock and clear_holders
is all best effort anyway.

in particular, this should fix failures seen in subiquity error reports
when wiping very small (<1M) partitions.

LP: #1868177

c204635... by Michael Hudson-Doyle on 2021-03-24

swap: use dd to allocate swapfiles on ext2 and ext3

LP: #1918990