lp:~mwhudson/curtin

Get this repository:
git clone https://git.launchpad.net/~mwhudson/curtin
Only Michael Hudson-Doyle can upload to this repository. If you are Michael Hudson-Doyle please log in for upload directions.

Branches

Name Last Modified Last Commit
lp-1927703 2021-05-10 02:26:59 UTC 2021-05-10
curthook: always install shim-signed if available (when UEFI booted)

Author: Michael Hudson-Doyle
Author Date: 2021-05-10 02:26:59 UTC

curthook: always install shim-signed if available (when UEFI booted)

Rather than just on amd64. It's been available on arm64 since at least
20.04 (and is in bionic-updates).

mdadm-check-container 2021-05-10 00:30:52 UTC 2021-05-10
log failures a bit more clearly as per review

Author: Michael Hudson-Doyle
Author Date: 2021-05-10 00:30:52 UTC

log failures a bit more clearly as per review

convert-imsm 2021-04-21 02:04:08 UTC 2021-04-21
storage_config: properly handle raid containers

Author: Michael Hudson-Doyle
Author Date: 2021-04-21 02:04:08 UTC

storage_config: properly handle raid containers

dasd-partition-reuse 2021-04-13 22:10:29 UTC 2021-04-13
block_meta: fix wiping of existing dasd partition

Author: Michael Hudson-Doyle
Author Date: 2021-04-13 22:10:26 UTC

block_meta: fix wiping of existing dasd partition

The partition verification code does not need the part_path variable in
this case but the partition wiping code does.

lp-1923487 2021-04-12 22:23:50 UTC 2021-04-12
block_meta: pass --yes to lvcreate alongside --wipesignatures=y

Author: Michael Hudson-Doyle
Author Date: 2021-04-12 22:23:50 UTC

block_meta: pass --yes to lvcreate alongside --wipesignatures=y

Otherwise it will not actually wipe the signatures it finds.

LP: #1923487

raid-min-levels 2021-04-11 23:41:24 UTC 2021-04-11
mdadm: RAID levels 5 and 10 can both be created with 2 devices

Author: Michael Hudson-Doyle
Author Date: 2021-04-11 23:33:52 UTC

mdadm: RAID levels 5 and 10 can both be created with 2 devices

RAID5 with 2 devices is a bit strange but it's not really curtin's place
to check this IMO.

RAID10 with 2 is not that strange though, perhaps linux "RAID10" should
have been called something else so it doesn't get confused with
"RAID1+0" so much, which is really something else.

lp-1918990-dd-ext2 2021-03-24 00:52:10 UTC 2021-03-24
sort list

Author: Michael Hudson-Doyle
Author Date: 2021-03-24 00:52:10 UTC

sort list

lp-1918990 2021-03-23 03:36:28 UTC 2021-03-23
do not create swapfiles on ext2

Author: Michael Hudson-Doyle
Author Date: 2021-03-23 03:36:28 UTC

do not create swapfiles on ext2

lp-1868177 2021-03-23 03:19:53 UTC 2021-03-23
add a tiny partition to a randomly selected vmtest

Author: Michael Hudson-Doyle
Author Date: 2021-03-23 03:19:53 UTC

add a tiny partition to a randomly selected vmtest

lp-1893818 2021-03-03 20:53:07 UTC 2021-03-03
fix things some more

Author: Michael Hudson-Doyle
Author Date: 2021-03-02 10:33:52 UTC

fix things some more

release-21.2 2021-01-27 00:50:08 UTC 2021-01-27
Release 21.2

Author: Michael Hudson-Doyle
Author Date: 2021-01-27 00:50:08 UTC

Release 21.2

Bump the version in curtin/__init__.py to 21.2.

LP: #1913357

revert-lp1892494 2021-01-26 21:26:24 UTC 2021-01-26
Revert "apt_config: stop using the deprecated apt-key command"

Author: Michael Hudson-Doyle
Author Date: 2021-01-26 21:26:15 UTC

Revert "apt_config: stop using the deprecated apt-key command"

This reverts commit e099e32c5757b7aa0bc4fc2aeddb91d195a6df2b.

Unfortunately the gpg keys are not being added to the right place on
disk.

LP: #1912801

reuse-dasd-partitions 2021-01-26 02:22:47 UTC 2021-01-26
partition_handler: fix NameError when reusing a vtoc partition

Author: Michael Hudson-Doyle
Author Date: 2021-01-26 02:22:47 UTC

partition_handler: fix NameError when reusing a vtoc partition

lp-1912801 2021-01-26 02:06:55 UTC 2021-01-26
apt_config: put added gpg in correct place in filesystem

Author: Michael Hudson-Doyle
Author Date: 2021-01-26 02:06:55 UTC

apt_config: put added gpg in correct place in filesystem

lp-1878041 2021-01-21 23:35:53 UTC 2021-01-21
fix two multipath bugs:

Author: Michael Hudson-Doyle
Author Date: 2021-01-20 02:11:02 UTC

fix two multipath bugs:

1) find_mpath_id asked multipathd to list all maps and read out the name
   (or wwid if no name) of the device from that and sometimes timed out,
   but this information is already present in udev as DM_NAME. And
   DM_NAME is the wwid if user_friendly_names is disabled, so there's no
   need to be conditional about that either.

2) fix calculating start and offset of partition on multipathed 4k disk

   calc_dm_partition_info returns start and offset in 512-byte sectors
   but calc_partition_info only adjusted the sectors in the
   non-multipath case.

   I also did some code tidying, including moving the responsibility for
   raising an exception if dmsetup produces no output to
   calc_dm_partition_info.

LP: #1878041

lp-1878041-4k-multipath 2021-01-21 23:29:58 UTC 2021-01-21
fix calculating start and offset of partition on multipathed 4k disk

Author: Michael Hudson-Doyle
Author Date: 2021-01-21 10:41:55 UTC

fix calculating start and offset of partition on multipathed 4k disk

calc_dm_partition_info returns start and offset in 512-byte sectors but
calc_partition_info only adjusted the sectors in the non-multipath case.

I also did some code tidying, including moving the responsibility for
raising an exception if dmsetup produces no output to
calc_dm_partition_info.

LP: #1878041

fix-multipath-partition-verification-2 2021-01-19 23:36:48 UTC 2021-01-19
oops

Author: Michael Hudson-Doyle
Author Date: 2021-01-19 23:36:48 UTC

oops

release-21.1 2021-01-15 03:08:44 UTC 2021-01-15
Release 21.1

Author: Michael Hudson-Doyle
Author Date: 2021-01-15 03:08:44 UTC

Release 21.1

Bump the version in curtin/__init__.py to 21.1.

LP: #1911841

virt-dasds 2021-01-14 00:31:55 UTC 2021-01-14
storage_config: set ptable to vtoc for 'virt' dasds as well as 'ECKD'

Author: Michael Hudson-Doyle
Author Date: 2021-01-14 00:31:12 UTC

storage_config: set ptable to vtoc for 'virt' dasds as well as 'ECKD'

fix-multipath-partition-verification 2021-01-12 21:41:23 UTC 2021-01-12
simplify mocking in TestSlaveKnames

Author: Michael Hudson-Doyle
Author Date: 2021-01-12 21:41:23 UTC

simplify mocking in TestSlaveKnames

dead-code 2021-01-12 03:24:29 UTC 2021-01-12
fix flakes

Author: Michael Hudson-Doyle
Author Date: 2021-01-12 03:24:29 UTC

fix flakes

block-device-object 2021-01-12 01:51:08 UTC 2021-01-12
beginnings, good idea, lot of work

Author: Michael Hudson-Doyle
Author Date: 2021-01-12 01:51:08 UTC

beginnings, good idea, lot of work

pass-disk_path-to-partition_verify 2021-01-07 22:23:25 UTC 2021-01-07
block_meta: pass disk_path to partition_verify and to sfdisk_info

Author: Michael Hudson-Doyle
Author Date: 2021-01-07 22:18:26 UTC

block_meta: pass disk_path to partition_verify and to sfdisk_info

Currently there is a failure trying to reuse an existing partition of a
multipath device because get_blockdev_for_partition doesn't work on a
multipath partition. Probably get_blockdev_for_partition should be fixed
but as partition_handler has the disk path anyway, I think it makes for
saner code to just pass that around instead.

partition-dasd-without-device_id 2020-12-14 11:23:39 UTC 2020-12-14
allow adding a vtoc partition without a device id

Author: Michael Hudson-Doyle
Author Date: 2020-11-19 20:54:05 UTC

allow adding a vtoc partition without a device id

this is needed for the "dasd passed to kvm via virtio" use case

fix-DasdPartitionTable 2020-12-08 01:02:00 UTC 2020-12-08
py27 compat

Author: Michael Hudson-Doyle
Author Date: 2020-12-08 01:02:00 UTC

py27 compat

fba-dasd 2020-12-08 01:00:41 UTC 2020-12-08
py27 compat

Author: Michael Hudson-Doyle
Author Date: 2020-12-08 01:00:41 UTC

py27 compat

dasd-merge 2020-12-04 01:30:05 UTC 2020-12-04
only default ECKD dasds to vtoc ptables

Author: Michael Hudson-Doyle
Author Date: 2020-12-04 01:30:05 UTC

only default ECKD dasds to vtoc ptables

pare-down-dasdview-parsing 2020-11-25 00:10:51 UTC 2020-11-25
add a comment explaining how we go from device_id to kname

Author: Michael Hudson-Doyle
Author Date: 2020-11-25 00:10:51 UTC

add a comment explaining how we go from device_id to kname

only-eckd-dasds-extract_storage_config 2020-11-24 23:55:31 UTC 2020-11-24
my probert branch emits type on dasds not dasd_type

Author: Michael Hudson-Doyle
Author Date: 2020-11-24 23:55:31 UTC

my probert branch emits type on dasds not dasd_type

vmtest-raid-partition-to-disk 2020-11-19 21:13:48 UTC 2020-11-19
fix test docstring

Author: Michael Hudson-Doyle
Author Date: 2020-11-19 21:13:48 UTC

fix test docstring

partition-verify-dasd 2020-11-19 08:20:41 UTC 2020-11-19
remove test for just-deleted code

Author: Michael Hudson-Doyle
Author Date: 2020-11-18 02:33:15 UTC

remove test for just-deleted code

disk_handler-empty-vtoc 2020-11-18 22:59:05 UTC 2020-11-18
create an empty vtoc in disk_handler

Author: Michael Hudson-Doyle
Author Date: 2020-11-18 22:59:02 UTC

create an empty vtoc in disk_handler

Another merge proposal I have uses fdasd to get the block and track size
when partitioning a disk. But the wiping disk_handler can do can do
enough damage to stop fdasd working at all. Putting an empty vtoc onto
the disk allows fdasd to report the sizes when needed.

simplify-dasd-code 2020-11-17 23:24:08 UTC 2020-11-17
remove unused parameters from dasd code

Author: Michael Hudson-Doyle
Author Date: 2020-11-17 23:24:08 UTC

remove unused parameters from dasd code

no-dasdview-partition-dasd 2020-11-17 10:08:30 UTC 2020-11-17
remove now-dead code and simplify parsing of dasdview output

Author: Michael Hudson-Doyle
Author Date: 2020-11-17 10:08:30 UTC

remove now-dead code and simplify parsing of dasdview output

we only need to parse dasdview to detect cdl/ldl/not-formatted

no-dasds-in-get_path_to_storage_volume 2020-11-16 03:31:03 UTC 2020-11-16
remove support for calling get_path_to_storage_volume on a dasd action

Author: Michael Hudson-Doyle
Author Date: 2020-11-16 03:31:03 UTC

remove support for calling get_path_to_storage_volume on a dasd action

there is no code path that will do this today, and this implementation
will not work with some changes I want to make to support dasds passed
via virtio.

dasd-rework 2020-11-13 04:05:14 UTC 2020-11-13
fix tests (mostly by deleting tests that now fail)

Author: Michael Hudson-Doyle
Author Date: 2020-11-13 04:05:14 UTC

fix tests (mostly by deleting tests that now fail)

dasd-fba 2020-11-04 00:48:53 UTC 2020-11-04
format FBA disks in disk_handler

Author: Michael Hudson-Doyle
Author Date: 2020-11-04 00:48:53 UTC

format FBA disks in disk_handler

lp-1899699 2020-10-14 01:00:32 UTC 2020-10-14
fix udevadm_info in the face of udev database values having "=" in them

Author: Michael Hudson-Doyle
Author Date: 2020-10-14 01:00:32 UTC

fix udevadm_info in the face of udev database values having "=" in them

LP: #1899699

update_nvram-default 2020-08-27 23:49:46 UTC 2020-08-27
restore default of grub.update_nvram to True in install_grub

Author: Michael Hudson-Doyle
Author Date: 2020-08-27 23:49:42 UTC

restore default of grub.update_nvram to True in install_grub

This was accidentally changed when the grub installation code was
converted from shell to Python.

udevadm_info-fix 2020-05-11 10:16:38 UTC 2020-05-11
fix crash in udevadm_info

Author: Michael Hudson-Doyle
Author Date: 2020-05-11 10:16:15 UTC

fix crash in udevadm_info

It appears someone did not understand how the maxplit argument to the
"".split method works.

lp-1876626 2020-05-04 07:59:02 UTC 2020-05-04
block.detect_multipath: ignore fake "devices" from /proc/mounts

Author: Michael Hudson-Doyle
Author Date: 2020-05-04 07:59:02 UTC

block.detect_multipath: ignore fake "devices" from /proc/mounts

A tmpfs can be mounted with any old junk in the "device" field and
unfortunately casper sometimes puts "/dev/shm" there, which is usually a
directory. Ignore such cases. (See https://bugs.launchpad.net/bugs/1876626)

feature/grub-resilient-boot 2020-04-20 08:15:05 UTC 2020-04-20
xenial compat

Author: Michael Hudson-Doyle
Author Date: 2020-04-20 08:15:05 UTC

xenial compat

filter-block-devices-less 2020-04-08 09:55:56 UTC 2020-04-08
storage_config: filter out /devices/virtual/block only

Author: Michael Hudson-Doyle
Author Date: 2020-04-08 09:55:44 UTC

storage_config: filter out /devices/virtual/block only

As seen on https://bugs.launchpad.net/subiquity/+bug/1868109, some PCI
NVMe devices get represented in very strange ways in sysfs/udev, leading
to things like this:

/devices/virtual/nvme-subsystem/nvme-subsys0/nvme0n1
 N: nvme0n1
 L: 0
 S: disk/by-id/nvme-SAMSUNG_MZPLL3T2HAJQ-00005_S4CCNE0M300015
 S: disk/by-id/nvme-eui.344343304d3000150025384500000004
 E: DEVPATH=/devices/virtual/nvme-subsystem/nvme-subsys0/nvme0n1
 E: SUBSYSTEM=block
 E: DEVNAME=/dev/nvme0n1
 E: DEVTYPE=disk
 E: MAJOR=259
 E: MINOR=1
 E: USEC_INITIALIZED=5210525
 E: MPATH_SBIN_PATH=/sbin
 E: DM_MULTIPATH_DEVICE_PATH=0
 E: ID_SERIAL_SHORT=S4CCNE0M300015
 E: ID_WWN=eui.344343304d3000150025384500000004
 E: ID_MODEL=SAMSUNG MZPLL3T2HAJQ-00005
 E: ID_REVISION=GPJA0B3Q
 E: ID_SERIAL=SAMSUNG MZPLL3T2HAJQ-00005_S4CCNE0M300015
 E: ID_PART_TABLE_UUID=4bac57b7-307b-4b0e-a853-e0232c6fb955
 E: ID_PART_TABLE_TYPE=gpt
 E: DEVLINKS=/dev/disk/by-id/nvme-SAMSUNG_MZPLL3T2HAJQ-00005_S4CCNE0M300015 /dev/disk/by-id/nvme-eui.344343304d3000150025384500000004
 E: TAGS=:systemd:

needing to be represented as "type: disk" actions.

lp-1847771 2019-10-14 20:39:36 UTC 2019-10-14
storage_config: interpret value, not presence, of DM_MULTIPATH_DEVICE_PATH

Author: Michael Hudson-Doyle
Author Date: 2019-10-14 20:39:36 UTC

storage_config: interpret value, not presence, of DM_MULTIPATH_DEVICE_PATH

Curtin assumes any block device that has the DM_MULTIPATH_DEVICE_PATH
key set in udev is a block device, but that's not correct. Since
multipath-tools 0.7.7 (according to
https://www.spinics.net/lists/dm-devel/msg35965.html), _every_ block
device that multipathd looks at gets that key set, but it is set to "1"
for things that are part of a multipathed device and "0" for things that
are not. So fix the checks in curtin to follow that.

lookup_disk-by-udev 2019-07-23 11:09:10 UTC 2019-07-23
query udev database directly when looking for a disk by serial

Author: Michael Hudson-Doyle
Author Date: 2019-07-23 11:09:10 UTC

query udev database directly when looking for a disk by serial

clear-holders-partitions 2019-07-22 23:35:15 UTC 2019-07-22
patch from ryan

Author: Michael Hudson-Doyle
Author Date: 2019-07-11 03:22:57 UTC

patch from ryan

vmtest-reuse-half-a-raid 2019-07-18 04:08:47 UTC 2019-07-18
use raid0 not raid1 for these tests

Author: Michael Hudson-Doyle
Author Date: 2019-07-18 04:08:47 UTC

use raid0 not raid1 for these tests

lp-1835087 2019-07-08 23:23:08 UTC 2019-07-08
add test

Author: Michael Hudson-Doyle
Author Date: 2019-07-08 23:03:31 UTC

add test

for-subiquity 2019-05-30 02:12:28 UTC 2019-05-30
Merge branch 'feature/block-discover' into for-subiquity

Author: Michael Hudson-Doyle
Author Date: 2019-05-30 02:12:28 UTC

Merge branch 'feature/block-discover' into for-subiquity

vmtest-preserve-raid 2019-05-28 22:06:24 UTC 2019-05-28
mdadm: fix install to existing raid

Author: Michael Hudson-Doyle
Author Date: 2019-05-27 04:20:31 UTC

mdadm: fix install to existing raid

Just change the export=False to export=True in the call to mdadm_examine
in md_check_array_membership.

LP: #1830157

vmtest-preserve-partition 2019-05-28 22:04:59 UTC 2019-05-28
vmtest: add test that reuses a partition created by early_commands

Author: Michael Hudson-Doyle
Author Date: 2019-05-27 01:31:40 UTC

vmtest: add test that reuses a partition created by early_commands

mdadm-vs-daemons 2019-05-19 23:19:38 UTC 2019-05-19
curthoooks: disable daemons while reconfiguring mdadm

Author: Michael Hudson-Doyle
Author Date: 2019-05-19 22:06:12 UTC

curthoooks: disable daemons while reconfiguring mdadm

By switching from subp(..., target=...) to ChrootableTarget.

For LP: #1829325.

lvm_partition-integer-size 2019-04-04 21:26:55 UTC 2019-04-04
address review comments

Author: Michael Hudson-Doyle
Author Date: 2019-04-04 21:26:55 UTC

address review comments

1. add unit test
2. be more consistent in using " vs ' for strings

dm_crypt-keyfile 2019-02-27 01:21:54 UTC 2019-02-27
use util.write_file

Author: Michael Hudson-Doyle
Author Date: 2019-02-21 12:58:07 UTC

use util.write_file

master 2019-02-15 20:42:42 UTC 2019-02-15
Support for multi-layers images fsimage-layered:// URI

Author: Jean-Baptiste Lallement
Author Date: 2019-02-15 20:42:42 UTC

Support for multi-layers images fsimage-layered:// URI

Curtin can now download and mount a layered filesystem image for use
as a source image. Local file or url are supported. Filesystem can be
any filesystem type mountable by the running kernel.

A "fsimage-layered" install source is a string representing one or
more mountable images from a single local or remote directory. The
string is dot-separated where each value between the dots represents a
particular image and the location of the name within the string
encodes the order in which it is to be mounted. The resulting list of
images are downloaded (if needed) then mounted and overlayed into a
single directory which is used as the source for installation.

See documentation for further details.

document-ptable-raid 2018-06-21 22:21:46 UTC 2018-06-21
add partitioned raid example

Author: Michael Hudson-Doyle
Author Date: 2018-06-21 22:21:46 UTC

add partitioned raid example

lp-1764210 2018-04-17 00:26:51 UTC 2018-04-17
Add unittests to validate install exception kept when unmount:disabled set

Author: Ryan Harper
Author Date: 2018-04-16 18:36:46 UTC

Add unittests to validate install exception kept when unmount:disabled set

157 of 57 results
This repository contains Public information 
Everyone can see this information.