~mwhudson/curtin:lp-1940687-oh-no

Branch merges

Propose for merging

Merged into curtin:master

Server Team CI bot: Approve (continuous-integration) on 2021-08-23

Dan Bungert: Approve on 2021-08-23

Diff: 115 lines (+39/-10)

3 files modified

curtin/block/lvm.py (+9/-6)
curtin/commands/curthooks.py (+23/-1)
tests/unittests/test_block_lvm.py (+7/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

a8a58e8... by Lukas Märdian on 2021-08-02

block:lvm: search encrypted volumes for LVM

Fixes LP: #1895192

32e0fd9... by Michael Hudson-Doyle on 2021-08-23

Revert "curthooks: do not add lvm devices filter when / is mutipathed"

This reverts commit 3673687e867eeb88a3e7fd72587a75d5fc811f5a.

cf07c23... by Michael Hudson-Doyle on 2021-08-12

mdadm: allow installation to a syncing array

LP: #1939563

6c07453... by Dan Bungert on 2021-08-10

vmtests: s/Groovy/Impish

* Use vmtest-{add,remove}-release to remove Groovy, and add Impish.
* vmtest-{add,remove}-release: set default path

40a09ae... by Michael Hudson-Doyle on 2021-08-08

tweak making mountpoints private some more

My recent change to move the making of mountpoints private into
do_umount actually made it ineffective. I tried to change things
so that we always made mountpoints private before unmounting them
but that ran into problems of its own. So I changed do_umount to
have a "private" flag ChrootableTarget.__exit__ could use to
request that mountpoints be made private before unmounting, which
makes things work again but I still don't see how to make a
generally robust "curtin unmount" command, as explained at length
in the comment I added.

8d8687f... by Michael Hudson-Doyle on 2021-08-04

curthooks: do not unconditionally copy e/n/interfaces to target

When I tried to install a more-minimal server image using curtin, it
failed in copy_interfaces because the image did not have an /etc/network
directory at all (full ubuntu-server images have this directory because
ethtool installs files in there). Fix this by shuffling around how the
$state_dir/interfaces file is handled a bit: basically it used to always
be created by the install commmand and then updated by the net-meta
command. Change this to have the file only be created by net-meta, then
curthooks can copy it if and only if it exists.

49626ef... by Lukas Märdian on 2021-08-03

block: handle /dev/mapper/* in dev_path()

Fixes LP: #1895192

3673687... by Michael Hudson-Doyle on 2021-08-03

curthooks: do not add lvm devices filter when / is mutipathed

This code was added to defend against lvcreate seeing multiple paths to
a PV but the relevant udev rules already protect against this, and the
devices filter prevents assembling a VG containing an encrypted volume.

LP: #1895192

c06ee5f... by Dan Bungert on 2021-08-02

Extend the 'format' schema for unknown fstypes

Permit arbitrary fstype values if preserve == true
Goal here is to enumerate more filesystem formats, ones that blkid
recognizes, but not claim in any way that we can create them.
This is useful for presenting existing filesystem partitions to users
in an installer, as otherwise they just get unhelpfully marked as
'unknown'.

e0d2959... by Michael Hudson-Doyle on 2021-08-02

move making mounts recursively private into do_unmount

This means that running "curtin unmount -t /target" gets the robustness
improvments that were recently added to ChrootableTarget.