curtin

Merge ~mwhudson/curtin:more-larger-parts into curtin:master

  1. Git
  2. lp:~mwhudson/curtin
  3. more-larger-parts
  4. Merge into master
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 121dd0a888c4c5517ec0ae5d1a119a17aaa9cba6
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~mwhudson/curtin:more-larger-parts
Merge into: curtin:master
Diff against target: 26 lines (+2/-2)
2 files modified
examples/tests/basic.yaml (+1/-1)
examples/tests/basic_iscsi.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Dan Bungert Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+416229@code.launchpad.net

Commit message

examples: enlarge / for some more vmtests

These ones only fail on ppc64el for whatever reason.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:121dd0a888c4c5517ec0ae5d1a119a17aaa9cba6
https://jenkins.ubuntu.com/server/job/curtin-ci/272/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/272/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/272/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/272/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/272/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/272//rebuild

review: Approve (continuous-integration)
Revision history for this message
Dan Bungert (dbungert) wrote :

I read basic.yaml trying to guess why ppc might have objections to the current file.
While I didn't really get an answer to that question, I did find that the format directive sparedisk_fat_fmt_id is formatting disk sparedisk_id without an intermediate partition and I was wondering what to think about that.

review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

It's definitely possible to format a disk directly. It's not something you're very likely to want to do very often, but it is possible.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/examples/tests/basic.yaml b/examples/tests/basic.yaml
2index 82f5ad1..9b5f7ea 100644
3--- a/examples/tests/basic.yaml
4+++ b/examples/tests/basic.yaml
5@@ -17,7 +17,7 @@ storage:
6 - id: sda1
7 type: partition
8 number: 1
9- size: 3GB
10+ size: 4GB
11 device: sda
12 flag: boot
13 - id: sda2
14diff --git a/examples/tests/basic_iscsi.yaml b/examples/tests/basic_iscsi.yaml
15index 88516ca..4e9f89a 100644
16--- a/examples/tests/basic_iscsi.yaml
17+++ b/examples/tests/basic_iscsi.yaml
18@@ -12,7 +12,7 @@ storage:
19 - id: vdb1
20 type: partition
21 number: 1
22- size: 3GB
23+ size: 4GB
24 device: vdb
25 flag: boot
26 - id: vdb2

Subscribers

People subscribed via source and target branches