Merge ~mwhudson/curtin:skip-test_correct_ptype-bionic into curtin:master

Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 8b638105a70c8dec4db569786851f49225e82ea8
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~mwhudson/curtin:skip-test_correct_ptype-bionic
Merge into: curtin:master
Diff against target: 14 lines (+3/-0)
1 file modified
tests/vmtests/test_preserve_raid.py (+3/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Dan Bungert Approve
Review via email: mp+416165@code.launchpad.net

Commit message

skip BionicTestPartitionExistingRAID.test_correct_ptype

The collect script fails on Bionic because lsblk -o PTTYPE does not work
there, so just skip the test there. This was the only failing vmtest
overnight!!

To post a comment you must log in.
Revision history for this message
Dan Bungert (dbungert) wrote :

This is fine, or if we don't expect to ever fix this, the test could be dropped.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/vmtests/test_preserve_raid.py b/tests/vmtests/test_preserve_raid.py
2index 4bb977e..04c16b7 100644
3--- a/tests/vmtests/test_preserve_raid.py
4+++ b/tests/vmtests/test_preserve_raid.py
5@@ -56,6 +56,9 @@ class BionicTestPartitionExistingRAID(
6 relbase.bionic, TestPartitionExistingRAID):
7 __test__ = True
8
9+ def test_correct_ptype(self):
10+ self.skipTest("lsblk on bionic does not support PTTYPE")
11+
12
13 class FocalTestPartitionExistingRAID(
14 relbase.focal, TestPartitionExistingRAID):

Subscribers

People subscribed via source and target branches