Merge ~mwhudson/curtin:v2-partprobe-argh into curtin:master
Status: | Merged |
---|---|
Approved by: | Michael Hudson-Doyle |
Approved revision: | 213ebb2820508bc33ea833118880e1463e15e649 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~mwhudson/curtin:v2-partprobe-argh |
Merge into: | curtin:master |
Diff against target: |
31 lines (+13/-9) 1 file modified
curtin/commands/block_meta_v2.py (+13/-9) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dan Bungert | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+415998@code.launchpad.net |
Commit message
block_meta_v2: change how we invoke sfdisk again, restore partprobe call
It's a bit disappointingly empirical but some multipath vmtests fail
with the current sfdisk arguments with "device busy" type errors. I
think this points to a bug somewhere else but the current partition code
works in this situation so massage things so that the new code does too.
Now we pass --no-tell-kernel to sfdisk, we do need to tell the kernel
about the changes so put back a call to partprobe to do this. This is
actually needed independent of the above change, because it seems sfdisk
with default arguments does not cause the kernel to remove the device
node for a deleted partition!
PASSED: Continuous integration, rev:213ebb28205 08bc33ea8331188 80e1463e15e649 /jenkins. ubuntu. com/server/ job/curtin- ci/262/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-amd64/ 262/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 262/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 262/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 262/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/262/ /rebuild
https:/