Merge ~mwhudson/curtin:image-action into curtin:master

[Michael Hudson-Doyle]

Add integration tests for some partitioning operations

This adds a new test directory, tests/integration, which sits
between the unittests and the vmtests in some sense. I've added a
way for curtin storage operations to operate on a file-backed
loop device rather than a real block device and written some
tests to cover the behaviour of partition_handler by actually
running block meta and then inspecting the resulting disk image
to check the results match expectations.

This is all motivated by the changes I want to make to support
editing partition tables.

Nothing runs these tests automatically yet, need to think about
that. Currently you can run them by hand with:

  sudo python3 -m pytest tests/integration/test_block_meta.py

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:2cb9d1552b3149b8346a7a9bea47c736b695d54b
https://jenkins.ubuntu.com/server/job/curtin-ci/184/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/184/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/184/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/184/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/184/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/184//rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:67b875b947d1b63a92f440730c94641279b96384
https://jenkins.ubuntu.com/server/job/curtin-ci/185/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/185/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/185/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/185/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/185/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/185//rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:6904d4bf5b46459d8d442aea08469cd51ba276bc
https://jenkins.ubuntu.com/server/job/curtin-ci/186/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/186/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/186//rebuild

review: Approve (continuous-integration)

[Dan Bungert (dbungert)]

review: Needs Information

[Michael Hudson-Doyle (mwhudson)]

Thanks for the comments, pushed a new revision

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:60019a637e31234bf38e90d1f2ddf321229ac046
https://jenkins.ubuntu.com/server/job/curtin-ci/188/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/188/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/188/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/188/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/188/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/188//rebuild

review: Needs Fixing (continuous-integration)

[Michael Hudson-Doyle (mwhudson)]

Thanks for the comments, pushed a commit which addresses most of them.

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:9e9a7cc092519e71782ac62389cdac12d33b1ab3
https://jenkins.ubuntu.com/server/job/curtin-ci/189/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/189/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/189/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/189/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/189/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/189//rebuild

review: Needs Fixing (continuous-integration)

[Dan Bungert (dbungert)]

Thanks for this, I think it will be quite helpful.

review: Approve

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/105/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/105/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/105/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/105/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/105/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/106/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/106/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/106/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/106/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/106/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/107/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/107/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/107/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/107/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/107/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/108/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/108/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/108/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/108/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/108/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/109/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/109/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/109/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/109/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/109/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/110/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/110/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/110/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/110/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/110/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/111/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/111/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/111/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/111/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/111/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/112/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/112/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/112/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/112/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/112/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/113/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/113/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/113/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/113/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/113/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/114/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/114/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/114/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/114/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/114/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/115/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/115/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/115/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/115/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/115/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/116/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/116/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/116/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/116/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/116/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/117/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/117/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/117/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/117/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/117/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/118/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/118/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/118/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/118/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/118/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/119/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/119/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/119/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/119/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/119/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/120/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/120/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/120/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/120/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/120/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/121/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/121/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/121/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/121/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/121/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/122/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/122/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/122/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/122/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/122/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/123/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/123/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/123/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/123/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/123/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/124/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/124/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/124/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/124/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/124/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/125/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/125/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/125/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/125/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/125/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/126/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/126/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/126/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/126/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/126/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/127/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/127/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/127/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/127/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/127/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/128/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/128/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/128/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/128/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/128/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/129/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/129/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/129/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/129/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/129/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/130/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/130/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/130/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/130/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/130/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/131/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/131/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/131/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/131/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/131/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/132/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/132/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/132/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/132/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/132/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/133/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/133/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/133/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/133/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/133/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/134/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/134/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/134/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/134/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/134/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/135/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/135/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/135/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/135/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/135/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/136/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/136/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/136/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/136/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/136/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/137/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/137/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/137/
    ABORTED: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/137/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/137/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

review: Approve (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/138/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/138/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/138/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/138/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/138/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

review: Approve (continuous-integration)

diff --git a/curtin/block/__init__.py b/curtin/block/__init__.py
index a33ccf2..5046eb9 100644
--- a/curtin/block/__init__.py
+++ b/curtin/block/__init__.py
@@ -132,7 +132,8 @@ def partition_kname(disk_kname, partition_number):
                     os.path.realpath('%s-part%s' % (disk_link,
                                                     partition_number)))
 
-    for dev_type in ['bcache', 'nvme', 'mmcblk', 'cciss', 'mpath', 'md']:
+    for dev_type in ['bcache', 'nvme', 'mmcblk', 'cciss', 'mpath', 'md',
+                     'loop']:
         if disk_kname.startswith(dev_type):
             partition_number = "p%s" % partition_number
             break
diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
index aae85c6..dc7efd4 100644
--- a/curtin/commands/block_meta.py
+++ b/curtin/commands/block_meta.py
@@ -72,6 +72,8 @@ CMD_ARGUMENTS = (
                         'choices': ['ext4', 'ext3'], 'default': None}),
      ('--umount', {'help': 'unmount any mounted filesystems before exit',
                    'action': 'store_true', 'default': False}),
+     ('--testmode', {'help': 'enable some test actions',
+                     'action': 'store_true', 'default': False}),
      ('mode', {'help': 'meta-mode to use',
                'choices': [CUSTOM, SIMPLE, SIMPLE_BOOT]}),
      )
@@ -81,7 +83,10 @@ CMD_ARGUMENTS = (
 @logged_time("BLOCK_META")
 def block_meta(args):
     # main entry point for the block-meta command.
-    state = util.load_command_environment(strict=True)
+    if args.testmode:
+        state = {}
+    else:
+        state = util.load_command_environment(strict=True)
     cfg = config.load_command_config(args, state)
     dd_images = util.get_dd_images(cfg.get('sources', {}))
 
@@ -99,7 +104,8 @@ def block_meta(args):
         args.devices = devices
 
     LOG.debug('clearing devices=%s', devices)
-    meta_clear(devices, state.get('report_stack_prefix', ''))
+    if devices:
+        meta_clear(devices, state.get('report_stack_prefix', ''))
 
     # dd-images requires use of meta_simple
     if len(dd_images) > 0 and args.force_mode is False:
@@ -517,6 +523,9 @@ def get_path_to_storage_volume(volume, storage_config):
         volume_path = block.kname_to_path(bcache_kname)
         LOG.debug('got bcache volume path %s', volume_path)
 
+    elif vol.get('type') == 'image':
+        volume_path = vol['dev']
+
     else:
         raise NotImplementedError("cannot determine the path to storage \
             volume '%s' with type '%s'" % (volume, vol.get('type')))
@@ -530,6 +539,28 @@ def get_path_to_storage_volume(volume, storage_config):
     return volume_path
 
 
+DEVS = set()
+
+
+def image_handler(info, storage_config):
+    path = info['path']
+    if os.path.exists(path):
+        os.unlink(path)
+    try:
+        with open(path, 'wb') as fp:
+            fp.truncate(int(util.human2bytes(info['size'])))
+        dev = util.subp([
+            'losetup', '--show', '--find', path],
+            capture=True)[0].strip()
+    except BaseException:
+        if os.path.exists(path):
+            os.unlink(path)
+        raise
+    info['dev'] = dev
+    DEVS.add(dev)
+    disk_handler(info, storage_config)
+
+
 def dasd_handler(info, storage_config):
     """ Prepare the specified dasd device per configuration
 
@@ -1967,7 +1998,11 @@ def meta_custom(args):
         'zpool': zpool_handler,
     }
 
-    state = util.load_command_environment(strict=True)
+    if args.testmode:
+        command_handlers['image'] = image_handler
+        state = {}
+    else:
+        state = util.load_command_environment(strict=True)
     cfg = config.load_command_config(args, state)
 
     storage_config_dict = extract_storage_ordered_dict(cfg)
@@ -1992,6 +2027,9 @@ def meta_custom(args):
                           (item_id, type(error).__name__, error))
                 raise
 
+    if args.testmode:
+        util.subp(['losetup', '--detach'] + list(DEVS))
+
     if args.umount:
         util.do_umount(state['target'], recursive=True)
     return 0
diff --git a/tests/integration/__init__.py b/tests/integration/__init__.py
new file mode 100644
index 0000000..5e43585
--- /dev/null
+++ b/tests/integration/__init__.py
@@ -0,0 +1,3 @@
+# This file is part of curtin. See LICENSE file for copyright and license info.
+
+# This directory contains tests that require root to run, essentially.
diff --git a/tests/integration/test_block_meta.py b/tests/integration/test_block_meta.py
new file mode 100644
index 0000000..f8aa6f3
--- /dev/null
+++ b/tests/integration/test_block_meta.py
@@ -0,0 +1,156 @@
+# This file is part of curtin. See LICENSE file for copyright and license info.
+
+from collections import namedtuple
+import contextlib
+import sys
+import yaml
+
+from curtin import block, udev, util
+
+from tests.unittests.helpers import CiTestCase
+
+
+class IntegrationTestCase(CiTestCase):
+    allowed_subp = True
+
+
[e-mail]
+def loop_dev(image):
+    dev = util.subp(
+        ['losetup', '--show', '--find', '--partscan', image],
+        capture=True, decode='ignore')[0].strip()
+    try:
+        udev.udevadm_trigger([dev])
+        yield dev
+    finally:
+        util.subp(['losetup', '--detach', dev])
+
+
+PartData = namedtuple("PartData", ('number', 'offset', 'size'))
+
+
+def summarize_partitions(dev):
+    # We don't care about the kname
+    return sorted(
+        [PartData(*d[1:]) for d in block.sysfs_partition_data(dev)])
+
+
+class StorageConfigBuilder:
+
+    def __init__(self):
+        self.config = []
+        self.cur_image = None
+
+    def render(self):
+        return {
+            'storage': {
+                'config': self.config,
+                },
+            }
+
+    def add_image(self, *, path, size, **kw):
+        action = {
+            'type': 'image',
+            'id': 'id' + str(len(self.config)),
+            'path': path,
+            'size': size,
+            }
+        action.update(**kw)
+        self.cur_image = action['id']
+        self.config.append(action)
+
+    def add_part(self, *, size, **kw):
+        if self.cur_image is None:
+            raise Exception("no current image")
+        action = {
+            'type': 'partition',
+            'id': 'id' + str(len(self.config)),
+            'device': self.cur_image,
+            'size': size,
+            }
+        action.update(**kw)
+        self.config.append(action)
+
+
+class TestBlockMeta(IntegrationTestCase):
+
+    def run_bm(self, config):
+        config_path = self.tmp_path('config.yaml')
+        with open(config_path, 'w') as fp:
+            yaml.dump(config, fp)
+        cmd = [
+            sys.executable, '-m', 'curtin', '--showtrace', '-vv',
+            '-c', config_path, 'block-meta', '--testmode', 'custom',
+            ]
+        util.subp(cmd)
+
+    def _test_default_offsets(self, ptable):
+        psize = 40 << 20
+        img = self.tmp_path('image.img')
+        config = StorageConfigBuilder()
+        config.add_image(path=img, size='100M', ptable=ptable)
+        config.add_part(size=psize, number=1)
+        config.add_part(size=psize, number=2)
+        self.run_bm(config.render())
+
+        with loop_dev(img) as dev:
+            self.assertEqual(
+                summarize_partitions(dev), [
+                    PartData(
+                        number=1, offset=1 << 20, size=psize),
+                    PartData(
+                        number=2, offset=(1 << 20) + psize, size=psize),
+                ])
+
+    def test_default_offsets_gpt(self):
+        self._test_default_offsets('gpt')
+
+    def test_default_offsets_msdos(self):
+        self._test_default_offsets('msdos')
+
+    def _test_non_default_numbering(self, ptable):
+        psize = 40 << 20
+        img = self.tmp_path('image.img')
+        config = StorageConfigBuilder()
+        config.add_image(path=img, size='100M', ptable=ptable)
+        config.add_part(size=psize, number=1)
+        config.add_part(size=psize, number=4)
+        self.run_bm(config.render())
+
+        with loop_dev(img) as dev:
+            self.assertEqual(
+                summarize_partitions(dev), [
+                    PartData(
+                        number=1, offset=1 << 20, size=psize),
+                    PartData(
+                        number=4, offset=(1 << 20) + psize, size=psize),
+                ])
+
+    def test_non_default_numbering_gpt(self):
+        self._test_non_default_numbering('gpt')
+
+    def BROKEN_test_non_default_numbering_msdos(self):
+        self._test_non_default_numbering('msdos')
+
+    def test_logical(self):
+        img = self.tmp_path('image.img')
+        config = StorageConfigBuilder()
+        config.add_image(path=img, size='100M', ptable='msdos')
+        config.add_part(size='50M', number=1, flag='extended')
+        config.add_part(size='10M', number=5, flag='logical')
+        config.add_part(size='10M', number=6, flag='logical')
+        self.run_bm(config.render())
+
+        with loop_dev(img) as dev:
+            self.assertEqual(
+                summarize_partitions(dev), [
+                    # extended partitions get a strange size in sysfs
+                    PartData(number=1, offset=1 << 20, size=1 << 10),
+                    PartData(number=5, offset=2 << 20, size=10 << 20),
+                    # part 5 takes us to 12 MiB offset, curtin leaves a 1 MiB
+                    # gap.
+                    PartData(number=6, offset=13 << 20, size=10 << 20),
+                ])
+
+            p1kname = block.partition_kname(block.path_to_kname(dev), 1)
+            self.assertTrue(block.is_extended_partition('/dev/' + p1kname))
diff --git a/tests/unittests/test_commands_block_meta.py b/tests/unittests/test_commands_block_meta.py
index 48a3217..c299df0 100644
--- a/tests/unittests/test_commands_block_meta.py
+++ b/tests/unittests/test_commands_block_meta.py
@@ -201,7 +201,8 @@ class TestBlockMetaSimple(CiTestCase):
         mock_write_image.return_value = devname
 
         args = Namespace(target=self.target, devices=None, mode=None,
-                         boot_fstype=None, fstype=None, force_mode=False)
+                         boot_fstype=None, fstype=None, force_mode=False,
+                         testmode=True)
 
         block_meta.block_meta(args)
 
@@ -258,7 +259,8 @@ class TestBlockMetaSimple(CiTestCase):
         mock_write_image.return_value = devname
 
         args = Namespace(target=None, devices=None, mode='custom',
-                         boot_fstype=None, fstype=None, force_mode=False)
+                         boot_fstype=None, fstype=None, force_mode=False,
+                         testmode=True)
 
         block_meta.block_meta(args)