Merge ~mwhudson/curtin:no-dasds-in-get_path_to_storage_volume into curtin:master

[Michael Hudson-Doyle]

remove support for calling get_path_to_storage_volume on a dasd action

there is no code path that will do this today, and this implementation
will not work with some changes I want to make to support dasds passed
via virtio.

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:38f06653b7b288945f74ba57ca36d6496877e4e4
https://jenkins.ubuntu.com/server/job/curtin-ci/4/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/4/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/4/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/4/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/4/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/4//rebuild

review: Approve (continuous-integration)

[Dimitri John Ledkov (xnox)]

my understanding was that in the storage config we emit two volumes - one of type dasd, and another of type disk. Plus partitions.

Such that storage look ups should be only done on the disk/partitions, and not on the type dasd.

I guess, this was added because of supporting api for all the things.

review: Approve

diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
index 30fc817..eada650 100644
--- a/curtin/commands/block_meta.py
+++ b/curtin/commands/block_meta.py
@@ -437,10 +437,6 @@ def get_path_to_storage_volume(volume, storage_config):
             volume_path = block.kname_to_path(partition_kname)
         devsync_vol = os.path.join(disk_block_path)
 
-    elif vol.get('type') == "dasd":
-        dasd_device = dasd.DasdDevice(vol.get('device_id'))
-        volume_path = dasd_device.devname
-
     elif vol.get('type') == "disk":
         # Get path to block device for disk. Device_id param should refer
         # to id of device in storage config