Code review comment for ~mwhudson/curtin:lp-1893818
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> > But in groovy+, the udev rule from multipath-tools that has
> > always attempted to remove the devices nodes for the partitions
> > of a disk that is a multipath member actually succeeds, and
>
> Won't this break curtin on older multipaths that don't have this rule?
No, if the device node for a partition of a disk that is a multipath member is still present, this branch ignores it (or at least that's the intent...)
> Or will this work with older multipath output since we're only referring to
> the mpath dev (rather than a path of the mpath device)?
Er, I think so. Not completely sure about the distinction you're making here.
> Some comments inline.
Replies inline.